date:20240220

Re: [Django] #32114: Workaround for subtest issue with parallel test runner

2024-02-20 Thread Django

#32114: Workaround for subtest issue with parallel test runner
-+-
 Reporter:  Jordan Ephron|Owner:  David
 Type:   |  Wobrock
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  3.1
 Severity:  Normal   |   Resolution:
 Keywords:  Test subtest | Triage Stage:  Accepted
  parallel   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Wobrock):

 * needs_better_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dca92405f-fa466218-852b-46dc-86ba-9395f6b729b9-00%40eu-central-1.amazonses.com.

Re: [Django] #30913: Add support for adding non-key columns to indexes

2024-02-20 Thread Django

#30913: Add support for adding non-key columns to indexes
-+-
 Reporter:  Hannes Ljungberg |Owner:  Hannes
 |  Ljungberg
 Type:  New feature  |   Status:  closed
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  postgresql covering  | Triage Stage:  Ready for
  index include  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"abe6c1f93eb112066691b590052704948789c60f" abe6c1f9]:
 {{{#!CommitTicketReference repository=""
 revision="abe6c1f93eb112066691b590052704948789c60f"
 Refs #30913 -- Corrected IndexesTests.test_index_include_pointing_to_fk().

 This adjusts a test assigning an Index to Meta.constraints.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dca8e9e5f-e0cf73d0-8fa4-4555-98cd-4ed82d776279-00%40eu-central-1.amazonses.com.

Re: [Django] #35242: LANGUAGE_CODE = "fr-CA" provide incorrect TIME_FORMAT

2024-02-20 Thread Django

#35242: LANGUAGE_CODE = "fr-CA" provide incorrect TIME_FORMAT
-+-
 Reporter:  matisa   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  5.0
  Internationalization   |
 Severity:  Release blocker  |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * resolution:   => needsinfo
 * status:  new => closed

Comment:

 The correct way to represent time in the fr-CA locale is using `h` as a
 separator for hours and minutes.

 - https://www.btb.termiumplus.gc.ca/redac-
 chap?lang=eng&lettr=chapsect1&info0=1.1.12
 - https://metacpan.org/dist/DateTime-
 Locale/view/lib/DateTime/Locale/fr_CA.pod

 What source are you using to determine that the format is wrong?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dca80d051-ced6010e-8d01-46f2-9ce1-14a232793b8b-00%40eu-central-1.amazonses.com.

Re: [Django] #35242: LANGUAGE_CODE = "fr-CA" provide incorrect TIME_FORMAT

2024-02-20 Thread Django

#35242: LANGUAGE_CODE = "fr-CA" provide incorrect TIME_FORMAT
-+-
 Reporter:  matisa   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  5.0
  Internationalization   |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by matisa):

 Overriding the folrmat in the settings file does not work
 TIME_FORMAT = "H:i"
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dca6b09ea-93b7d052-4ea1-4791-820e-e0d761faa8f0-00%40eu-central-1.amazonses.com.

[Django] #35242: LANGUAGE_CODE = "fr-CA" provide incorrect TIME_FORMAT

2024-02-20 Thread Django

#35242: LANGUAGE_CODE = "fr-CA" provide incorrect TIME_FORMAT
+
   Reporter:  matisa|  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Internationalization  |Version:  5.0
   Severity:  Release blocker   |   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 from django.utils import translation
 from django.utils.formats import get_format

 # Temporarily activate the "fr-CA" locale
 translation.activate('fr-CA')

 # Get date and time formats
 date_format = get_format('DATE_FORMAT')
 time_format = get_format('TIME_FORMAT')
 datetime_format = get_format('DATETIME_FORMAT')

 print("Date format:", date_format)
 Date format: j F Y
 print("Time format:", time_format)
 Time format: H h i << This is wrong
 print("Datetime format:", datetime_format)
 Datetime format: j F Y, H h i
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dca69e291-f29b5a49-03fe-416e-9abf-0df1b57ef7e8-00%40eu-central-1.amazonses.com.

Re: [Django] #35237: Optimize system checks for admin actions

2024-02-20 Thread Django

#35237: Optimize system checks for admin actions
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  closed
Component:  Core (System |  Version:  dev
  checks)|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"98e6f2396cd02180d772877d167008e00a683e44" 98e6f23]:
 {{{#!CommitTicketReference repository=""
 revision="98e6f2396cd02180d772877d167008e00a683e44"
 Fixed #35237 -- Merged system checks for admin actions.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dca18ffac-cf698042-94b7-42ac-96c7-23e071d45c92-00%40eu-central-1.amazonses.com.

Re: [Django] #27452: Add Postgres serial field to contrib.postgres

2024-02-20 Thread Django

#27452: Add Postgres serial field to contrib.postgres
-+-
 Reporter:  Johannes Maron   |Owner:
 |  InvalidInterrupt
 Type:  New feature  |   Status:  assigned
Component:  contrib.postgres |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Simon Charette):

 FWIW [https://forum.djangoproject.com/t/django-4-2-is-a-2nd-autofield-
 like-field-on-a-model-possible/28278/4 someone was able to implement] an
 `IdentityField` which is kind of the equivalent of `GeneratedField` if it
 supported `AS IDENTITY`. It's not the equivalent of `SerialField` though
 but it demonstrates that all the pieces are there to implement it based on
 `db_returning` and `pre_save` returning a `Default` expression.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dca029bfe-989a90a7-4cdd-4ee2-b5ae-2bfb9f398486-00%40eu-central-1.amazonses.com.

Re: [Django] #35237: Optimize system checks for admin actions

2024-02-20 Thread Django

#35237: Optimize system checks for admin actions
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  assigned
Component:  Core (System |  Version:  dev
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc9ec2f11-353ca9de-d8db-4e0c-9683-e8f385e63b73-00%40eu-central-1.amazonses.com.

Re: [Django] #35238: Missing chunk_size kwarg throws exception when creating test DB if model has base-manager with prefetches

2024-02-20 Thread Django

#35238: Missing chunk_size kwarg throws exception when creating test DB if model
has base-manager with prefetches
-+-
 Reporter:  alexcleduc   |Owner:
 |  alexcleduc
 Type:  Bug  |   Status:  closed
Component:  Core |  Version:  5.0
  (Serialization)|
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"69e5b13c758cec55edbab342da8be509557589f4" 69e5b13]:
 {{{#!CommitTicketReference repository=""
 revision="69e5b13c758cec55edbab342da8be509557589f4"
 [5.0.x] Fixed #35238 -- Fixed database serialization crash when base
 managers use prefetch_related().

 Regression in 139135627650ed6aaaf4c755b82c3bd43f2b8f51
 following deprecation in eedbf930287cb72e9afab1f7208c24b1146b0c4ec.

 Backport of a084c5d35a6d00abd261338a374a4424764b4aee from main
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc9e260e9-e5ae3387-0f65-42df-a0a6-839b0311f956-00%40eu-central-1.amazonses.com.

Re: [Django] #35238: Missing chunk_size kwarg throws exception when creating test DB if model has base-manager with prefetches

2024-02-20 Thread Django

#35238: Missing chunk_size kwarg throws exception when creating test DB if model
has base-manager with prefetches
-+-
 Reporter:  alexcleduc   |Owner:
 |  alexcleduc
 Type:  Bug  |   Status:  closed
Component:  Core |  Version:  5.0
  (Serialization)|
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"a084c5d35a6d00abd261338a374a4424764b4aee" a084c5d3]:
 {{{#!CommitTicketReference repository=""
 revision="a084c5d35a6d00abd261338a374a4424764b4aee"
 Fixed #35238 -- Fixed database serialization crash when base managers use
 prefetch_related().

 Regression in 139135627650ed6aaaf4c755b82c3bd43f2b8f51
 following deprecation in eedbf930287cb72e9afab1f7208c24b1146b0c4ec.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc9e1557f-a3126e8a-bd8b-4b68-acac-4e611e47cafc-00%40eu-central-1.amazonses.com.

Re: [Django] #35239: FilteredSelectMultiple (filter_horizontal) initial selections reset when refreshing in Firefox

2024-02-20 Thread Django

#35239: FilteredSelectMultiple (filter_horizontal) initial selections reset when
refreshing in Firefox
-+-
 Reporter:  Rachid Mrad  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
  FilteredSelectMultiple,|  Unreviewed
  filter_horizontal, Firefox |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * resolution:  needsinfo => duplicate

Comment:

 This looks like #33386 but I cannot reproduce with Firefox 122.0.1 on
 Ubuntu. We could reopen that ticket if the issue is the same and we have
 more details about how to reproduce it, although the browser might be at
 fault rather than Django.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc960baed-2a28290e-ca0a-4a07-b5d6-fbe489a47c43-00%40eu-central-1.amazonses.com.

Re: [Django] #35140: Increase font size in Django debug views (404, 500, etc)

2024-02-20 Thread Django

#35140: Increase font size in Django debug views (404, 500, etc)
-+-
 Reporter:  Eliana Rosselli  |Owner:  Eliana
 Type:   |  Rosselli
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility font   | Triage Stage:  Accepted
  size   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Eliana Rosselli):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc8b4b6a5-b3e597ba-c68f-465d-91e9-3f1f0cdb5ff9-00%40eu-central-1.amazonses.com.

[Django] #35241: Cache Model._meta.get_parent_list()

2024-02-20 Thread Django

`Model._meta.get_parent_list()` computes the flattened list of ancestor
models by MRO. This list is immutable, deterministic, and recursively
constructed through the inheritance hierarchy. These properties make it a
prime candidate for caching.

I found this method was taking ~1% of the total runtime for system checks
on a project with 118 models. After adding caching, it’s reduced to a
negligible amount.

`get_parent_list()` is called in many other code paths, so caching will
help all of those too.
--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018dc8ad54ca-4e06889a-0acb-4a82-af95-6be4b8369464-00%40eu-central-1.amazonses.com.

Re: [Django] #35232: Cache Options.verbose_name_raw

2024-02-20 Thread Django

#35232: Cache Options.verbose_name_raw
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Adam Johnson:

Old description:

> Another candidate for caching, like #35230, following the same system
> check profiling.
>
> The `Model._meta.verbose_name_raw` property returns the stringified
> version of the `verbose_name` attribute whilst temporarily disabling
> translations. It is only used in `django.contrib.auth` for creating
> permission names.
>
> I found this property was taking ~15 of the total runtime for system
> checks on a project with 118 models. calls. Turning it into a
> `cached_property` and adding a no-translation fast path saves nearly all
> this cost, with the below results.
>
> Before: 520 calls taking 10ms
> After: 105 calls taking ~0ms

New description:

 Another candidate for caching, like #35230, following the same system
 check profiling.

 The `Model._meta.verbose_name_raw` property returns the stringified
 version of the `verbose_name` attribute whilst temporarily disabling
 translations. It is only used in `django.contrib.auth` for creating
 permission names.

 I found this property was taking ~15% of the total runtime for system
 checks on a project with 118 models. calls. Turning it into a
 `cached_property` and adding a no-translation fast path saves nearly all
 this cost, with the below results.

 Before: 520 calls taking 10ms
 After: 105 calls taking ~0ms

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc8a9b536-ff787a10-ca30-49c4-816d-dd7fbcc1f697-00%40eu-central-1.amazonses.com.

Re: [Django] #35240: Django doesn't set Postgres timezone to UTC when using psycopg3

2024-02-20 Thread Django

#35240: Django doesn't set Postgres timezone to UTC when using psycopg3
---+--
 Reporter:  Fabi   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Uncategorized  |  Version:  4.2
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Comment (by Fabi):

 `DATABASES` does not have a `TIME_ZONE` set.

 While there might be other bugs in this specific code, I was able to fix
 this specific problem by defaulting the database to UTC.

 I'll leave it up to you if you want to close this or leave it open for
 further investigation.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc8a7b7f4-d64e689e-b1ec-40ea-a99a-16c596c0dc8a-00%40eu-central-1.amazonses.com.

Re: [Django] #35238: Missing chunk_size kwarg throws exception when creating test DB if model has base-manager with prefetches

2024-02-20 Thread Django

#35238: Missing chunk_size kwarg throws exception when creating test DB if model
has base-manager with prefetches
-+-
 Reporter:  alexcleduc   |Owner:
 |  alexcleduc
 Type:  Bug  |   Status:  assigned
Component:  Core |  Version:  5.0
  (Serialization)|
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_docs:  1 => 0
 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc860d452-8093152e-d60e-4f03-9d3c-aaafad3738cc-00%40eu-central-1.amazonses.com.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

2024-02-20 Thread Django

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  Adam
 |  Zapletal
 Type:  New feature  |   Status:  closed
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"eb2d49b73408f1e60b8e1fa7fee822816945e1cd" eb2d49b]:
 {{{#!CommitTicketReference repository=""
 revision="eb2d49b73408f1e60b8e1fa7fee822816945e1cd"
 Fixed #23759 -- Preserved all file extensions in
 Storage.get_available_name().
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc85dafde-a23fbc06-daaa-44e4-9f42-d563b93e2e7d-00%40eu-central-1.amazonses.com.

Re: [Django] #23759: Storage.get_available_name should preserve all file extensions, not just the first one

2024-02-20 Thread Django

#23759: Storage.get_available_name should preserve all file extensions, not just
the first one
-+-
 Reporter:  thenewguy|Owner:  Adam
 |  Zapletal
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin

Comment:

 [https://github.com/django/django/pull/17881 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc8241d0a-cdfd9225-d06f-4ab4-a637-6d7443c64ac2-00%40eu-central-1.amazonses.com.

Re: [Django] #34900: Python 3.13 compatibility.

2024-02-20 Thread Django

#34900: Python 3.13 compatibility.
-+-
 Reporter:  Mariusz Felisiak |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Other) |  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by GitHub ):

 In [changeset:"3426a5c33c36266af42128ee9eca4921e68ea876" 3426a5c3]:
 {{{#!CommitTicketReference repository=""
 revision="3426a5c33c36266af42128ee9eca4921e68ea876"
 Refs #34900 -- Fixed
 CommandTypes.test_help_default_options_with_custom_arguments test on
 Python 3.13+.

 
https://github.com/python/cpython/commit/c4a2e8a2c5188c3288d57b80852e92c83f46f6f3
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc81a205b-d9983bac-1baa-4a3e-8cb6-58e27e16dc03-00%40eu-central-1.amazonses.com.

Re: [Django] #30950: Replace file with importlib.resources

2024-02-20 Thread Django

#30950: Replace __file__ with importlib.resources
-+-
 Reporter:  John Vandenberg  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  freezers | Triage Stage:  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Natalia Bidart):

 Related to the latest comment: https://github.com/django/django/pull/17870
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc814e536-24c75280-fb74-4711-a30b-b0b2a2bab8b4-00%40eu-central-1.amazonses.com.

Re: [Django] #35240: Django doesn't set Postgres timezone to UTC when using psycopg3

2024-02-20 Thread Django

#35240: Django doesn't set Postgres timezone to UTC when using psycopg3
---+--
 Reporter:  Fabi   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Uncategorized  |  Version:  4.2
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Natalia Bidart):

 * resolution:   => needsinfo
 * status:  new => closed

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc7f2844d-f7707005-fe4a-4720-bb95-932826015c9d-00%40eu-central-1.amazonses.com.

Re: [Django] #35240: Django doesn't set Postgres timezone to UTC when using psycopg3

2024-02-20 Thread Django

* cc: Mariusz Felisiak, Florian Apolloner, Simon Charette (added)

Comment:

Hello Fabi, thank you for your report.

Could you please provide details about your settings for `DATABASES`? From
[https://docs.djangoproject.com/en/5.0/ref/settings/#time-zone these
docs]:

> TIME_ZONE
> Default: None
> A string representing the time zone for this database connection or None
[...]
> When USE_TZ is True, reading datetimes from the database returns aware
datetimes with the timezone set to this option’s value if not None, or to
UTC otherwise.

Also, could you please try using latest Django 5.0 or from the `main`
branch? Django 4.2 is not receiving bug fixes any more so we'd need to
confirm is this is still an issue in newer/supported versions.

In any case, it's unexpected (to me) that from the source links you
provided, `get_adapters_template` takes two parameters `use_tz, timezone`
but only `timezone` is used.
--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018dc7f24a43-1c0963e9-d8fe-4247-8dcc-af799eb0add2-00%40eu-central-1.amazonses.com.

Re: [Django] #35239: FilteredSelectMultiple (filter_horizontal) initial selections reset when refreshing in Firefox

2024-02-20 Thread Django

#35239: FilteredSelectMultiple (filter_horizontal) initial selections reset when
refreshing in Firefox
-+-
 Reporter:  Rachid Mrad  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
  FilteredSelectMultiple,|  Unreviewed
  filter_horizontal, Firefox |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * resolution:   => needsinfo
 * status:  new => closed

Comment:

 Hello Rachid Mrad, thank you for your report!

 Could you please provide more details about the exact issue you are
 having? I read the ticket title, and the links, but it's unclear to me how
 to try to reproduce this myself. Please provide, ideally, either detailed
 steps to reproduce or a sample/minimal test project so we re-open with
 more concrete information.

 Also, please note that Django 4.2 is not receiving bug fixes anymore, so
 before re-opening, please check if this is solved in the `main` branch of
 Django.

 Thank you!
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc7cf4df3-feac84b7-0940-4da7-b37c-fa6cb2f6b1c2-00%40eu-central-1.amazonses.com.

Re: [Django] #34429: Allow to set unusable password via admin UI

2024-02-20 Thread Django

#34429: Allow to set unusable password via admin UI
-+-
 Reporter:  Tobias Bengfort  |Owner:  Fabian
 |  Braun
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Natalia <124304+nessita@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"e626716c28b6286f8cf0f8174077f3d2244f3eb3" e626716c]:
 {{{#!CommitTicketReference repository=""
 revision="e626716c28b6286f8cf0f8174077f3d2244f3eb3"
 Fixed #34429 -- Allowed setting unusable passwords for users in the auth
 forms.

 Co-authored-by: Natalia <124304+ness...@users.noreply.github.com>
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc7b3e970-112ad967-f5aa-4d32-a24c-17f1f23e1618-00%40eu-central-1.amazonses.com.

Re: [Django] #34429: Allow to set unusable password via admin UI

2024-02-20 Thread Django

#34429: Allow to set unusable password via admin UI
-+-
 Reporter:  Tobias Bengfort  |Owner:  Fabian
 |  Braun
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Natalia <124304+nessita@…>):

 In [changeset:"8a757244f9e50c4d076e559e4b74b9d83ab089b6" 8a75724]:
 {{{#!CommitTicketReference repository=""
 revision="8a757244f9e50c4d076e559e4b74b9d83ab089b6"
 Refs #34429 -- Defined test user with unusable password for auth forms
 tests.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc7b3e933-9741e425-ecd6-4104-9e76-4a18631c2ee9-00%40eu-central-1.amazonses.com.

Re: [Django] #34429: Allow to set unusable password via admin UI

2024-02-20 Thread Django

#34429: Allow to set unusable password via admin UI
-+-
 Reporter:  Tobias Bengfort  |Owner:  Fabian
 |  Braun
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Natalia <124304+nessita@…>):

 In [changeset:"f64c528c17af91333fc6e96d91b5f13c0fb647d8" f64c528]:
 {{{#!CommitTicketReference repository=""
 revision="f64c528c17af91333fc6e96d91b5f13c0fb647d8"
 Refs #34429 -- Created `SetPasswordMixin` to reuse password validation
 logic in auth forms.

 Co-authored-by: Natalia <124304+ness...@users.noreply.github.com>
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc7b3e918-09b61765-bd1b-49bf-9796-f98b74c815b7-00%40eu-central-1.amazonses.com.

Re: [Django] #35240: Django doesn't set Postgres timezone to UTC when using psycopg3

2024-02-20 Thread Django

#35240: Django doesn't set Postgres timezone to UTC when using psycopg3
---+--
 Reporter:  Fabi   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Uncategorized  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Fabi):

 * version:  5.0 => 4.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc765aee0-b7972a48-0d63-4259-bba7-e2802030648d-00%40eu-central-1.amazonses.com.

Re: [Django] #35240: Django doesn't set Postgres timezone to UTC when using psycopg3

2024-02-20 Thread Django

#35240: Django doesn't set Postgres timezone to UTC when using psycopg3
---+--
 Reporter:  Fabi   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Uncategorized  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Description changed by Fabi:

Old description:

> Configuration uses `USE_TZ=True` and database defaults to
> `America/New_York`. I would expect the connection then being set to UTC,
> but it is not changed:
> ```
> In [4]: connections["default"].cursor().connection.info.timezone
> Out[4]: zoneinfo.ZoneInfo(key='America/New_York')
> ```
>
> The wrapper and the psycopg3 timezone adapter both think its UTC though:
> ```
> In [5]: connections["default"].timezone
> Out[5]: datetime.timezone.utc
>
> In [6]:
> connections["default"].cursor().connection.adapters.get_loader(TIMESTAMPTZ_OID,
> Format.TEXT).timezone
> Out[6]: datetime.timezone.utc
> ```
>
> Looking at the code I think the problem is that the adapter gets
> initialized with `self.timezone` which then gets compared with
> `self.timezone` later again, resulting in a no-op:
> -
> https://github.com/django/django/blob/31314980be428c0ab8a6cf40cce0a0c17ead8ec6/django/db/backends/postgresql/base.py#L243-L246
> -
> https://github.com/django/django/blob/31314980be428c0ab8a6cf40cce0a0c17ead8ec6/django/db/backends/postgresql/base.py#L349-L354

New description:

 Configuration uses `USE_TZ=True` and database defaults to
 `America/New_York`. I would expect the connection then being set to UTC,
 but it is not changed:
 {{{
 In [4]: connections["default"].cursor().connection.info.timezone
 Out[4]: zoneinfo.ZoneInfo(key='America/New_York')
 }}}

 The wrapper and the psycopg3 timezone adapter both think its UTC though:
 {{{
 In [5]: connections["default"].timezone
 Out[5]: datetime.timezone.utc

 In [6]:
 connections["default"].cursor().connection.adapters.get_loader(TIMESTAMPTZ_OID,
 Format.TEXT).timezone
 Out[6]: datetime.timezone.utc
 }}}

 Looking at the code I think the problem is that the adapter gets
 initialized with `self.timezone` which then gets compared with
 `self.timezone` later again, resulting in a no-op:
 -
 
https://github.com/django/django/blob/31314980be428c0ab8a6cf40cce0a0c17ead8ec6/django/db/backends/postgresql/base.py#L243-L246
 -
 
https://github.com/django/django/blob/31314980be428c0ab8a6cf40cce0a0c17ead8ec6/django/db/backends/postgresql/base.py#L349-L354

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc764ce58-32286bd2-bf2c-4e15-9068-a9a0d6771a2d-00%40eu-central-1.amazonses.com.

[Django] #35240: Django doesn't set Postgres timezone to UTC when using psycopg3

2024-02-20 Thread Django

#35240: Django doesn't set Postgres timezone to UTC when using psycopg3
-+
   Reporter:  Fabi   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Uncategorized  |Version:  5.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Configuration uses `USE_TZ=True` and database defaults to
 `America/New_York`. I would expect the connection then being set to UTC,
 but it is not changed:
 ```
 In [4]: connections["default"].cursor().connection.info.timezone
 Out[4]: zoneinfo.ZoneInfo(key='America/New_York')
 ```

 The wrapper and the psycopg3 timezone adapter both think its UTC though:
 ```
 In [5]: connections["default"].timezone
 Out[5]: datetime.timezone.utc

 In [6]:
 connections["default"].cursor().connection.adapters.get_loader(TIMESTAMPTZ_OID,
 Format.TEXT).timezone
 Out[6]: datetime.timezone.utc
 ```

 Looking at the code I think the problem is that the adapter gets
 initialized with `self.timezone` which then gets compared with
 `self.timezone` later again, resulting in a no-op:
 -
 
https://github.com/django/django/blob/31314980be428c0ab8a6cf40cce0a0c17ead8ec6/django/db/backends/postgresql/base.py#L243-L246
 -
 
https://github.com/django/django/blob/31314980be428c0ab8a6cf40cce0a0c17ead8ec6/django/db/backends/postgresql/base.py#L349-L354
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc763fd58-bdcfcc83-eb4d-4da0-9147-7d0935cb85fb-00%40eu-central-1.amazonses.com.

Re: [Django] #35239: FilteredSelectMultiple (filter_horizontal) initial selections reset when refreshing in Firefox

2024-02-20 Thread Django

#35239: FilteredSelectMultiple (filter_horizontal) initial selections reset when
refreshing in Firefox
-+-
 Reporter:  rachidatecs  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  FilteredSelectMultiple,|  Unreviewed
  filter_horizontal, Firefox |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by rachidatecs):

 * Attachment "Screenshot 2024-02-15 at 3.36.12 PM.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc7478bee-fab96f7a-25c1-450a-a30a-aa46c91c73a7-00%40eu-central-1.amazonses.com.

[Django] #35239: FilteredSelectMultiple (filter_horizontal) initial selections reset when refreshing in Firefox

2024-02-20 Thread Django

#35239: FilteredSelectMultiple (filter_horizontal) initial selections reset when
refreshing in Firefox
-+-
   Reporter: |  Owner:  nobody
  rachidatecs|
   Type:  Bug| Status:  new
  Component: |Version:  4.2
  contrib.admin  |   Keywords:
   Severity:  Normal |  FilteredSelectMultiple,
   Triage Stage: |  filter_horizontal, Firefox
  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 I put a breakpoint on SelectBox.js line 72 and narrowed it down to if
 option.selected (l 75) returning False when it should return True in
 Firefox.

 I overrode the FilteredSelectMultiple template and added
 autocomplete="off" to the available select to fix the bug in my project,
 credit to [this post]https://stackoverflow.com/questions/66728451/html-
 select-not-showing-selected-option-after-refresh-in-firefox on Stack
 Overflow.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc746c6a9-2a373c7d-f313-451f-af82-39f690a8a724-00%40eu-central-1.amazonses.com.

Re: [Django] #34429: Allow to set unusable password via admin UI

2024-02-20 Thread Django

#34429: Allow to set unusable password via admin UI
-+-
 Reporter:  Tobias Bengfort  |Owner:  Fabian
 |  Braun
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Natalia Bidart):

 * stage:  Accepted => Ready for checkin

Comment:

 Multiple round of reviews later, and some further UI/UX, tests and docs
 tweaks, this is ready for checkin! \o/
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc7063beb-f1bbb9aa-7dfe-44bc-90c3-761087cecf37-00%40eu-central-1.amazonses.com.

Re: [Django] #35235: ArrayAgg() doesn't return default when filter contains __in=[].

2024-02-20 Thread Django

#35235: ArrayAgg() doesn't return default when filter contains __in=[].
--+--
 Reporter:  Per Carlsen   |Owner:  Sharon Woo
 Type:  Bug   |   Status:  assigned
Component:  contrib.postgres  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:  ArrayAgg  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Comment (by David Sanders):

 Replying to [comment:6 Sharon Woo]:
 > Thanks for being patient with me. Let me get through everything and come
 back with an improved PR, I have some time this week.

 No worries, everyone is on Discord (chat) or the forum if you need help
 with anything 👍  Details here: https://www.djangoproject.com/community/
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc6d99929-28856c40-5cad-4a8f-9126-48a957137bbd-00%40eu-central-1.amazonses.com.

Re: [Django] #35235: ArrayAgg() doesn't return default when filter contains __in=[].

2024-02-20 Thread Django

#35235: ArrayAgg() doesn't return default when filter contains __in=[].
--+--
 Reporter:  Per Carlsen   |Owner:  Sharon Woo
 Type:  Bug   |   Status:  assigned
Component:  contrib.postgres  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:  ArrayAgg  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Comment (by Sharon Woo):

 Thanks for being patient with me. Let me get through everything and come
 back with an improved PR, I have some time this week.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc6d1d089-8098a6ed-ab0f-4357-a35f-9ab23529ae26-00%40eu-central-1.amazonses.com.

Re: [Django] #35236: Access Field.attname and Field.column directly

2024-02-20 Thread Django

#35236: Access Field.attname and Field.column directly
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"31314980be428c0ab8a6cf40cce0a0c17ead8ec6" 31314980]:
 {{{#!CommitTicketReference repository=""
 revision="31314980be428c0ab8a6cf40cce0a0c17ead8ec6"
 Fixed #35236 -- Used Field.attname/column attributes instead of
 get_attname()/get_attname_column().
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc66d3fcf-07c6bdc5-b722-4557-b5b9-b3a6408cee86-00%40eu-central-1.amazonses.com.

Re: [Django] #35235: ArrayAgg() doesn't return default when filter contains __in=[].

2024-02-20 Thread Django

#35235: ArrayAgg() doesn't return default when filter contains __in=[].
--+--
 Reporter:  Per Carlsen   |Owner:  Sharon Woo
 Type:  Bug   |   Status:  assigned
Component:  contrib.postgres  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:  ArrayAgg  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Comment (by David Sanders):

 Looks like this patch fixes the issue:

 {{{
 --- a/django/db/models/aggregates.py
 +++ b/django/db/models/aggregates.py
 @@ -92,7 +92,7 @@ class Aggregate(Func):
  return c
  if hasattr(default, "resolve_expression"):
  default = default.resolve_expression(query, allow_joins,
 reuse, summarize)
 -if default._output_field_or_none is None:
 +if default._resolve_output_field() is None:
  default.output_field = c._output_field_or_none
  else:
  default = Value(default, c._output_field_or_none)
 }}}

 The problem is `Aggregate.resolve_expression()` calls
 `default._output_field_or_none` which then caches the `None` because it's
 a `@cached_property` which makes setting the `output_field`
 essentially a no-op.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc63f336f-3b7cde50-3a66-4462-8d43-0fa563e06aa7-00%40eu-central-1.amazonses.com.

Re: [Django] #35236: Access Field.attname and Field.column directly

2024-02-20 Thread Django

#35236: Access Field.attname and Field.column directly
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc6171fbe-d035a3bd-f674-4948-b3b0-0a3bf0017319-00%40eu-central-1.amazonses.com.

Re: [Django] #26001: Make ModelAdmin.search_fields raise data errors on __exact lookups for non-string fields.

2024-02-20 Thread Django

#26001: Make ModelAdmin.search_fields raise data errors on __exact lookups for 
non-
string fields.
--+
 Reporter:  Tim Graham|Owner:  Saurabh
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.admin |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Comment (by Saurabh ):

 PR: https://github.com/django/django/pull/17885
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc608f271-ec0c2563-6983-452c-88f6-5ac9389dd91e-00%40eu-central-1.amazonses.com.

Re: [Django] #35235: ArrayAgg() doesn't return default when filter contains __in=[].

2024-02-20 Thread Django

#35235: ArrayAgg() doesn't return default when filter contains __in=[].
--+--
 Reporter:  Per Carlsen   |Owner:  Sharon Woo
 Type:  Bug   |   Status:  assigned
Component:  contrib.postgres  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:  ArrayAgg  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Comment (by David Sanders):

 If you change felix' example to add
 `output_field=ArrayField(IntegerField())` to the default, it works 👍
 seems related to #35149 where `db_default` required `output_field` set? 🤔
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc5ead045-1991d5e6-c9d3-4b04-a6c9-db0fd22acd60-00%40eu-central-1.amazonses.com.

Re: [Django] #35237: Optimize system checks for admin actions

2024-02-20 Thread Django

#35237: Optimize system checks for admin actions
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  assigned
Component:  Core (System |  Version:  dev
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc5aeb1b2-b435071c-6d34-43d7-8ecd-07e20f2c0ec9-00%40eu-central-1.amazonses.com.

Re: [Django] #35235: ArrayAgg() doesn't return default when filter contains __in=[]. (was: ArrayAgg inconsistent return value when no results)

2024-02-20 Thread Django

#35235: ArrayAgg() doesn't return default when filter contains __in=[].
--+--
 Reporter:  Per Carlsen   |Owner:  Sharon Woo
 Type:  Bug   |   Status:  assigned
Component:  contrib.postgres  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:  ArrayAgg  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Mariusz Felisiak):

 * cc: Simon Charette, Nick Pope (added)
 * stage:  Unreviewed => Accepted
 * summary:  ArrayAgg inconsistent return value when no results =>
 ArrayAgg() doesn't return default when filter contains __in=[].

Comment:

 I was able to reproduce the issue with a small models:
 {{{#!python
 class MyModel(models.Model):
 pass


 class MyOtherModel(models.Model):
 mymodel = models.ForeignKey(MyModel, models.CASCADE)

 for filter_value in ([], [-1]):
 for default in ([], Value([])):
 result = MyModel.objects.annotate(
 annotated_ids=ArrayAgg(
 "myothermodel__id",
 filter=Q(
 myothermodel__id__in=filter_value,
 ),
 default=Value([]),
 )
 ).first().annotated_ids
 print(result, filter_value, default)

 }}}
 results
 {{{
 {} [] []
 {} [] Value([])
 [] [-1] []
 [] [-1] Value([])
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc5acf92d-daa82adf-4aaf-4cd3-a253-fc61142d9a73-00%40eu-central-1.amazonses.com.

Re: [Django] #35235: ArrayAgg inconsistent return value when no results

2024-02-20 Thread Django

#35235: ArrayAgg inconsistent return value when no results
--+--
 Reporter:  Per Carlsen   |Owner:  Sharon Woo
 Type:  Bug   |   Status:  assigned
Component:  contrib.postgres  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:  ArrayAgg  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Sharon Woo):

 * owner:  (none) => Sharon Woo
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc599504e-a4c94955-374b-4de9-9d60-5fb1d596a419-00%40eu-central-1.amazonses.com.

Re: [Django] #35235: ArrayAgg inconsistent return value when no results

2024-02-20 Thread Django

#35235: ArrayAgg inconsistent return value when no results
--+--
 Reporter:  Per Carlsen   |Owner:  (none)
 Type:  Bug   |   Status:  new
Component:  contrib.postgres  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:  ArrayAgg  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Comment (by Sharon Woo):

 New to django core, I couldn't replicate this issue with some simple tests
 in a draft PR: https://github.com/django/django/pull/17890
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc5956cd5-74fb0b8f-b919-4808-b9aa-2d308d699cef-00%40eu-central-1.amazonses.com.

43 matches

Mail list logo