Re: [Django] #35234: ExclusionConstraint.expressions should be checked for foreign relationship references

2024-02-29 Thread Django 
#35234: ExclusionConstraint.expressions should be checked for foreign 
relationship
references
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  closed
Component:  contrib.postgres |  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"daf7d482dbaaa2604241a994c49f442fa15142c1" daf7d48]:
 {{{#!CommitTicketReference repository=""
 revision="daf7d482dbaaa2604241a994c49f442fa15142c1"
 Refs #35234 -- Deprecated CheckConstraint.check in favor of .condition.

 Once the deprecation period ends CheckConstraint.check() can become the
 documented method that performs system checks for BaseConstraint
 subclasses.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df8d389ef-923aed00-faff-4bbb-93d6-5533771168b1-00%40eu-central-1.amazonses.com.

Re: [Django] #35262: Addindex operation generates wrong sql code for Postgresql GinIndex

2024-02-29 Thread Django 
#35262: Addindex operation generates wrong sql code for Postgresql GinIndex
--+--
 Reporter:  pjuhen|Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  contrib.postgres  |  Version:  5.0
 Severity:  Normal|   Resolution:  worksforme
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Mariusz Felisiak):

 * resolution:   => worksforme
 * status:  new => closed

Comment:

 It works for me and is
 
[https://github.com/django/django/blob/f82c67aa217c8dd4320ef697b04a6da1681aa799/tests/postgres_tests/test_indexes.py#L370-L383
 covered] in our test suite.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df86edcfc-6b777871-0498-4923-a191-ca01b38943fa-00%40eu-central-1.amazonses.com.

Re: [Django] #34613: add support for Partitioned cookies

2024-02-29 Thread Django 
#34613: add support for Partitioned cookies
-+-
 Reporter:  Oleg Korsak  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  HTTP handling|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  chips, cookies,  | Triage Stage:  Accepted
  csrf, partitioned  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by BertrandHustle):

 Replying to [comment:10 Terence Honles]:
 > Replying to [comment:9 Michael Wheeler]:
 > > I wonder if it would be possible to follow a similar approach to the
 one that was used to add support for `SameSite`
 
https://github.com/django/django/commit/9a56b4b13ed92d2d5bb00d6bdb905a73bc5f2f0a.
 > >
 > > Not sure if anyone was already planning on tackling this, but if not
 I'd be curious about taking it on as a first time contributor.
 >
 > Thanks for the pointer here. I was actually going to write a WSGI
 middleware, but following what was done for `SameSite` I used the
 following:
 >
 > middleware.py:
 > {{{
 > ...
 > from http import cookies
 >
 > ...
 > cookies.Morsel._flags.add("partitioned")
 > cookies.Morsel._reserved.setdefault("partitioned", "Partitioned")
 >
 > class CookiePartitioningMiddleware(MiddlewareMixin):
 > def process_response(
 > self, request: HttpRequest, response: HttpResponseBase
 > ) -> HttpResponseBase:
 > for name in (
 > getattr(settings, f"{prefix}_COOKIE_NAME")
 > for prefix in ("CSRF", "SESSION", "LANGUAGE")
 > if getattr(settings, f"{prefix}_COOKIE_SECURE")
 > ):
 > if cookie := response.cookies.get(name):
 > cookie["Partitioned"] = True
 >
 > return response
 > }}}
 >
 > and added the middleware to my application.
 >
 > Adding and respecing a `${NAME}_COOKIE_PARTITIONED` would make sense for
 a PR, but for our use case we want to partition all cookies. It ''may''
 also make sense to make sure `${NAME}_COOKIE_SAMESITE` is `'None'` since
 that is [https://developers.google.com/privacy-
 
sandbox/3pcd/chips#:~:text=Note%3A%20Adding%20SameSite%3DNone%20will%20allow%20your%20cookie%20to%20be%20sent%20in%20third%2Dparty%20contexts%20where%20the%20Partitioned%20attribute%20is%20not%20supported%2C%20as%20long%20as%20third%2Dparty%20cookies%20are%20allowed%20in%20browser%20settings.
 recommended for browsers which don't support partitioning via CHIPS]

 FYI, this doesn't seem to work for `sessionid` cookies, the Partitioned
 attr only gets set on the csrftoken.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df7c5475a-62578599-db10-47b7-81ea-6454344a4498-00%40eu-central-1.amazonses.com.

Re: [Django] #35262: Addindex operation generates wrong sql code for Postgresql GinIndex

2024-02-29 Thread Django 
#35262: Addindex operation generates wrong sql code for Postgresql GinIndex
--+--
 Reporter:  pjuhen|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.postgres  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Tim Graham):

 * component:  Uncategorized => contrib.postgres


Old description:

> Hi,
>
> I have created a Gin Index using the folowing code in models.py
>
> ''GinIndex(OpClass(Lower('historique'), name='gin_trgm_ops'),
> name="name_gin_trgm_histo_affaire")''
>
> It generates a migration operation :
>
> ''migrations.AddIndex(
> model_name='affaire',
> index=django.contrib.postgres.indexes.GinIndex(django.contrib.postgres.indexes.OpClass(django.db.models.functions.text.Lower('historique'),
> name='gin_trgm_ops'), name='name_gin_trgm_histo_affaire'),
> ),
>
> ''
>
> The SQL generated instruction is :
>

> ''CREATE INDEX "name_gin_trgm_histo_affaire" ON "affaires_affaire" USING
> gin ((LOWER("historique") gin_trgm_ops));''
>
> It is refused by postgresql.
>
> The right code might be :
>
> CREATE INDEX "name_gin_trgm_histo_affaire" ON "affaires_affaire" USING
> gin (LOWER("historique") );
>
> that accepted by postgresql.
>
> Thanks,
>
> Regards,

New description:

 I have created a Gin Index using the folowing code in models.py
 {{{#!python
 GinIndex(OpClass(Lower('historique'), name='gin_trgm_ops'),
 name="name_gin_trgm_histo_affaire")
 }}}
 It generates a migration operation :

 {{{#!python
 migrations.AddIndex(
 model_name='affaire',
 
index=django.contrib.postgres.indexes.GinIndex(django.contrib.postgres.indexes.OpClass(django.db.models.functions.text.Lower('historique'),
 name='gin_trgm_ops'), name='name_gin_trgm_histo_affaire'),
 )
 }}}

 The SQL generated instruction is :

 {{{#!sql
 CREATE INDEX "name_gin_trgm_histo_affaire" ON "affaires_affaire" USING gin
 ((LOWER("historique") gin_trgm_ops));
 }}}
 It is refused by postgresql.

 The right code might be :
 {{{#!sql
 CREATE INDEX "name_gin_trgm_histo_affaire" ON "affaires_affaire" USING gin
 (LOWER("historique") );
 }}}
 that accepted by postgresql.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df76a4276-2d601dd2-cfdf-4bf9-9cfa-1187c0f46cce-00%40eu-central-1.amazonses.com.

Re: [Django] #22997: Migration fails when removing explicit primary key (Postgres)

2024-02-29 Thread Django 
#22997: Migration fails when removing explicit primary key (Postgres)
-+
 Reporter:  a.lloyd.flanagan@…   |Owner:  bcail
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  migrate primary_key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Comment (by bcail):

 I updated the PR to handle the other issue as well - to generate altered
 fields before added fields.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df6cf74e4-ecdf0b16-fd72-4e61-9ec0-c479d7089d4a-00%40eu-central-1.amazonses.com.

Re: [Django] #22997: Migration fails when removing explicit primary key (Postgres)

2024-02-29 Thread Django 
#22997: Migration fails when removing explicit primary key (Postgres)
-+
 Reporter:  a.lloyd.flanagan@…   |Owner:  bcail
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  migrate primary_key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by bcail):

 * cc: bcail (added)
 * has_patch:  0 => 1
 * owner:  nobody => bcail
 * status:  new => assigned

Comment:

 I opened [https://github.com/django/django/pull/17923 a PR] for one of the
 problems - where a default is added to an AutoField.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df6193738-6c2f24c5-a3a9-4c37-a317-a0bfaff835ec-00%40eu-central-1.amazonses.com.

Re: [Django] #35234: ExclusionConstraint.expressions should be checked for foreign relationship references

2024-02-29 Thread Django 
#35234: ExclusionConstraint.expressions should be checked for foreign 
relationship
references
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  closed
Component:  contrib.postgres |  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"f82c67aa217c8dd4320ef697b04a6da1681aa799" f82c67aa]:
 {{{#!CommitTicketReference repository=""
 revision="f82c67aa217c8dd4320ef697b04a6da1681aa799"
 Fixed #35234 -- Added system checks for invalid model field names in
 ExclusionConstraint.expressions.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df6018987-49ded6e5-b219-4106-ae5e-36c5d79b5eb8-00%40eu-central-1.amazonses.com.

[Django] #35262: Addindex operation generates wrong sql code for Postgresql GinIndex

2024-02-29 Thread Django 
#35262: Addindex operation generates wrong sql code for Postgresql GinIndex
-+
   Reporter:  pjuhen |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Uncategorized  |Version:  5.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Hi,

 I have created a Gin Index using the folowing code in models.py

 ''GinIndex(OpClass(Lower('historique'), name='gin_trgm_ops'),
 name="name_gin_trgm_histo_affaire")''

 It generates a migration operation :

 ''migrations.AddIndex(
 model_name='affaire',
 
index=django.contrib.postgres.indexes.GinIndex(django.contrib.postgres.indexes.OpClass(django.db.models.functions.text.Lower('historique'),
 name='gin_trgm_ops'), name='name_gin_trgm_histo_affaire'),
 ),

 ''

 The SQL generated instruction is :


 ''CREATE INDEX "name_gin_trgm_histo_affaire" ON "affaires_affaire" USING
 gin ((LOWER("historique") gin_trgm_ops));''

 It is refused by postgresql.

 The right code might be :

 CREATE INDEX "name_gin_trgm_histo_affaire" ON "affaires_affaire" USING gin
 (LOWER("historique") );

 that accepted by postgresql.

 Thanks,

 Regards,
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df59f40fb-54b1e473-8032-4f13-a946-dd56ed673e7b-00%40eu-central-1.amazonses.com.

Re: [Django] #35261: Media Path as Objects - Documentation fix and usage example

2024-02-29 Thread Django 
#35261: Media Path as Objects - Documentation fix and usage example
-+-
 Reporter:  Leandro de Souza |Owner:  Leandro
 |  de Souza
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  Documentation,   | Triage Stage:  Accepted
  Media  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Leandro de Souza):

 After reading the docs on how to submit a patch, i haven't figured it out
 from which branch should my patch be based. Should it be from the django's
 "main" branch?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df523b9dd-d47ca1e0-860f-4a4c-921d-ee7ecb52daf5-00%40eu-central-1.amazonses.com.

Re: [Django] #35261: Media Path as Objects - Documentation fix and usage example

2024-02-29 Thread Django 
#35261: Media Path as Objects - Documentation fix and usage example
-+-
 Reporter:  Leandro de Souza |Owner:  Leandro
 |  de Souza
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  Documentation,   | Triage Stage:  Accepted
  Media  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Leandro de Souza):

 * owner:  nobody => Leandro de Souza
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df5218a18-f7d1ea40-9942-47da-a16d-a33cd13e5c6d-00%40eu-central-1.amazonses.com.

Re: [Django] #35261: Media Path as Objects - Documentation fix and usage example

2024-02-29 Thread Django 
#35261: Media Path as Objects - Documentation fix and usage example
--+
 Reporter:  Leandro de Souza  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Documentation |  Version:  4.1
 Severity:  Normal|   Resolution:
 Keywords:  Documentation, Media  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted
 * type:  Uncategorized => Bug

Comment:

 As per the discussion, I’ll accept to fix the error with the `rel` tag.

 I’d suggest doing that in an initial commit.

 Then, I think there’s some review to be done to judge the “better example”
 right. (Enough but not too much)
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df4e5afc7-fb98476f-8321-4243-bd49-21a4fe084405-00%40eu-central-1.amazonses.com.

Re: [Django] #35234: ExclusionConstraint.expressions should be checked for foreign relationship references

2024-02-29 Thread Django 
#35234: ExclusionConstraint.expressions should be checked for foreign 
relationship
references
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.postgres |  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"0fb104dda287431f5ab74532e45e8471e22b58c8" 0fb104dd]:
 {{{#!CommitTicketReference repository=""
 revision="0fb104dda287431f5ab74532e45e8471e22b58c8"
 Refs #35234 -- Moved constraint system checks to Check/UniqueConstraint
 methods.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df4643faf-c5e06bdf-894a-475c-a85d-01165e5845fe-00%40eu-central-1.amazonses.com.

Re: [Django] #35261: Media Path as Objects - Documentation fix and usage example

2024-02-29 Thread Django 
#35261: Media Path as Objects - Documentation fix and usage example
-+-
 Reporter:  Leandro de Souza |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Documentation|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  Documentation,   | Triage Stage:
  Media  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Leandro de Souza:

Old description:

> [Related conversation on forum](https://forum.djangoproject.com/t/media-
> path-as-objects/28470)
>
> Issue: The documentation for [Media Path as
> Objects](https://docs.djangoproject.com/en/4.1/topics/forms/media/#paths-
> as-objects) uses an incorrect attribute (`rel`) on a `script` tag,
> source: [HTML attribute: rel - HTML: HyperText Markup Language |
> MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel).
> Quoted from the source:
>
> `The rel attribute defines the relationship between a linked resource and
> the current document. Valid on , , , and , the
> supported values depend on the element on which the attribute is found.`
>
> Another thing is that the example given for the usage of this new feature
> added on 4.1 is not really that useful. The `JSPath` class in the example
> is just a hardcoded script tag that illustrates how to use the `__str__`
> method to render the tag.
>
> I believe that adding a more useful example would add more "bright" to
> the value that this feature has providen: adding flexibility. Some usage
> examples of this new feature has been added to the conversation on the
> forum.
>
> I would be happy to work on this patch/fix.

New description:

 Related conversation on forum: [https://forum.djangoproject.com/t/media-
 path-as-objects/28470]

 Issue: The documentation for Media Path as Objects
 [https://docs.djangoproject.com/en/4.1/topics/forms/media/#paths-as-
 objects] uses an incorrect attribute (`rel`) on a `script` tag, source:
 HTML attribute: rel - HTML: HyperText Markup Language | MDN
 [https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel]. Quoted
 from the source:

 `The rel attribute defines the relationship between a linked resource and
 the current document. Valid on , , , and , the
 supported values depend on the element on which the attribute is found.`

 Another thing is that the example given for the usage of this new feature
 added on 4.1 is not really that useful. The `JSPath` class in the example
 is just a hardcoded script tag that illustrates how to use the `__str__`
 method to render the tag.

 I believe that adding a more useful example would add more "bright" to the
 value that this feature has providen: adding flexibility. Some usage
 examples of this new feature has been added to the conversation on the
 forum.

 I would be happy to work on this patch/fix.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df43f4286-14e348b1-c2fe-4e35-9801-d64dbf55ea05-00%40eu-central-1.amazonses.com.

[Django] #35261: Media Path as Objects - Documentation fix and usage example

2024-02-29 Thread Django 
#35261: Media Path as Objects - Documentation fix and usage example
-+-
   Reporter:  Leandro|  Owner:  nobody
  de Souza   |
   Type: | Status:  new
  Uncategorized  |
  Component: |Version:  4.1
  Documentation  |   Keywords:  Documentation,
   Severity:  Normal |  Media
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 [Related conversation on forum](https://forum.djangoproject.com/t/media-
 path-as-objects/28470)

 Issue: The documentation for [Media Path as
 Objects](https://docs.djangoproject.com/en/4.1/topics/forms/media/#paths-
 as-objects) uses an incorrect attribute (`rel`) on a `script` tag, source:
 [HTML attribute: rel - HTML: HyperText Markup Language |
 MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel).
 Quoted from the source:

 `The rel attribute defines the relationship between a linked resource and
 the current document. Valid on , , , and , the
 supported values depend on the element on which the attribute is found.`

 Another thing is that the example given for the usage of this new feature
 added on 4.1 is not really that useful. The `JSPath` class in the example
 is just a hardcoded script tag that illustrates how to use the `__str__`
 method to render the tag.

 I believe that adding a more useful example would add more "bright" to the
 value that this feature has providen: adding flexibility. Some usage
 examples of this new feature has been added to the conversation on the
 forum.

 I would be happy to work on this patch/fix.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df43b74eb-d1709798-30d5-40ac-b370-4c3609921032-00%40eu-central-1.amazonses.com.

Re: [Django] #35198: Facet filters crash for queryset with no ID.

2024-02-29 Thread Django 
#35198: Facet filters crash for queryset with no ID.
-+-
 Reporter:  Simon Alef   |Owner:  Shafiya
 |  Adzhani
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"80761c3b01fbbbe2da1761937edd20251a86fbee" 80761c3b]:
 {{{#!CommitTicketReference repository=""
 revision="80761c3b01fbbbe2da1761937edd20251a86fbee"
 [5.0.x] Fixed #35198 -- Fixed facet filters crash on querysets with no
 primary key.

 Thanks Simon Alef for the report.

 Regression in 868e2fcddae6720d5713924a785339d1665f1bb9.

 Backport of a738281265bba5d00711ab62d4d37923764a27eb from main
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df43a1d9b-fa4b2625-e2d9-4264-aad4-7f14a68f405e-00%40eu-central-1.amazonses.com.

Re: [Django] #35198: Facet filters crash for queryset with no ID.

2024-02-29 Thread Django 
#35198: Facet filters crash for queryset with no ID.
-+-
 Reporter:  Simon Alef   |Owner:  Shafiya
 |  Adzhani
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"a738281265bba5d00711ab62d4d37923764a27eb" a7382812]:
 {{{#!CommitTicketReference repository=""
 revision="a738281265bba5d00711ab62d4d37923764a27eb"
 Fixed #35198 -- Fixed facet filters crash on querysets with no primary
 key.

 Thanks Simon Alef for the report.

 Regression in 868e2fcddae6720d5713924a785339d1665f1bb9.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df43a059f-c8516bbd-e062-43f3-94c4-a96be7df1fa5-00%40eu-central-1.amazonses.com.

Re: [Django] #35198: Facet filters crash for queryset with no ID.

2024-02-29 Thread Django 
#35198: Facet filters crash for queryset with no ID.
-+-
 Reporter:  Simon Alef   |Owner:  Shafiya
 |  Adzhani
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018df3fa97b7-fed63ab0-1fdf-43ef-9abe-b0ec197b3774-00%40eu-central-1.amazonses.com.