Re: [Django] #18597: `BaseInlineFormSet` should attempt to get it's queryset from it's instance related manager before falling back to it's model's default manager

2024-03-24 Thread Django
#18597: `BaseInlineFormSet` should attempt to get it's queryset from it's 
instance
related manager before falling back to it's model's default manager
-+-
 Reporter:  Simon Charette   |Owner:  Steven
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  model formset| Triage Stage:  Accepted
  inline |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e741e8f39-f0d2e652-6d80-4c6e-abc9-ebe9cad2a2d5-00%40eu-central-1.amazonses.com.


Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

2024-03-24 Thread Django
#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1

Comment:

 [https://github.com/django/django/pull/18013 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e73fb4f3d-911d7268-9e3a-4d1f-8e3d-84162bcecbe4-00%40eu-central-1.amazonses.com.


[Django] #35328: Improve CSRF Origin checking messaging

2024-03-24 Thread Django
#35328: Improve CSRF Origin checking messaging
+--
   Reporter:  Ryan Hiebert  |  Owner:  nobody
   Type:  New feature   | Status:  assigned
  Component:  CSRF  |Version:  dev
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+--
 A very common misconfiguration is for the
 `SECURE_PROXY_SSL_HEADER` setting to not be configured correctly. This
 causes the origin checks to fail, but the messaging leads folks like me to
 the `CSRF_TRUSTED_ORIGINS` setting, which is not really what you want in
 this scenario. In some cases, like GitHub Codespaces, you may also need
 the `USE_X_FORWARDED_HOST` setting as well.

 I believe we can make some common scenarios easier to fix by improving our
 error messaging. Particularly in `DEBUG` mode, we can show useful
 information about their headers and give a suggestion about what fix might
 be appropriate.

 https://forum.djangoproject.com/t/forwarded-headers-csrf-hints/28616
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e737ec8d9-d1b3dbb2-1a6b-4cc2-9960-88bf85058e29-00%40eu-central-1.amazonses.com.


Re: [Django] #35323: Fix FileExistsError in django/core/files/move.py.

2024-03-24 Thread Django
#35323: Fix FileExistsError in django/core/files/move.py.
-+-
 Reporter:  bcail|Owner:  bcail
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"07c8d979aecf5f1f71ce4f174369df39f24d24b3" 07c8d979]:
 {{{#!CommitTicketReference repository=""
 revision="07c8d979aecf5f1f71ce4f174369df39f24d24b3"
 Fixed #35323 -- Prevented file_move_safe() from trying to overwrite
 existing file when allow_overwrite is False.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e71c604ce-663f9a04-8d94-4c4d-a0d2-808099259330-00%40eu-central-1.amazonses.com.


Re: [Django] #35326: OverwritingStorageTests fail if a TemporaryUploadedFile is used

2024-03-24 Thread Django
#35326: OverwritingStorageTests fail if a TemporaryUploadedFile is used
-+-
 Reporter:  bcail|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by alexialg05):

 can i be assigned on this issue?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e718f073b-dd13953f-c03f-4617-9750-cea79908be20-00%40eu-central-1.amazonses.com.


Re: [Django] #35308: FileNotFoundError escapes from run_formatters()

2024-03-24 Thread Django
#35308: FileNotFoundError escapes from run_formatters()
-+-
 Reporter:  Jacob Walls  |Owner:  Jeetu
 Type:   |  Singh
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  black, code  | Triage Stage:  Accepted
  formatting |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jeetu Singh):

 * cc: Jeetu Singh (added)
 * owner:  nobody => Jeetu Singh
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e7158b973-f1b047d4-cfd4-4294-8e4b-699a2849df19-00%40eu-central-1.amazonses.com.


Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

2024-03-24 Thread Django
#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e710254ff-9d97c66f-b47a-473d-9d81-fe4f76901209-00%40eu-central-1.amazonses.com.


Re: [Django] #35327: Add note to create custom user model in tutorial

2024-03-24 Thread Django
#35327: Add note to create custom user model in tutorial
-+-
 Reporter:  GeoGalvanic  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  documentation| Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * resolution:   => wontfix
 * status:  new => closed

Comment:

 According to the Diátaxis framework, [https://diataxis.fr/tutorials
 /#offer-only-minimum-necessary-explanation a tutorial should provide only
 the minimum necessary explanation]. It cannot and shouldn't explain things
 as user customization. It's already mentioned loudly in the
 [https://docs.djangoproject.com/en/stable/topics/auth/customizing/#using-a
 -custom-user-model-when-starting-a-project authorization topic in docs].
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e70fd74a8-86921a82-6c42-472a-afab-17dec8c61d2c-00%40eu-central-1.amazonses.com.


Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

2024-03-24 Thread Django
#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Jason Hall):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e70d0271a-71fdf3e9-ca45-4f46-abba-3d76bcc14118-00%40eu-central-1.amazonses.com.


Re: [Django] #35321: Django Admin in Mobile Safari zooms in on text inputs

2024-03-24 Thread Django
#35321: Django Admin in Mobile Safari zooms in on text inputs
-+-
 Reporter:  Simon Willison   |Owner:  Jason
 Type:   |  Hall
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  css, accessibility,  | Triage Stage:  Accepted
  mobile |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Comment (by Jason Hall):

 Then, can I just add this:

 label {
 font-size: 1rem;
 }

 to the base.css file in django/contrib/admin/static/admin/css folder?  I
 guess I'll try that and see what happens.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e70c5a9d2-ff20832e-646a-4947-8aad-f8e0057ced74-00%40eu-central-1.amazonses.com.


[Django] #35327: Add note to create custom user model in tutorial

2024-03-24 Thread Django
#35327: Add note to create custom user model in tutorial
-+-
   Reporter: |  Owner:  nobody
  GeoGalvanic|
   Type: | Status:  new
  Cleanup/optimization   |
  Component: |Version:  5.0
  Documentation  |
   Severity:  Normal |   Keywords:  documentation
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
 From the [https://docs.djangoproject.com/en/5.0/topics/auth/customizing
 /#changing-to-a-custom-user-model-mid-project "Customizing User
 Authentication"] documentation:

 {{{
 Changing AUTH_USER_MODEL after you’ve created database tables is
 significantly more difficult since it affects foreign keys and many-to-
 many relationships, for example.
 }}}

 Unfortunately, the tutorial doesn't mention the user model at all, meaning
 it would be quite easy for a new user to create their project long before
 they read over the user authentication documentation that could make their
 lives easier if they're planning on modifying the user model in the
 future.

 Of course, ideally the process would be made simpler (as in:
 [https://code.djangoproject.com/ticket/25313 #25313]) or the default
 project would be set up with a user model to make modifications easier
 later on (as in: [https://code.djangoproject.com/ticket/27909 #27909]).
 Unfortunately neither have been solved in about 7 years  , the former
 seems to be a difficult technical issue, and the later proposal seems to
 have the consensus that a DEP would need to be approved before being
 implemented, which could likely take additional years to solve.

 In the meantime, we could add a note in the "Creating your first Django
 app" tutorial to let the users know that they may want to read the
 documentation on custom user models before proceeding. This would be a
 band-aid fix, but could help new users avoid stumbling into a trap of
 choosing between painful workarounds or simply creating a new project.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e6fe9b766-9aa3201c-65e2-4b96-ba9b-c702e8b2ad31-00%40eu-central-1.amazonses.com.


Re: [Django] #19221: Check that cache keys are string

2024-03-24 Thread Django
#19221: Check that cache keys are string
-+
 Reporter:  Mark Hughes  |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by DKPHUONG):

 * owner:  DKPHUONG => (none)
 * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e6f39cb61-04956734-fd4c-4baa-8349-a7fd476a0653-00%40eu-central-1.amazonses.com.


Re: [Django] #35323: Fix FileExistsError in django/core/files/move.py.

2024-03-24 Thread Django
#35323: Fix FileExistsError in django/core/files/move.py.
-+-
 Reporter:  bcail|Owner:  bcail
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => bcail
 * stage:  Accepted => Ready for checkin
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e6f204706-b625bf27-6c13-42ee-a01f-9c3bd21c6f3c-00%40eu-central-1.amazonses.com.