date:20240521

Re: [Django] #31405: LoginRequiredAuthenticationMiddleware force all views to require authentication by default.

2024-05-21 Thread Django

#31405: LoginRequiredAuthenticationMiddleware force all views to require
authentication by default.
-+-
 Reporter:  Mehmet İnce  |Owner:  Hisham
 |  Mahmood
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"c7fc9f20b49b5889a9a8f47de45165ac443c1a21" c7fc9f20]:
 {{{#!CommitTicketReference repository=""
 revision="c7fc9f20b49b5889a9a8f47de45165ac443c1a21"
 Fixed #31405 -- Added LoginRequiredMiddleware.

 Co-authored-by: Adam Johnson 
 Co-authored-by: Mehmet İnce 
 Co-authored-by: Sarah Boyce <42296566+sarahbo...@users.noreply.github.com>
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9f119c2d-e2a37c88-1162-4416-ae30-a3e19d9b6e3b-00%40eu-central-1.amazonses.com.

Re: [Django] #35470: Separate i18n and l10n globalization settings into two sublists.

2024-05-21 Thread Django

#35470: Separate i18n  and  l10n globalization settings into two sublists.
-+-
 Reporter:  Lufafa Joshua|Owner:  Lufafa
 Type:   |  Joshua
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * component:  Uncategorized => Documentation
 * stage:  Unreviewed => Accepted

Comment:

 Thank you! I agree that, separating
 [https://docs.djangoproject.com/en/5.0/ref/settings/#globalization-i18n-
 l10n Globalization (i18n/l10n) settings] between those that may overriding
 by locale formats and those that don't, is a nice clarification👍
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9f0df4d5-5539a368-c1ae-4ed5-8537-a05d9c6aa601-00%40eu-central-1.amazonses.com.

Re: [Django] #35470: Separate i18n and l10n globalization settings into two sublists.

2024-05-21 Thread Django

#35470: Separate i18n  and  l10n globalization settings into two sublists.
-+-
 Reporter:  Lufafa Joshua|Owner:  Lufafa
 Type:   |  Joshua
  Cleanup/optimization   |   Status:  assigned
Component:  Uncategorized|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Lufafa Joshua):

 * type:  Uncategorized => Cleanup/optimization

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9f094a0b-76912a3c-d217-488a-aa5c-ec7271f6fb50-00%40eu-central-1.amazonses.com.

Re: [Django] #35458: Docs: clarify need for ALLOWED_HOSTS

2024-05-21 Thread Django

* component: Uncategorized => Documentation
* resolution: => needsinfo
* status: new => closed

Comment:

I believe the [https://docs.djangoproject.com/en/5.0/releases/1.4.4/#host-
header-poisoning Django 1.4.4 release notes] gives more context.

I think you're suggesting that Django should recommend or imply having
`ALLOWED_HOSTS` as `["*"]` is safe.
You should discuss this on the
[https://forum.djangoproject.com/c/internals/5 Django forum] and state why
this should be updated/allowed. As this relates to security, we need very
strong consensus and evidence that this is safe before we can make an
update. The security team may also want to review such an update. During
this discussion you might conclude to add some doc clarifications.

I am closing this request for now but if after a discussion you have a
concrete proposal, please reopen the ticket for consideration.
--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018f9f086387-b9b6053b-cb7d-4f93-af62-5c2a1acb171b-00%40eu-central-1.amazonses.com.

Re: [Django] #31405: LoginRequiredAuthenticationMiddleware force all views to require authentication by default.

2024-05-21 Thread Django

#31405: LoginRequiredAuthenticationMiddleware force all views to require
authentication by default.
-+-
 Reporter:  Mehmet İnce  |Owner:  Hisham
 |  Mahmood
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9ed8f180-063aa6b6-1b7d-4a0d-946a-ec62b8c32dd7-00%40eu-central-1.amazonses.com.

Re: [Django] #35189: Accessibility issues with collapsed fieldsets in admin forms

2024-05-21 Thread Django

#35189: Accessibility issues with collapsed fieldsets in admin forms
-+-
 Reporter:  Thibaud Colas|Owner:  Marijke
 Type:   |  Luttekes
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Ready for
  whcm, forced colors, screen|  checkin
  reader, forms, admin   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by nessita <124304+nessita@…>):

 In [changeset:"01ed59f753139afb514170ee7f7384c155ecbc2d" 01ed59f7]:
 {{{#!CommitTicketReference repository=""
 revision="01ed59f753139afb514170ee7f7384c155ecbc2d"
 Refs #35189 -- Improved admin fieldset's accessibility by setting aria-
 labelledby.

 Before this change, HTML  elements in the admin site did not
 have an associated label to describe them. This commit defines a unique
 HTML id for the heading labeling a fieldset, and sets its
 aria-labelledby property to link the heading with the fieldset.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9e4a984f-1232a5de-24bb-4830-9017-04efa38340ec-00%40eu-central-1.amazonses.com.

Re: [Django] #35189: Accessibility issues with collapsed fieldsets in admin forms

2024-05-21 Thread Django

#35189: Accessibility issues with collapsed fieldsets in admin forms
-+-
 Reporter:  Thibaud Colas|Owner:  Marijke
 Type:   |  Luttekes
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  accessibility,   | Triage Stage:  Ready for
  whcm, forced colors, screen|  checkin
  reader, forms, admin   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by nessita <124304+nessita@…>):

 In [changeset:"7857507c7fc43350701700d4215a37baea7655f0" 7857507]:
 {{{#!CommitTicketReference repository=""
 revision="7857507c7fc43350701700d4215a37baea7655f0"
 Refs #35189 -- Removed no longer necessary JavaScript file collapse.js.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9e4a98db-ae755e48-4d4d-41e9-abf7-682b1fad5a8d-00%40eu-central-1.amazonses.com.

Re: [Django] #35189: Accessibility issues with collapsed fieldsets in admin forms

2024-05-21 Thread Django

#35189: Accessibility issues with collapsed fieldsets in admin forms
-+-
 Reporter:  Thibaud Colas|Owner:  Marijke
 Type:   |  Luttekes
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  accessibility,   | Triage Stage:  Ready for
  whcm, forced colors, screen|  checkin
  reader, forms, admin   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by nessita <124304+nessita@…>):

 In [changeset:"676060d683200a19eba006b48e8563280b298c61" 676060d6]:
 {{{#!CommitTicketReference repository=""
 revision="676060d683200a19eba006b48e8563280b298c61"
 Refs #35189 -- Updated ModelAdmin.fieldsets screenshot in admin docs.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9e4a98b9-5aa4e5c1-10ab-42cb-8507-2d3939b9dac5-00%40eu-central-1.amazonses.com.

Re: [Django] #35189: Accessibility issues with collapsed fieldsets in admin forms

2024-05-21 Thread Django

#35189: Accessibility issues with collapsed fieldsets in admin forms
-+-
 Reporter:  Thibaud Colas|Owner:  Marijke
 Type:   |  Luttekes
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  accessibility,   | Triage Stage:  Ready for
  whcm, forced colors, screen|  checkin
  reader, forms, admin   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by nessita <124304+nessita@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"e4a693f50a8342ed1a54b74e1a202b44c8e62981" e4a693f5]:
 {{{#!CommitTicketReference repository=""
 revision="e4a693f50a8342ed1a54b74e1a202b44c8e62981"
 Fixed #35189 -- Improved admin collapsible fieldsets by using 
 elements.

 This work improves the accessibility of the add and change pages in the
 admin site by adding  and  elements to the collapsible
 fieldsets. This has the nice side effect of no longer requiring custom
 JavaScript helpers to implement the fieldsets' show/hide capabilities.

 Thanks to James Scholes for the accessibility advice, and to Sarah Boyce
 and Tom Carrick for reviews.

 Co-authored-by: Natalia <124304+ness...@users.noreply.github.com>
 Co-authored-by: Sarah Boyce <42296566+sarahbo...@users.noreply.github.com>
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9e4a989a-1ce9455d-1ac4-4b1b-b1da-7558bf20e013-00%40eu-central-1.amazonses.com.

Re: [Django] #35471: Make the admin search filter optional in nav sidebar?

2024-05-21 Thread Django

#35471: Make the admin search filter optional in nav sidebar?
---+--
 Reporter:  Ryu|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Description changed by Ryu:

Old description:

> [[Image(ticket:35471:django_1.jpg,50%)]]
>
> Filtering content on navigation sidebar is useful if there is a lot of
> content, but unnecessary if there is little content.
> We also received inquiries about users mistakenly typing in the search
> field and the content was lost.
> We need the ability to make the filtering optional.
>

> == Proposal
>
> Add AdminSite.enable_nav_sidebar_filter and if it is false, hide the
> search field.

New description:

 [[Image(ticket:35471:django_1.jpg,50%)]]

 Filtering content on navigation sidebar is useful if there is a lot of
 content, but unnecessary if there is little content.
 Also, It seems that users of our service are unintentionally making inputs
 into the search field. We have received inquiries from them stating that
 their content has disappeared.
 To avoid user confusion, an option to disable Filtering content on
 navigation sidebar is needed.


 == Proposal

 Add AdminSite.enable_nav_sidebar_filter and if it is false, hide the
 search field.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9debf5fb-014f0abe-02da-414c-b835-f8f9220c7847-00%40eu-central-1.amazonses.com.

Re: [Django] #35471: Make the admin search filter optional in nav sidebar?

2024-05-21 Thread Django

#35471: Make the admin search filter optional in nav sidebar?
---+--
 Reporter:  Ryu|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Description changed by Ryu:

Old description:

> [[Image(ticket:35471:django_1.jpg)]]
>
> Filtering content on navigation sidebar is useful if there is a lot of
> content, but unnecessary if there is little content.
> We also received inquiries about users mistakenly typing in the search
> field and the content was lost.
> We need the ability to make the filtering optional.
>

> == Proposal
>
> Add AdminSite.enable_nav_sidebar_filter and if it is false, hide the
> search field.

New description:

 [[Image(ticket:35471:django_1.jpg,50%)]]

 Filtering content on navigation sidebar is useful if there is a lot of
 content, but unnecessary if there is little content.
 We also received inquiries about users mistakenly typing in the search
 field and the content was lost.
 We need the ability to make the filtering optional.


 == Proposal

 Add AdminSite.enable_nav_sidebar_filter and if it is false, hide the
 search field.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9dd02212-211985ca-0bda-4b88-9aa2-2e9c7c5250ca-00%40eu-central-1.amazonses.com.

Re: [Django] #35471: Make the admin search filter optional in nav sidebar?

2024-05-21 Thread Django

#35471: Make the admin search filter optional in nav sidebar?
---+--
 Reporter:  Ryu|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Description changed by Ryu:

Old description:

> Filtering content on navigation sidebar is useful if there is a lot of
> content, but unnecessary if there is little content.
> We also received inquiries about users mistakenly typing in the search
> field and the content was lost.
> We need the ability to make the filtering optional.
>
> == Proposal
>
> Add AdminSite.enable_nav_sidebar_filter and if it is false, hide the
> search field.

New description:

 [[Image(ticket:35471:django_1.jpg)]]

 Filtering content on navigation sidebar is useful if there is a lot of
 content, but unnecessary if there is little content.
 We also received inquiries about users mistakenly typing in the search
 field and the content was lost.
 We need the ability to make the filtering optional.


 == Proposal

 Add AdminSite.enable_nav_sidebar_filter and if it is false, hide the
 search field.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9dcd6303-ef113475-f431-4637-b775-bd57180fba01-00%40eu-central-1.amazonses.com.

Re: [Django] #35471: Make the admin search filter optional in nav sidebar?

2024-05-21 Thread Django

#35471: Make the admin search filter optional in nav sidebar?
---+--
 Reporter:  Ryu|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Ryu):

 * Attachment "django_1.jpg" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9dcb3b22-3a67b243-ab58-4a11-9458-1d7c7e736e1d-00%40eu-central-1.amazonses.com.

[Django] #35471: Make the admin search filter optional in nav sidebar?

2024-05-21 Thread Django

#35471: Make the admin search filter optional in nav sidebar?
-+
   Reporter:  Ryu|  Owner:  nobody
   Type:  New feature| Status:  new
  Component:  contrib.admin  |Version:  5.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  1  |
-+
 Filtering content on navigation sidebar is useful if there is a lot of
 content, but unnecessary if there is little content.
 We also received inquiries about users mistakenly typing in the search
 field and the content was lost.
 We need the ability to make the filtering optional.

 == Proposal

 Add AdminSite.enable_nav_sidebar_filter and if it is false, hide the
 search field.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9dc996f6-a05a554c-d076-451f-ac3d-def3912aa71f-00%40eu-central-1.amazonses.com.

Re: [Django] #35139: Performing a save() with an ImageField where width_field or height_field is set results in an extra read operation

2024-05-21 Thread Django

#35139: Performing a save() with an ImageField where width_field or 
height_field is
set results in an extra read operation
-+-
 Reporter:  john-parton  |Owner:  john-
 |  parton
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  5.0
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"9c5fe93349bd4339c41d057b87046e5d28be6f77" 9c5fe933]:
 {{{#!CommitTicketReference repository=""
 revision="9c5fe93349bd4339c41d057b87046e5d28be6f77"
 Fixed #35139 -- Prevented file read after ImageField is saved to storage.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9d42f079-b2f66443-0494-44e8-a4bd-35bcee497b69-00%40eu-central-1.amazonses.com.

Re: [Django] #35467: Prefer urlsplit() over urlparse()

2024-05-21 Thread Django

#35467: Prefer urlsplit() over urlparse()
-+-
 Reporter:  Adam Johnson |Owner:  Jake
 Type:   |  Howard
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jake Howard):

 * owner:  nobody => Jake Howard
 * status:  new => assigned

Comment:

 From some basic testing, it looks like this should have a nice
 improvement:

 {{{#!python
 In [1]: import urllib.parse

 In [2]: %timeit urllib.parse.urlparse("https://example.com";)
 1.52 µs ± 37.9 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops
 each)

 In [3]: %timeit urllib.parse.urlsplit("https://example.com";)
 258 ns ± 1.14 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops
 each)
 }}}

 The difference stays about constant, even with longer URLs. The specifics
 will obviously vary by hardware and Python version (the above is 3.12.3),
 but ~6x improvement is definitely worthwhile.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9d2b1f4d-cad02f38-8c59-4214-a1af-18f200672b89-00%40eu-central-1.amazonses.com.

Re: [Django] #18119: add DomainNameValidator to validate Internet Domain Names

2024-05-21 Thread Django

#18119: add DomainNameValidator to validate Internet Domain Names
-+-
 Reporter:  michele  |Owner:  Nina
 |  Menezes
 Type:  New feature  |   Status:  closed
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  validators   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"4971a9afe5642569f3dcfcd3972ebb39e88dd457" 4971a9a]:
 {{{#!CommitTicketReference repository=""
 revision="4971a9afe5642569f3dcfcd3972ebb39e88dd457"
 Fixed #18119 -- Added a DomainNameValidator validator.

 Thanks Claude Paroz for the review.

 Co-authored-by: Nina Menezes <77671865+nmenez...@users.noreply.github.com>
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9cfe85bc-84ba3c17-ffac-4d56-9d84-6e71fe9c0cd1-00%40eu-central-1.amazonses.com.

Re: [Django] #18119: add DomainNameValidator to validate Internet Domain Names

2024-05-21 Thread Django

#18119: add DomainNameValidator to validate Internet Domain Names
-+-
 Reporter:  michele  |Owner:  Nina
 |  Menezes
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  validators   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Claude Paroz):

 OK, let's go for it, at least the parameter default is `True`.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9ceff9e2-25129b5b-329a-4ab6-b0a7-e0eb2f8efbf1-00%40eu-central-1.amazonses.com.

Re: [Django] #35405: Use @cached_property for FieldCacheMixin cache key

2024-05-21 Thread Django

#35405: Use @cached_property for FieldCacheMixin cache key
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by nessita <124304+nessita@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"b9838c65ec2fee36c1fd0d46494ba44da27a9b34" b9838c65]:
 {{{#!CommitTicketReference repository=""
 revision="b9838c65ec2fee36c1fd0d46494ba44da27a9b34"
 Fixed #35405 -- Converted get_cache_name into a cached property in
 FieldCacheMixin.

 FieldCacheMixin is used by related fields to track their cached values.
 This work migrates get_cache_name() to be a cached property to optimize
 performance by reducing unnecessary function calls when working with
 related fields, given that its value remains constant.

 Co-authored-by: Simon Charette 
 Co-authored-by: Sarah Boyce <42296566+sarahbo...@users.noreply.github.com>
 Co-authored-by: Natalia <124304+ness...@users.noreply.github.com>
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9c98402e-69795f02-532e-4879-9dcd-c94564780f91-00%40eu-central-1.amazonses.com.

Re: [Django] #35447: Request attribute upload handlers is immutable when method is POST

2024-05-21 Thread Django

#35447: Request attribute upload handlers is immutable when method is POST
---+--
 Reporter:  matsony_15 |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Generic views  |  Version:  dev
 Severity:  Normal |   Resolution:  needsinfo
 Keywords:  UploadHandler  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Comment (by matsony_15):

 I created a test repo and provided some additional  info in README.md here
 https://github.com/Smoooky/custom_upload_handler
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9c7af0bf-b0e19b2a-dbc7-4416-b30d-6d7f4b2e7573-00%40eu-central-1.amazonses.com.

Re: [Django] #8307: ImageFile use of width_field and height_field is slow with remote storage backends

2024-05-21 Thread Django

#8307: ImageFile use of width_field and height_field is slow with remote storage
backends
-+-
 Reporter:  sebastian.serrano@…  |Owner:  Jacob
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  imagefile height | Triage Stage:  Accepted
  width  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by john-parton):

 I think it's very important that they provide a minimal test.

 Based on my research, I do not think the scenario they are describing is
 actually a problem anymore, and had been fixed sometime in the last twelve
 years by another change.

 I could be wrong, of course, but without actual code to pore over, my gut
 says it's fixed.

 Replying to [comment:24 Sarah Boyce]:
 > Replying to [comment:18 Alan Justino da Silva]:
 > > That said, I do not see how this solution fixes a template page
 rendering ~10 images from a remote storage as there is no `.save()`
 involved for ''using existing images'':
 > >
 > > When I reopened the issue, my application needed only the URL of the
 files, already stored in the database, thus a O(1) call to DB. That is
 because I needed not to put height and width in the `` HTML tag, as
 the browser deals with whatever it fetches from the URL. If grabbing the
 URL keeps forcing to `.get_image_dimentions()`, then this call becomes
 O(10) calls to the storage, meaning O(10) HTTP HEAD calls to S3. That is
 why I proposed ''the storage'' to decide if this should be done, or
 cached, or faked.
 >
 > Hi Alan, the issue you are describing was fixed in #34517.
 > I will close this issue and reopen #35139 as this is a separate concern.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9c4e5a70-97161f98-f967-4c42-a9be-6a5f682af5e0-00%40eu-central-1.amazonses.com.

Re: [Django] #35405: Use @cached_property for FieldCacheMixin cache key

2024-05-21 Thread Django

#35405: Use @cached_property for FieldCacheMixin cache key
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * stage:  Accepted => Ready for checkin

Comment:

 Will merge once CI is green.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9c1200b3-39531836-1983-465d-9986-4d0c08ecb3c5-00%40eu-central-1.amazonses.com.

Re: [Django] #29942: viewsource links to contrib.auth.forms not appearing

2024-05-21 Thread Django

#29942: viewsource links to contrib.auth.forms not appearing
-+---
 Reporter:  Yemar Nevets |Owner:  David Smith
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---
Changes (by Natalia Bidart):

 * resolution:   => fixed
 * status:  new => closed

Comment:

 Docs build failure fixed in 15fff62d5d8f28b6b61d63341535c9aafc64c865 and
 confirmed docs now build correctly in both RTD and our server.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9bf57eaf-37aa9c21-aa3a-47cd-888b-b526fa304f7a-00%40eu-central-1.amazonses.com.

Re: [Django] #29942: viewsource links to contrib.auth.forms not appearing

2024-05-21 Thread Django

#29942: viewsource links to contrib.auth.forms not appearing
-+---
 Reporter:  Yemar Nevets |Owner:  David Smith
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  dev
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---
Comment (by Natalia Bidart):

 Replying to [comment:23 Zach Borboa]:
 > hi. this ticket is marked fixed, but the dev URL mentioned in the
 description[1] still 404s.
 >
 > [1]
 https://docs.djangoproject.com/en/dev/_modules/django/contrib/auth/forms/

 Hello Zach,

 As Tim mentioned, we did land a fix but it wasn't available because of a
 docs build issue in our building server. We have now fixed that and the
 linking to source code is available via the "[source]" link in the docs,
 for example in
 
https://docs.djangoproject.com/en/dev/topics/auth/default/#django.contrib.auth.forms.PasswordChangeForm
 there is a link to
 https://github.com/django/django/blob/main/django/contrib/auth/forms.py#L488

 The fix for this issue included migrating from one Sphinx extension
 (viewcode) to another (linkcode), so now the docs include links to the
 source code directly in GitHub.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9bf2f94b-de8ac7e8-f7d0-4b8b-8a53-6e930456279c-00%40eu-central-1.amazonses.com.

Re: [Django] #18119: add DomainNameValidator to validate Internet Domain Names

2024-05-21 Thread Django

#18119: add DomainNameValidator to validate Internet Domain Names
-+-
 Reporter:  michele  |Owner:  Nina
 |  Menezes
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  validators   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin

Comment:

 Replying to [comment:20 michele]:
 > I wouldn't necessarily consider adding it if the patch was without, but
 I certainly see value in keeping it now it's already there.
 >
 > PS: I'm the original submitter. Trac wouldn't send me a reset-password
 link.

 Thank you for your input. In which case, I am marking the patch as "Ready
 for checkin".
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9ba8c5e3-6be76d65-b2f2-4f26-858a-311709c1d630-00%40eu-central-1.amazonses.com.

Re: [Django] #29942: viewsource links to contrib.auth.forms not appearing

2024-05-21 Thread Django

#29942: viewsource links to contrib.auth.forms not appearing
-+---
 Reporter:  Yemar Nevets |Owner:  David Smith
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  dev
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---
Comment (by GitHub ):

 In [changeset:"15fff62d5d8f28b6b61d63341535c9aafc64c865" 15fff62d]:
 {{{#!CommitTicketReference repository=""
 revision="15fff62d5d8f28b6b61d63341535c9aafc64c865"
 Refs #29942 -- Fixed docs build on Python < 3.9 avoiding dict union
 operator.

 The docs build process was failing on djangoproject.com since it uses
 Python 3.8 and the dict union operator was added in Python 3.9.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9b1417d4-fd9ea2d2-f7e8-4ff9-9dfb-7c415bd7e961-00%40eu-central-1.amazonses.com.

Re: [Django] #35470: Separate i18n and l10n globalization settings into two sublists.

2024-05-21 Thread Django

#35470: Separate i18n  and  l10n globalization settings into two sublists.
---+-
 Reporter:  Lufafa Joshua  |Owner:  Lufafa Joshua
 Type:  Uncategorized  |   Status:  assigned
Component:  Uncategorized  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Lufafa Joshua):

 * owner:  nobody => Lufafa Joshua
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9b10df92-cbe5e944-639c-4f58-9566-3b0b59982389-00%40eu-central-1.amazonses.com.

[Django] #35470: Separate i18n and l10n globalization settings into two sublists.

2024-05-21 Thread Django

#35470: Separate i18n  and  l10n globalization settings into two sublists.
-+
   Reporter:  Lufafa Joshua  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  5.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 from this discussion
 [https://github.com/django/django/pull/18028#discussion_r1567427192]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9b107a01-a2617a52-6179-42d9-87c5-e480a4429b94-00%40eu-central-1.amazonses.com.

Re: [Django] #23337: CircularDependencyError when squashing migrations

2024-05-21 Thread Django

#23337: CircularDependencyError when squashing migrations
---+
 Reporter:  Richard Eames  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Migrations |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Gordon Wrigley):

 * cc: Gordon Wrigley (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9b00df41-6cd91b7e-96c3-4041-b6f6-e13d23df863e-00%40eu-central-1.amazonses.com.

Re: [Django] #18119: add DomainNameValidator to validate Internet Domain Names

2024-05-21 Thread Django

#18119: add DomainNameValidator to validate Internet Domain Names
--+
Reporter: michele |Owner: Nina Menezes
Type: New feature | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal| Resolution:
Keywords: validators| Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 |UI/UX: 0
--+
Comment (by mij):

The reason for adding accept_idna had nothing to do with how "modern" the
format was. It's a way to allow the developer to enforce ascii names.

Although python beautifully supports UTF, the developer is often required
to handle non-ascii characters specially. For example, when checking their
length, or storing them somewhere, or serializing them to somewhere else.
The exceeding rarity of IDNA causes many to assume the domain is ASCII,
only to run into exception later in production.

If not else, the presence of the accept_idna option forces the developer
to think whether that's a relevant case for them, and what to do about it.

I wouldn't necessarily consider adding it if the patch was without, but I
certainly see value in keeping it now it's already there.

PS: I'm the original submitter. Trac wouldn't send me a reset-password
link.
--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018f9ad901c4-ef000205-2de6-40a8-900c-a88357e19c6f-00%40eu-central-1.amazonses.com.

Re: [Django] #18119: add DomainNameValidator to validate Internet Domain Names

2024-05-21 Thread Django

#18119: add DomainNameValidator to validate Internet Domain Names
--+
 Reporter:  michele   |Owner:  Nina Menezes
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  validators| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1

Comment:

 (open question as to whether we should drop `accept_idna`)
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9ac91921-1325c9bd-5581-4321-af78-7db077f15f33-00%40eu-central-1.amazonses.com.

Re: [Django] #18119: add DomainNameValidator to validate Internet Domain Names

2024-05-21 Thread Django

#18119: add DomainNameValidator to validate Internet Domain Names
--+
 Reporter:  michele   |Owner:  Nina Menezes
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  validators| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Comment (by Sarah Boyce):

 Replying to [comment:16 Claude Paroz]:
 > Somewhat naive question: are there still use cases to exclude IDNA
 domain names from such a validator, 12 years after the initial report?

 Good question, perhaps it makes sense to remove the `accept_idna` argument
 and not support excluding IDNA domain names for now. Then if someone has a
 use case this can be raised in a new ticket?
 Nina - what do you think?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9ac7b1a8-f63ac43c-e493-485a-aa80-848fd871588d-00%40eu-central-1.amazonses.com.

Re: [Django] #23337: CircularDependencyError when squashing migrations

2024-05-21 Thread Django

#23337: CircularDependencyError when squashing migrations
---+
 Reporter:  Richard Eames  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Migrations |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Comment (by Sarah Boyce):

 #35463 is a duplicate
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9aba5a82-3b90f91e-c2d3-45c7-a0c7-d3395c5b9175-00%40eu-central-1.amazonses.com.

Re: [Django] #35463: Squash migrations inheriting dependencies from unsquashed migrations.

2024-05-21 Thread Django

#35463: Squash migrations inheriting dependencies from unsquashed migrations.
+--
 Reporter:  Gordon Wrigley  |Owner:  nobody
 Type:  Uncategorized   |   Status:  closed
Component:  Migrations  |  Version:  4.2
 Severity:  Normal  |   Resolution:  duplicate
 Keywords:  squash  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Sarah Boyce):

 * resolution:   => duplicate
 * status:  new => closed

Comment:

 Duplicate of #23337
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9aba2c43-acf1081d-25c7-4ed6-8ab2-f9f935bd36d5-00%40eu-central-1.amazonses.com.

Re: [Django] #35465: Feature: allow pre-caching and disable-cache

2024-05-21 Thread Django

#35465: Feature: allow pre-caching and disable-cache
-+-
 Reporter:  mdk  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (Cache system)  |  Version:  5.0
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  cache| Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * resolution:   => wontfix
 * status:  new => closed

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9a8907f8-2192efa7-3841-4e54-8f57-5c0346375015-00%40eu-central-1.amazonses.com.

Re: [Django] #35465: Feature: allow pre-caching and disable-cache

2024-05-21 Thread Django

Hello!
As this is a new feature request, the recommended path forward is to first
propose the idea on the [https://forum.djangoproject.com/c/internals/5
Django Forum] and see what the community thinks about the suggestion.
You'll reach a much wider audience and likely get extra feedback.
I'll close the ticket for now, but if there is a community agreement for
this, you are welcome to come back to the ticket and point to the forum
topic, so we can then re-open it.
For more details, please see
[https://docs.djangoproject.com/en/stable/internals/contributing/bugs-and-
features/#requesting-features the documented guidelines for requesting
features].
--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018f9a88c6af-a7f02aa3-8b14-4f33-8248-d42a58ce9bef-00%40eu-central-1.amazonses.com.

Re: [Django] #29942: viewsource links to contrib.auth.forms not appearing

2024-05-21 Thread Django

#29942: viewsource links to contrib.auth.forms not appearing
-+---
 Reporter:  Yemar Nevets |Owner:  David Smith
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  dev
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---
Changes (by Tim Graham):

 * resolution:  fixed =>
 * severity:  Normal => Release blocker
 * stage:  Ready for checkin => Accepted
 * status:  closed => new

Comment:

 Probably the documentation hasn't been updated since this change due to a
 [https://github.com/django/django/pull/18167 Python 3.8 incompatibility].
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9a88592f-cdde7ec7-3f67-4e2d-aea5-e684a65cccf2-00%40eu-central-1.amazonses.com.

Re: [Django] #35467: Prefer urlsplit() over urlparse()

2024-05-21 Thread Django

#35467: Prefer urlsplit() over urlparse()
--+
 Reporter:  Adam Johnson  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Sarah Boyce):

 * stage:  Unreviewed => Accepted

Comment:

 Accepting for someone to make updates and confirm with benchmarks. 👍
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9a819d3d-e7b5b690-3ceb-4faa-899f-6d0a6d5c8a73-00%40eu-central-1.amazonses.com.

Re: [Django] #35326: OverwritingStorageTests fail if a TemporaryUploadedFile is used

2024-05-21 Thread Django

#35326: OverwritingStorageTests fail if a TemporaryUploadedFile is used
-+-
 Reporter:  bcail|Owner:  bcail
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

 In [changeset:"480ccf905560e2bc63be8cfd24355c557d404677" 480ccf90]:
 {{{#!CommitTicketReference repository=""
 revision="480ccf905560e2bc63be8cfd24355c557d404677"
 Refs #35326 -- Made cosmetic edits to 5.1 release notes.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9a76e3b8-2f5a457f-335d-449f-af6c-7b911a2c7b7a-00%40eu-central-1.amazonses.com.

Re: [Django] #35139: Performing a save() with an ImageField where width_field or height_field is set results in an extra read operation

2024-05-21 Thread Django

#35139: Performing a save() with an ImageField where width_field or 
height_field is
set results in an extra read operation
-+-
 Reporter:  john-parton  |Owner:  john-
 |  parton
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  5.0
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9a5fcb7b-4c58fb04-ef0e-4be2-85cd-eb7b3f3d2dd4-00%40eu-central-1.amazonses.com.

Re: [Django] #35139: Performing a save() with an ImageField where width_field or height_field is set results in an extra read operation

2024-05-21 Thread Django

#35139: Performing a save() with an ImageField where width_field or 
height_field is
set results in an extra read operation
-+-
 Reporter:  john-parton  |Owner:  john-
 |  parton
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  5.0
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * has_patch:  0 => 1
 * owner:  nobody => john-parton
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9a5b3b18-39172f6e-3399-40e6-b46b-d3bad4aba9ff-00%40eu-central-1.amazonses.com.

Re: [Django] #35139: Performing a save() with an ImageField where width_field or height_field is set results in an extra read operation

2024-05-21 Thread Django

#35139: Performing a save() with an ImageField where width_field or 
height_field is
set results in an extra read operation
--+
 Reporter:  john-parton   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Sarah Boyce):

 * resolution:  duplicate =>
 * stage:  Unreviewed => Accepted
 * status:  closed => new

Comment:

 After looking into the other ticket, I can see that one was a duplicate of
 #35139 which has been fixed. This described a separate concern.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9a5b13a9-f2322475-a68c-449c-ae0f-50338da0ef19-00%40eu-central-1.amazonses.com.

Re: [Django] #8307: ImageFile use of width_field and height_field is slow with remote storage backends

2024-05-21 Thread Django

#8307: ImageFile use of width_field and height_field is slow with remote storage
backends
-+-
 Reporter:  sebastian.serrano@…  |Owner:  Jacob
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  imagefile height | Triage Stage:  Accepted
  width  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * has_patch:  1 => 0
 * needs_better_patch:  1 => 0
 * resolution:   => fixed
 * status:  new => closed

Comment:

 Replying to [comment:18 Alan Justino da Silva]:
 > That said, I do not see how this solution fixes a template page
 rendering ~10 images from a remote storage as there is no `.save()`
 involved for ''using existing images'':
 >
 > When I reopened the issue, my application needed only the URL of the
 files, already stored in the database, thus a O(1) call to DB. That is
 because I needed not to put height and width in the `` HTML tag, as
 the browser deals with whatever it fetches from the URL. If grabbing the
 URL keeps forcing to `.get_image_dimentions()`, then this call becomes
 O(10) calls to the storage, meaning O(10) HTTP HEAD calls to S3. That is
 why I proposed ''the storage'' to decide if this should be done, or
 cached, or faked.

 Hi Alan, the issue you are describing was fixed in #34517.
 I will close this issue and reopen #35139 as this is a separate concern.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f9a58f147-afab4583-defc-49ac-bdbe-84a4c1641e0e-00%40eu-central-1.amazonses.com.

43 matches

Mail list logo