Re: [Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
+---
  Reporter:  Alex   | Owner:  Alex
Status:  closed | Milestone:  1.1 
 Component:  Forms  |   Version:  1.0 
Resolution:  fixed  |  Keywords:  
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by Alex):

  * status:  reopened => closed
  * resolution:  => fixed

Comment:

 This ticket was fixed, if you believe there is a new issue please file a
 new ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
+---
  Reporter:  Alex   | Owner:  Alex
Status:  reopened   | Milestone:  1.1 
 Component:  Forms  |   Version:  1.0 
Resolution: |  Keywords:  
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by anonymous):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 [http://code.djangoproject.com/changeset/10582 r10482] uses filter which
 doesn't return same order as pks given, where as previous implementation
 appended values to the end. e.g.: clean([3,2]) -> {object 3, object 2}
 where as new implementation returns {object 2, object 3}
 Its a changed in the behavior, which I was using ...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
+---
  Reporter:  Alex   | Owner:  Alex
Status:  assigned   | Milestone:  1.1 
 Component:  Forms  |   Version:  1.0 
Resolution: |  Keywords:  
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by Alex):

  * needs_better_patch:  1 => 0
  * stage:  Accepted => Ready for checkin

Comment:

 Jacob's complaint was not accurate as the tests found here:

 
http://code.djangoproject.com/browser/django/trunk/tests/modeltests/model_forms/models.py#L827

 Still pass, and they obviously rely on that ValueError logic being
 correct(the reason this works is get_db_prep_lookup is called on the
 object being added to the QuerySet, not on the Query being executed).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
---+
  Reporter:  Alex  | Owner:  Alex
Status:  assigned  | Milestone:  1.1 
 Component:  Forms |   Version:  1.0 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
---+
  Reporter:  Alex  | Owner:  Alex
Status:  assigned  | Milestone:  1.1 
 Component:  Forms |   Version:  1.0 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * stage:  Ready for checkin => Accepted

Comment:

 This isn't quite correct yet. In the patched version,
 `self.queryset.filter(pk=pk)` will never raise the `ValueError` the
 try/except block is catching against, so the logic is incorrect somewhere.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
+---
  Reporter:  Alex   | Owner:  Alex
Status:  assigned   | Milestone:  1.1 
 Component:  Forms  |   Version:  1.0 
Resolution: |  Keywords:  
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by Alex):

  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
---+
  Reporter:  Alex  | Owner:  Alex
Status:  assigned  | Milestone:  1.1 
 Component:  Forms |   Version:  1.0 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * milestone:  => 1.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
---+
  Reporter:  Alex  | Owner:  Alex
Status:  assigned  | Milestone:  
 Component:  Forms |   Version:  1.0 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * status:  new => assigned
  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
-+--
  Reporter:  Alex| Owner:  Alex
Status:  new | Milestone:  
 Component:  Forms   |   Version:  1.0 
Resolution:  |  Keywords:  
 Stage:  Unreviewed  | Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Changes (by Joes):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Had to develop similar solution (and custom widget) to get rid of
 mentioned issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice

[Django]

#10156: ModelMultipleChoiceField does O(n) queries where O(1) will suffice
---+
 Reporter:  Alex   |   Owner:  Alex  
   Status:  new|   Milestone:
Component:  Forms  | Version:  1.0   
 Keywords: |   Stage:  Unreviewed
Has_patch:  1  |  
---+
 Which is hugely inefficient, selecting 20 items already means you're going
 outside the reasonable limits for SQL queries.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---