Re: [Django] #10166: Cookie test fails in login() view

[Django]

#10166: Cookie test fails in login() view
-+--
  Reporter:  iakbar  | Owner:  nobody   

Status:  closed  | Milestone:  1.1  

 Component:  Authentication  |   Version:  1.0  

Resolution:  wontfix |  Keywords:  authentication, cookie, 
login
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  1

Needs_better_patch:  0   |  
-+--
Comment (by nikecitycn):

 [http://www.sneakersupplier.com Nike air force ones]
 [http://www.sneakersupplier.com Air Jordan shoes]
 [http://www.sneakersupplier.com Nike Dunks]
 [http://www.sneakersupplier.com Nike Shox]
 [http://www.sneakersupplier.com Nike Shoes]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10166: Cookie test fails in login() view

[Django]

#10166: Cookie test fails in login() view
-+--
  Reporter:  iakbar  | Owner:  nobody   

Status:  closed  | Milestone:  1.1  

 Component:  Authentication  |   Version:  1.0  

Resolution:  wontfix |  Keywords:  authentication, cookie, 
login
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  1

Needs_better_patch:  0   |  
-+--
Comment (by nikecitycn):

 [http://www.sneakersupplier.com Nike air force ones]
 [http://www.sneakersupplier.com Air Jordan shoes]
 [http://www.sneakersupplier.com Nike Dunks]
 [http://www.sneakersupplier.com Nike Shox]
 [http://www.sneakersupplier.com Nike Shoes]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10166: Cookie test fails in login() view

[Django]

#10166: Cookie test fails in login() view
-+--
  Reporter:  iakbar  | Owner:  nobody   

Status:  closed  | Milestone:  1.1  

 Component:  Authentication  |   Version:  1.0  

Resolution:  wontfix |  Keywords:  authentication, cookie, 
login
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  1

Needs_better_patch:  0   |  
-+--
Changes (by jacob):

  * status:  new => closed
  * resolution:  => wontfix

Comment:

 Yeah, the cookie test is deliberately disabled by default in the login
 view, and we'll keep it that way.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10166: Cookie test fails in login() view

[Django]

#10166: Cookie test fails in login() view
-+--
  Reporter:  iakbar  | Owner:  nobody   

Status:  new | Milestone:  1.1  

 Component:  Authentication  |   Version:  1.0  

Resolution:  |  Keywords:  authentication, cookie, 
login
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  1

Needs_better_patch:  0   |  
-+--
Comment (by primski):

 > logic is, the test cookie is being checked for if and only if the
 request has been passed in __init__.

 true, but it fails out for the generic view users.

 Perhaps an optional variable could be passed to django.contrib.auth.login
 view, f.i. 'cookie_test = False', which would either pass the request
 object to the form or not.

 a simple one liner would do the trick then:

 {{{
  form = AuthenticationForm(data=request.POST, request = request) if
 cookie_test else AuthenticationForm(data=request.POST)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10166: Cookie test fails in login() view

[Django]

#10166: Cookie test fails in login() view
-+--
  Reporter:  iakbar  | Owner:  nobody   

Status:  new | Milestone:  1.1  

 Component:  Authentication  |   Version:  1.0  

Resolution:  |  Keywords:  authentication, cookie, 
login
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  1

Needs_better_patch:  0   |  
-+--
Comment (by whiskybar):

 form = AuthenticationForm?(data=request.POST, request=request)

 will enable the cookie test again. The question is, is it intended? Won't
 some existing applications break? The cookie test has been virtually
 disabled since [7962] which removed the argument request when
 AuthenticationForm was created. AuthenticationForm logic is, the test
 cookie is being checked for if and only if the {{{request}}} has been
 passed in {{{__init__}}}.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10166: Cookie test fails in login() view

[Django]

#10166: Cookie test fails in login() view
-+--
  Reporter:  iakbar  | Owner:  nobody   

Status:  new | Milestone:  1.1  

 Component:  Authentication  |   Version:  1.0  

Resolution:  |  Keywords:  authentication, cookie, 
login
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  1

Needs_better_patch:  0   |  
-+--
Changes (by jacob):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10166: Cookie test fails in login() view

[Django]

#10166: Cookie test fails in login() view
-+--
  Reporter:  iakbar  | Owner:  nobody   

Status:  new | Milestone:   

 Component:  Authentication  |   Version:  1.0  

Resolution:  |  Keywords:  authentication, cookie, 
login
 Stage:  Unreviewed  | Has_patch:  1

Needs_docs:  0   |   Needs_tests:  1

Needs_better_patch:  0   |  
-+--
Changes (by nanotube):

  * has_patch:  0 => 1
  * needs_tests:  0 => 1

Comment:

 The fix is simple. Line 21 of the default django.contrib.auth.views file
 (of the 1.0.2 release) should be :

 form = AuthenticationForm(data=request.POST, request=request)

 instead of

 form = AuthenticationForm(data=request.POST)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10166: Cookie test fails in login() view

[Django]

#10166: Cookie test fails in login() view
-+--
  Reporter:  iakbar  | Owner:  nobody   

Status:  new | Milestone:   

 Component:  Authentication  |   Version:  1.0  

Resolution:  |  Keywords:  authentication, cookie, 
login
 Stage:  Unreviewed  | Has_patch:  0

Needs_docs:  0   |   Needs_tests:  0

Needs_better_patch:  0   |  
-+--
Changes (by iakbar):

  * needs_better_patch:  => 0
  * component:  Uncategorized => Authentication
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #10166: Cookie test fails in login() view

[Django]

#10166: Cookie test fails in login() view
---+
 Reporter:  iakbar |   Owner:  nobody
   Status:  new|   Milestone:
Component:  Uncategorized  | Version:  1.0   
 Keywords:  authentication, cookie, login  |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 The cookie test in the django.contrib.auth.views.login() view doesn't work
 as expected.

 The url is set up as follows.

 {{{

 (r'^login/$', 'django.contrib.auth.views.login')
 }}}


 After disabling cookies in the browser...

 1. the login view is called via a GET request and displays the login
 template/form (the test cookie is set).

 2. The form is posted back to the login view (the view is supposed to
 check
 for the test cookie and throw an error if the cookie is not found. This
 check doesn't happen).


 The documentation of the init method of AuthenticationForm says it
 will validate that cookies are enabled only if a request is passed in
 when instantiating the form. But on POST the login view doesn't pass
 the request to AuthenticationForm.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---