Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:  Tim
 Type:  New feature  |  Graham 
Component:  HTTP handling|   Status:  closed
 Severity:  Normal   |  Version:  master
 Keywords:  HttpResponse,|   Resolution:  fixed
  charset, runtime   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * owner:   => Tim Graham 
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5f2542f12a90cfcfb7be776424ef2f7b200df006"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5f2542f12a90cfcfb7be776424ef2f7b200df006"
 Fixed #10190 -- Made HttpResponse charset customizable.

 Thanks to Simon Charette, Aymeric Augustin, and Tim Graham
 for reviews and contributions.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.03e8c064e26eef3d54aa751f687fe641%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:
 Type:  New feature  |   Status:  new
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HttpResponse,| Triage Stage:  Accepted
  charset, runtime   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by unaizalakain):

 * needs_better_patch:  1 => 0


Comment:

 Comments addressed and PR updated ;-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6325468821586a4782d765c233950be8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:
 Type:  New feature  |   Status:  new
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HttpResponse,| Triage Stage:  Accepted
  charset, runtime   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 I left comments for improvement on the PR. Please uncheck "Patch needs
 improvement" when you update it, thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a2caca65a1511677eac7ddc21d6af011%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:
 Type:  New feature  |   Status:  new
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HttpResponse,| Triage Stage:  Accepted
  charset, runtime   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * owner:  aaugustin =>
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9888b5f1dca0ac5cd9878b5a4ddc04b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:  aaugustin
 Type:  New feature  |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HttpResponse,| Triage Stage:  Accepted
  charset, runtime   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by unaizalakain):

 * cc: unai@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7105a28ea449bbf79bc021f4ce634531%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:  aaugustin
 Type:  New feature  |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HttpResponse,| Triage Stage:  Accepted
  charset, runtime   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by unaizalakain):

 Any updates so far?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.87336b24f22aeb1724a2b8d4e7ee2fa0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:  aaugustin
 Type:  New feature  |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HttpResponse,| Triage Stage:  Accepted
  charset, runtime   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * owner:  unaizalakain => aaugustin


Comment:

 Tentatively assigning the ticket to myself to review the latest iteration
 of the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fa8d46554fe0c85213a2ad70f5fb0485%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:
 Type:  New feature  |  unaizalakain
Component:  HTTP handling|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  HttpResponse,|   Resolution:
  charset, runtime   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by unaizalakain):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


Comment:

 For the sake of future readers, this is what we have spoken on IRC
 (`#django-dev`):

 There are two possible workarounds to this:

 - Creating a dictionary between IANA registered charsets and Python
 charsets. This would be great but it means having to regularly update and
 maintain it.

 - Adding a `charset` initialization parameter and property to
 `HttpResponse`. If you have issues with the charset specification, just
 pass on the charset argument or set the charset property. If not set,
 it'll fall back to the extraction from the `Content-Type` response header
 and if that isn't possible, to the `DEFAULT_CHARSET` setting.

 Finally, we decided for the second solution.

 We also spoke about parsing the `Accept-Charset` request header so that
 the chain would be:
 `[charset parameter/property] ---> [content-type extraction] ---> [accept-
 charset extraction] ---> [default setting]`

 The problem with it was that the `HttpResponse` object could not possibly
 know what the request headers were. It's sad to have this limitation but
 there isn't any easy workaround.

 So, apart of making the changes suggested in the review, I only added the
 charset parameter and property.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.13828341158a84c9df72e0b2740f7c2b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:
 Type:  New feature  |  unaizalakain
Component:  HTTP handling|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  HttpResponse,|   Resolution:
  charset, runtime   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Comment:

 This latest patch doesn't address the fact that Python charsets do not
 match IANA-registered character sets. What's your take on this issue?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6256214199d4413881ee954fbd83a6da%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:
 Type:  New feature  |  unaizalakain
Component:  HTTP handling|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  HttpResponse,|   Resolution:
  charset, runtime   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by unaizalakain):

 * stage:  Fixed on a branch => Accepted


Comment:

 PR sent: https://github.com/django/django/pull/1928

 ``HttpResponse``s charset is now depending on its ``Content-Type`` header
 key.
 If no charset is found there, it falls back to the ``DEFAULT_CHARSET``
 setting.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.58db73fc10618c89001beaa93147e815%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:
 Type:  New feature  |  unaizalakain
Component:  HTTP handling|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  HttpResponse,|   Resolution:
  charset, runtime   | Triage Stage:  Fixed on
Has patch:  1|  a branch
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by unaizalakain):

 * owner:   => unaizalakain
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8619632c03cfa0b00745e361af4dd4e1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:
 Type:  New feature  |   Status:  new
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HttpResponse,| Triage Stage:  Fixed on
  charset, runtime   |  a branch
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  assigned => new
 * owner:  aaugustin =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4818fe572ddd1b17e2b5c7204e5dc595%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:  aaugustin
 Type:  New feature  |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HttpResponse,| Triage Stage:  Fixed on
  charset, runtime   |  a branch
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.367c841e789f682ec44cc0d1f8a6bc69%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
 Reporter:  Wonlay   |Owner:  aaugustin
 Type:  New feature  |   Status:  new
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HttpResponse,| Triage Stage:  Fixed on
  charset, runtime   |  a branch
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * owner:  ccahoon => aaugustin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+-
   Reporter:  Wonlay |Owner:  ccahoon
   Type:  New|   Status:  new
  feature|Component:  HTTP handling
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  HttpResponse,
 Resolution: |  charset, runtime
   Triage Stage:  Fixed on   |Has patch:  1
  a branch   |  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by SmileyChris):

 * type:   => New feature
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
-+--
   Reporter:  Wonlay | Owner:  ccahoon  
 
 Status:  new| Milestone:   
 
  Component:  HTTP handling  |   Version:  SVN  
 
 Resolution: |  Keywords:  HttpResponse, 
charset, runtime
   Triage Stage:  Fixed on a branch  | Has patch:  1
 
Needs documentation:  0  |   Needs tests:  0
 
Patch needs improvement:  0  |  
-+--

Comment (by ramiro):

 #13391 was closed as duplicate of this and included a patch with an
 implementation for this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
  Reporter:  Wonlay | Owner:  ccahoon   

Status:  new| Milestone:

 Component:  HTTP handling  |   Version:  SVN   

Resolution: |  Keywords:  HttpResponse, 
charset, runtime
 Stage:  Fixed on a branch  | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  0  |  
+---
Changes (by ubernostrum):

  * milestone:  1.2 =>

Comment:

 1.2 is feature-frozen, moving this feature request off the milestone.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
  Reporter:  Wonlay | Owner:  ccahoon   

Status:  new| Milestone:  1.2   

 Component:  HTTP handling  |   Version:  SVN   

Resolution: |  Keywords:  HttpResponse, 
charset, runtime
 Stage:  Fixed on a branch  | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  0  |  
+---
Comment (by ccahoon):

 Fixed on branches/soc2009/http-wsgi-improvements.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
  Reporter:  Wonlay | Owner:  ccahoon   

Status:  new| Milestone:  1.2   

 Component:  HTTP handling  |   Version:  SVN   

Resolution: |  Keywords:  HttpResponse, 
charset, runtime
 Stage:  Fixed on a branch  | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  0  |  
+---
Changes (by ccahoon):

  * needs_better_patch:  1 => 0
  * stage:  Accepted => Fixed on a branch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
  Reporter:  Wonlay | Owner:  ccahoon   

Status:  new| Milestone:  1.2   

 Component:  HTTP handling  |   Version:  SVN   

Resolution: |  Keywords:  HttpResponse, charset, 
runtime
 Stage:  Accepted   | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Comment (by ccahoon):

 Support for Accepted-Charset in an HttpRequest, charset=.. in the
 content_type, and manually setting the encoding all have implementations
 on http://code.djangoproject.com/browser/django/branches/soc2009/http-
 wsgi-improvements

 As far as I understand, this code will not appear on the trunk until the
 end of Google Summer of Code, to be merged with the rest of the work on
 that branch. However, if someone wants a patch for trunk, ask, and I will
 cook one up.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
  Reporter:  Wonlay | Owner:  ccahoon   

Status:  new| Milestone:  1.2   

 Component:  HTTP handling  |   Version:  SVN   

Resolution: |  Keywords:  HttpResponse, charset, 
runtime
 Stage:  Accepted   | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Comment (by ccahoon):

 http://www.iana.org/assignments/character-sets appears to be the canonical
 list of valid character sets.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
  Reporter:  Wonlay | Owner:  ccahoon   

Status:  new| Milestone:  1.2   

 Component:  HTTP handling  |   Version:  SVN   

Resolution: |  Keywords:  HttpResponse, charset, 
runtime
 Stage:  Accepted   | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Changes (by ccahoon):

  * owner:  nobody => ccahoon

Comment:

 >  2. Find out whether Python codec names are all valid as HTTP charset
 names. If so, parse the `content_type` to see if a special charset
 encoding is needed (no need for an extra `__init__` parameter).

 This is not the case. http://docs.python.org/library/codecs.html#standard-
 encodings ("A number of codecs are specific to Python, so their codec
 names have no meaning outside Python.") and
 http://www.cs.tut.fi/~jkorpela/chars/sorted.html which lacks a bunch of
 codecs listed in the first link.

 >  3. If the previous item is not applicable, don't use `_charset` in the
 `content_type` setting, since it could lead to invalid value (and we'll
 need a documentation update to clarify the requirements there).

 Such as a list of valid codecs?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
  Reporter:  Wonlay | Owner:  nobody

Status:  new| Milestone:  1.2   

 Component:  HTTP handling  |   Version:  SVN   

Resolution: |  Keywords:  HttpResponse, charset, 
runtime
 Stage:  Accepted   | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Changes (by jacob):

  * milestone:  1.1 => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
  Reporter:  Wonlay | Owner:  nobody

Status:  new| Milestone:  1.1   

 Component:  HTTP handling  |   Version:  SVN   

Resolution: |  Keywords:  HttpResponse, charset, 
runtime
 Stage:  Accepted   | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Changes (by jacob):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
  Reporter:  Wonlay | Owner:  nobody

Status:  new| Milestone:

 Component:  HTTP handling  |   Version:  SVN   

Resolution: |  Keywords:  HttpResponse, charset, 
runtime
 Stage:  Unreviewed | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Changes (by mtredinnick):

  * needs_better_patch:  => 1
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 This patch should probably be just a one-liner: just setting
 `self._charset`. Don't mess around with the `mimetype` stuff, since that's
 not related. However, there's something more that should be worked out
 here to avoid all problems.

 If the value of `self._charset` is always going to be valid in the HTTP
 content-type header, we should just extract it from the `content_type`
 parameter. That would only be valid if all Python codec values are also
 valid HTTP header values.

 If that isn't possible, then `self._charset` shouldn't be used to
 construct the content-type header, as it will use an invalid value. The
 current "default" is only for really old code (and/or people using
 defaults likes utf-8). For anything non-standard, `content_type` should be
 being used with a proper character set definition.

 So, improvements needed here are:

  1. Remove the changes to `mimetype` setting. Make the smallest change
 possible and that isn't needed.
  2. Find out whether Python codec names are all valid as HTTP charset
 names. If so, parse the `content_type` to see if a special charset
 encoding is needed (no need for an extra `__init__` parameter).
  3. If the previous item is not applicable, don't use `_charset` in the
 `content_type` setting, since it could lead to invalid value (and we'll
 need a documentation update to clarify the requirements there).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #10190: Charset should be customizable with HttpResponse

[Django]

#10190: Charset should be customizable with HttpResponse
+---
 Reporter:  Wonlay  |   Owner:  nobody
   Status:  new |   Milestone:
Component:  HTTP handling   | Version:  SVN   
 Keywords:  HttpResponse, charset, runtime  |   Stage:  Unreviewed
Has_patch:  1   |  
+---
 When our web site is talking to other application or client, the charset
 of web response may vary from each other.

 Currently only a {{{ settings.DEFAULT_CHARSET }}} can be set with a unique
 value, we cannot change the HttpResponse charset at runtime properly.

 I think we should add a charset parameter to HttpResponse.__init__.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---