Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
-+-
   Reporter: |Owner:  mtredinnick
  mtredinnick|   Status:  closed
   Type:  Bug|Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN| Severity:  Normal
 Resolution:  wontfix| Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by adamnelson):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 PostgreSQL 8.1 is
 [http://wiki.postgresql.org/wiki/PostgreSQL_Release_Support_Policy no
 longer supported] by the Postgres community. I think this ticket should
 simply be closed at this point.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
-+-
   Reporter: |Owner:  mtredinnick
  mtredinnick|   Status:  new
   Type:  Bug|Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by SmileyChris):

 * type:   => Bug
 * severity:   => Normal
 * milestone:  1.3 =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
+---
   Reporter:  mtredinnick   | Owner:  
mtredinnick
 Status:  new   | Milestone:  1.3   
 
  Component:  Database layer (models, ORM)  |   Version:  SVN   
 
 Resolution:|  Keywords:
 
   Triage Stage:  Accepted  | Has patch:  1 
 
Needs documentation:  0 |   Needs tests:  0 
 
Patch needs improvement:  0 |  
+---

Comment (by adamnelson):

 Looks like this won't make it into milestone:1.3 either?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone:  1.3
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by ubernostrum):

  * milestone:  1.2 => 1.3

Comment:

 Patch hasn't been updated since before 1.1, so I'd be wary of checking it
 in now for 1.2. Also, the comments above indicate this is more a feature
 addition, and unfortunately 1.2's feature-frozen.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone:  1.2
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by Richard Davies ):

 I have just checked that this patch still applies and works with the
 current SVN head.

 I mentioned it in the 1.2 features discussion, and it was categorized
 under "Small, or Just Bugs" as a small non-controversial feature addition.

 As such, I'd like to see it checked in before Django 1.2 beta, please.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone:  1.2
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by Richard Davies ):

  * milestone:  => 1.2

Comment:

 Adding to the 1.2 milestone - hopefully we can get this completed patch
 committed this time.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone: 
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * milestone:  1.1 =>

Comment:

 Like Malcolm said, this can wait until v1.2. We won't ever release v1.1 if
 we keep adding tickets that aren't essential.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by Richard Davies ):

 The last patch leaves the 'if version >= 8.2' rather awkwardly inside an
 'if uses_autocommit'.

 I don't think that outer 'if' statement is necessary, even in light of
 #10467 comment 4 and #10509, so here's a version which removes it, and
 hence allows the 'returning' syntax to be used whenever version >= 8.2,
 regardless of uses_autocommit.

 I think that [10065] was confused between two things:

 - setting 'can_return_id_from_insert=True' inside _cursor() rather than by
 default, which is necessary and the point of #10509

 - only doing this if uses_autocommit, which was overcautious and
 unnecessary

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by Richard Davies ):

  * has_patch:  0 => 1
  * milestone:  => 1.1

Comment:

 It turns out that the current code already works on PostgreSQL <= 8.1. I'm
 attaching a patch which simply removes the check (and some documentation
 of the limitation). This means that we'll be able to get database-native
 autocommit into 1.1. for all versions of PostgreSQL - good!

 The secret is that django/db/backends/postgresql/operations.py already
 defines last_insert_id() in terms of 'select currval' which is defined to
 be a session-local value (see http://www.postgresql.org/docs/7.3/static
 /functions-sequence.html or any other version).

 When django/db/models/sql/subqueries.py defines InsertQuery.execute_sql(),
 the version which uses return last_insert_id() is already session-safe,
 even in database-native autocommit mode without a wrapping transaction.
 The version which uses the 'returning' syntax on Postgresql >= 8.2 is
 simply more efficient, not more session-safe.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone: 
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by Richard Davies ):

 * cc: richard.dav...@elastichosts.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone: 
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by mtredinnick):

  * milestone:  1.1 =>

Comment:

 Can wait until later. Right now, an error is correctly reported. I want to
 fix it properly so that everybody doesn't have to pay all the version
 checking penalties we currently do for this sort of thing (some kind of
 `DATABASE_OPTIONS` specification of version number, probably). Anyway,
 something to add for 1.2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by mtredinnick):

  * milestone:  1.1 beta => 1.1

Comment:

 This doesn't have to be a "beta" fix. It's a bug-fix on the original
 feature. If we get time to do it before 1.1, that's cool. If not, it's a
 documentation note to say it doesn't work on those versions yet. Somebody
 trying to squeeze maximum performance from PostgreSQL at this level should
 consider using the latest version anyway.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
---+
  Reporter:  mtredinnick   | Owner:  mtredinnick
Status:  new   | Milestone:  1.1 beta   
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by mtredinnick):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1

[Django]

#10476: Fix(?) model insert handling when autcommit=True for PostgreSQL <= 8.1
--+-
 Reporter:  mtredinnick   |   Owner:  mtredinnick
   Status:  new   |   Milestone:  1.1 beta   
Component:  Database layer (models, ORM)  | Version:  SVN
 Keywords:|   Stage:  Unreviewed 
Has_patch:  0 |  
--+-
 Need to wrap some isolation level changes around inserts when using older
 PostgreSQL versions so that we can reliably return the last insert ID.
 This is necessary because we use that value to set the primary key
 attribute on the model instance and there's potentially no other way to
 get the information for some models (with no other unique constraints).

 When this is fixed, `settings.DATABASE_OPTIONS[autocommit] = True` can be
 an option again for those server versions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---