Re: [Django] #10630: [PATCH] GZipMiddleware does not handle all MSIE issues.

[Django]

#10630: [PATCH] GZipMiddleware does not handle all MSIE issues.
--+-
  Reporter:  sebastian_noack  | Owner:  nobody
Status:  closed   | Milestone:  1.1   
 Component:  HTTP handling|   Version:  1.0   
Resolution:  fixed|  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by sebastian_noack):

 I agree, but wildcards aren't handled by the GZip middleware at the moment
 anyway. The gzip middleware just looks for the string "gzip" in
 HTTP_ACCEPT_ENCODING.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10630: [PATCH] GZipMiddleware does not handle all MSIE issues.

[Django]

#10630: [PATCH] GZipMiddleware does not handle all MSIE issues.
--+-
  Reporter:  sebastian_noack  | Owner:  nobody
Status:  closed   | Milestone:  1.1   
 Component:  HTTP handling|   Version:  1.0   
Resolution:  fixed|  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by mtredinnick):

 That won't work easily. Wildcards (`"*"`) are permitted in the Accept-
 Encoding header. So we'd end up having to add a ";q=0" piece to the header
 (and then remembering to process preference values later on). Also,
 Accept-Encoding is an optional HTTP header, so we might have to create on
 anew.

 Trying to override some server-provided information for side-effects down
 the processing track is going to be more effort than a more direct
 internal data structure or other indicator in this case.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10630: [PATCH] GZipMiddleware does not handle all MSIE issues.

[Django]

#10630: [PATCH] GZipMiddleware does not handle all MSIE issues.
--+-
  Reporter:  sebastian_noack  | Owner:  nobody
Status:  closed   | Milestone:  1.1   
 Component:  HTTP handling|   Version:  1.0   
Resolution:  fixed|  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by sebastian_noack):

 Replying to [comment:2 mtredinnick]:
 > We also probably need a way to indicate "don't gzip this", down the
 track, so that the !HttpResponse creator can avoid this middleware piece
 for particular pieces of content (trying to gzip a zip archive is pretty
 pointless, for example).

 Yo can do that in the vie function by striping 'gzip' from the request's
 HTTP_ACCEPT_ENCODING header. Maybe we should introduce a decorator for
 that.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10630: [PATCH] GZipMiddleware does not handle all MSIE issues.

[Django]

#10630: [PATCH] GZipMiddleware does not handle all MSIE issues.
--+-
  Reporter:  sebastian_noack  | Owner:  nobody
Status:  closed   | Milestone:  1.1   
 Component:  HTTP handling|   Version:  1.0   
Resolution:  fixed|  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by mtredinnick):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 Fixed in r10541.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10630: [PATCH] GZipMiddleware does not handle all MSIE issues.

[Django]

#10630: [PATCH] GZipMiddleware does not handle all MSIE issues.
--+-
  Reporter:  sebastian_noack  | Owner:  nobody
Status:  new  | Milestone:  1.1   
 Component:  HTTP handling|   Version:  1.0   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by mtredinnick):

 This isn't a particularly great solution, since it's no doubt throwing out
 a few babies with the bathwater, but I agree we probably have to be a bit
 conservative here. Will apply this patch and, in the future, we can add
 more whitelisted exceptions if they seem worth it. We also probably need a
 way to indicate "don't gzip this", down the track, so that the
 !HttpResponse creator can avoid this middleware piece for particular
 pieces of content (trying to gzip a zip archive is pretty pointless, for
 example).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10630: [PATCH] GZipMiddleware does not handle all MSIE issues.

[Django]

#10630: [PATCH] GZipMiddleware does not handle all MSIE issues.
--+-
  Reporter:  sebastian_noack  | Owner:  nobody
Status:  new  | Milestone:  1.1   
 Component:  HTTP handling|   Version:  1.0   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by thatch):

  * needs_better_patch:  => 0
  * component:  Uncategorized => HTTP handling
  * needs_tests:  => 0
  * milestone:  => 1.1
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #10630: [PATCH] GZipMiddleware does not handle all MSIE issues.

[Django]

#10630: [PATCH] GZipMiddleware does not handle all MSIE issues.
-+--
 Reporter:  sebastian_noack  |   Owner:  nobody
   Status:  new  |   Milestone:
Component:  Uncategorized| Version:  1.0   
 Keywords:   |   Stage:  Unreviewed
Has_patch:  1|  
-+--
 There is a hook in the GZipMiddleware which bypass compression for
 javascript and pdfs, if user agent is MSIE. But I had to note that there
 are more situations where MSIE sucks. For example zip archives are not
 decompressed by Internet Explorer, instead MSIE saves a gzip compressed
 zip archive (which you can't open), even when using the latest version of
 Internet Explorer. So because of MSIE sucks so much and there might be
 another cases where compression leads to problems, I think the best
 aproach is to bypass compression for each non-text content type, when
 using MSIE. I have written a patch for that, see attachment.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---