Re: [Django] #10735: Comment redirect breaks if you want to send get data

[Django]

#10735: Comment redirect breaks if you want to send get data
--+-
  Reporter:  Nate | Owner:  nobody
Status:  closed   | Milestone:
 Component:  django.contrib.comments  |   Version:  SVN   
Resolution:  fixed|  Keywords:
 Stage:  Unreviewed   | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by SmileyChris):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 Fixed in r10424

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10735: Comment redirect breaks if you want to send get data

[Django]

#10735: Comment redirect breaks if you want to send get data
--+-
  Reporter:  Nate | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.comments  |   Version:  SVN   
Resolution:   |  Keywords:
 Stage:  Unreviewed   | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by thejaswi_puthraya):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Your problem seems genuine, but can you please follow the coding style
 adopted in django.

  * No imports within a function
  * I doubt if the
{{{
  'a' if something else 'b'
 }}}
works with Python-2.4 and earlier.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #10735: Comment redirect breaks if you want to send get data

[Django]

#10735: Comment redirect breaks if you want to send get data
-+--
 Reporter:  Nate |   Owner:  nobody
   Status:  new  |   Milestone:
Component:  django.contrib.comments  | Version:  SVN   
 Keywords:   |   Stage:  Unreviewed
Has_patch:  1|  
-+--
 I'm making a site where you can view models in sets, and the sets are
 specified with GET. So you may have a url like /entries/?set=first or
 something. With the django comment system, you can have the form redirect
 by setting "next" in a hidden field or the like, and the comment form
 redirects there when it's done. However, it sends get data of its own, and
 assumes that the url in "next" doesn't already have get data. In my case
 it does. Thus, django comments just sticks "?c=whatever" on the end of my
 url, which is wrong. I've supplied a patch that simply checks if the url
 has GET data (I just search for ".*?[^/]*$", which is probably horribly
 wrong, but it works for my intents and purposes), and if that matches,
 comments uses "&" instead of "?".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---