Re: [Django] #10882: FormWizard process_step receives yet to be validated form for previous steps

[Django]

#10882: FormWizard process_step receives yet to be validated form for previous
steps
-+-
   Reporter: |  Owner:  jashugan
  graham.carlyle@…   | Status:  closed
   Type:  Bug|  Component:  contrib.formtools
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:
 Resolution:  wontfix|  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  1
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by jezdez):

 * status:  assigned => closed
 * resolution:   => wontfix
 * easy:   => 0


Comment:

 Superseded by #9200.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10882: FormWizard process_step receives yet to be validated form for previous steps

[Django]

#10882: FormWizard process_step receives yet to be validated form for previous
steps
-+-
   Reporter: |Owner:  jashugan
  graham.carlyle@…   |   Status:  assigned
   Type:  Bug|Component:  contrib.formtools
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:
 Resolution: |Has patch:  1
   Triage Stage:  Accepted   |  Needs tests:  1
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by SmileyChris):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10882: FormWizard process_step receives yet to be validated form for previous steps

[Django]

#10882: FormWizard process_step receives yet to be validated form for previous
steps
+---
  Reporter:  graham.carl...@maplecroft.com  | Owner:  jashugan
Status:  assigned   | Milestone:  
 Component:  django.contrib.formtools   |   Version:  SVN 
Resolution: |  Keywords:  
 Stage:  Accepted   | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  1   
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10882: FormWizard process_step receives yet to be validated form for previous steps

[Django]

#10882: FormWizard process_step receives yet to be validated form for previous
steps
+---
  Reporter:  graham.carl...@maplecroft.com  | Owner:  jashugan
Status:  assigned   | Milestone:  
 Component:  django.contrib.formtools   |   Version:  SVN 
Resolution: |  Keywords:  
 Stage:  Unreviewed | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  1   
Needs_better_patch:  0  |  
+---
Changes (by jashugan):

  * status:  new => assigned
  * needs_better_patch:  => 0
  * needs_tests:  => 1
  * owner:  nobody => jashugan
  * needs_docs:  => 0
  * has_patch:  0 => 1

Comment:

 So, this is my first patch submission.  Let me know if I've done anything
 wrong.

 This patch ensures that process_step is always passed a form with "clean,
 valid data." It also removes a final sanity check before done() is called,
 because all of the forms should be validated.  I've added a valid_forms
 list that accumulates the forms as they are validated: first the forms
 preceding the current_step, then the form at the current_step.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #10882: FormWizard process_step receives yet to be validated form for previous steps

[Django]

#10882: FormWizard process_step receives yet to be validated form for previous
steps
---+
 Reporter:  graham.carl...@maplecroft.com  |   Owner:  nobody
   Status:  new|   Milestone:
Component:  django.contrib.formtools   | Version:  SVN   
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 The docs for FormWizard process_step state that "The Form is guaranteed to
 have clean, valid data." and so you might assume that the form it supplies
 is ready to use when passed to this method. However its only the current
 step that gets a form that has the cleaned_data property immediately
 accessible, whereas previous steps require the form.is_valid method to be
 called.

 So it seems that the code should call is_valid on forms from previous
 steps before passing the form to process_step. Presumably as the docs
 state the form would always be valid and if not then somehow the hash has
 been defeated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---