Re: [Django] #1105: [patch] simple_tag decorator enhancement

[Django]

#1105: [patch] simple_tag decorator enhancement
---+
  Reporter:  dja...@kieranholland.com  | Owner:  julien
Status:  new   | Milestone:
 Component:  Template system   |   Version:
Resolution:|  Keywords:
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Comment (by semenov):

 Considering my last attempt to add a bit of more usability to Django API
 (#11824), that's not going to happen. You can use this third-party
 implementation of simple_tag which has takes_context parameter:
 http://svn.navi.cx/misc/trunk/djblets/djblets/util/decorators.py

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #1105: [patch] simple_tag decorator enhancement

[Django]

#1105: [patch] simple_tag decorator enhancement
---+
  Reporter:  dja...@kieranholland.com  | Owner:  julien
Status:  new   | Milestone:
 Component:  Template system   |   Version:
Resolution:|  Keywords:
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Comment (by valentin golev):

 So, will it be added to trunk?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #1105: [patch] simple_tag decorator enhancement

[Django]

#1105: [patch] simple_tag decorator enhancement
---+
  Reporter:  dja...@kieranholland.com  | Owner:  julien
Status:  closed| Milestone:
 Component:  Template system   |   Version:
Resolution:  invalid   |  Keywords:
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Changes (by anonymous):

  * status:  new => closed
  * resolution:  => invalid

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #1105: [patch] simple_tag decorator enhancement

[Django]

#1105: [patch] simple_tag decorator enhancement
---+
  Reporter:  dja...@kieranholland.com  | Owner:  julien
Status:  new   | Milestone:
 Component:  Template system   |   Version:
Resolution:|  Keywords:
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Comment (by twig):

 i agree with semenov.

 the reason i've found this ticket is because i was looking for a simpler
 way of accessing the context.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #1105: [patch] simple_tag decorator enhancement

[Django]

#1105: [patch] simple_tag decorator enhancement
---+
  Reporter:  dja...@kieranholland.com  | Owner:  julien
Status:  new   | Milestone:
 Component:  Template system   |   Version:
Resolution:|  Keywords:
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Changes (by semenov):

 * cc: seme...@inetss.com (added)

Comment:

 That is just so unfair that register.inclusion_tag does accept
 takes_context=True and register.simple_tag doesn't. That leads to simple
 yet inefficient tags that render from a template just to be able to access
 the context. (The alternative is to create monstrous full-blown Node
 classes which is an overkill in most situations).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #1105: [patch] simple_tag decorator enhancement

[Django]

#1105: [patch] simple_tag decorator enhancement
---+
  Reporter:  [EMAIL PROTECTED]  | Owner:  julien
Status:  new   | Milestone:
 Component:  Template system   |   Version:
Resolution:|  Keywords:
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Comment (by Skaffen):

 I was wondering: if support for the "takes_context" addition to
 "simple_tag" is uncontentious could a fresh request be spawned for it so
 that the need for a decision about the extra "takes_nodelist" stuff
 doesn't further hold up or prevent that support for "takes_context" being
 added to simple_tag. If spawning a fresh ticket is not a
 sensible/desirable thing to do (esp. if I've misunderstood and
 takes_context support actually is contentious too), fair enough, but
 thought I'd ask :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #1105: [patch] simple_tag decorator enhancement

[Django]

#1105: [patch] simple_tag decorator enhancement
---+
  Reporter:  [EMAIL PROTECTED]  | Owner:  julien
Status:  new   | Milestone:
 Component:  Template system   |   Version:
Resolution:|  Keywords:
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Changes (by julien):

  * stage:  Accepted => Design decision needed

Comment:

 Marking DDN as per Malcolm's email on the dev-list:
 http://groups.google.com/group/django-developers/msg/7692178f04969f5b

 Specifically responding to Malcolm's comment:

 > [...] we need to consider whether adding something like "takes_nodelist"
 is really a good idea for something called *simple* tag decorator.


 I think that it is worth having `takes_nodelist`, as it does not
 necessarily "complexify" `simple_tag`. My interpretation of "simple tag",
 in this context, is two-fold: "simple to create a template tag" and "tag
 with simple syntax". The proposed patch preserves both of those.

 Conversely, a complex tag would be something with a complex syntax (e.g.
 `{% if ... and not ... %}`, or `{% get_comment_count for entry as
 comment_count %}`), and therefore would justify getting your hands dirty
 with variable resolving and tokens.

 At this stage, there is no way to "simply" create a "simple" block tag.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---