Re: [Django] #11110: Comments redirect after posting is not honoured if comment contains errors or is previewed

[Django]

#0: Comments redirect after posting is not honoured if comment contains 
errors
or is previewed
--+-
  Reporter:  Jeff Winters | Owner:  nobody
Status:  closed   | Milestone:
 Component:  django.contrib.comments  |   Version:  SVN   
Resolution:  fixed|  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by jezdez):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 I believe this has been fixed in [11019].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11110: Comments redirect after posting is not honoured if comment contains errors or is previewed

[Django]

#0: Comments redirect after posting is not honoured if comment contains 
errors
or is previewed
--+-
  Reporter:  Jeff Winters | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.comments  |   Version:  SVN   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by SafPlusPlus ):

  * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11110: Comments redirect after posting is not honoured if comment contains errors or is previewed

[Django]

#0: Comments redirect after posting is not honoured if comment contains 
errors
or is previewed
--+-
  Reporter:  Jeff Winters | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.comments  |   Version:  SVN   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Comment (by kgfullerton):

 Added patch which contains the fix for revision 10957 as well as test case
 - not sure why the diff isn't showing (is the output from svn diff)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11110: Comments redirect after posting is not honoured if comment contains errors or is previewed

[Django]

#0: Comments redirect after posting is not honoured if comment contains 
errors
or is previewed
--+-
  Reporter:  Jeff Winters | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.comments  |   Version:  SVN   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Changes (by SmileyChris):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 1
  * needs_docs:  => 0

Comment:

 Hey Jeff, would you like to have a crack at adding a test case to show the
 current failure (in `tests/regressiontests/comment_tests')?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #11110: Comments redirect after posting is not honoured if comment contains errors or is previewed

[Django]

#0: Comments redirect after posting is not honoured if comment contains 
errors
or is previewed
-+--
 Reporter:  Jeff Winters |   Owner:  nobody
   Status:  new  |   Milestone:
Component:  django.contrib.comments  | Version:  SVN   
 Keywords:   |   Stage:  Unreviewed
Has_patch:  1|  
-+--
 Hello,

 In using the comments framework, I have experienced some odd behaviour
 with regard to the "next" redirection. Provided that one specifies a value
 for "next" as part of the context for the template that contains the
 comment form, users posting valid comments without previewing them will
 indeed be redirected as expected. However, if the commenter previews his
 comment before posting, or if his comment contains errors, the "next"
 value is not honoured -- the user is redirected to the default "Thank you
 for your comment" page.

 For what it's worth, my use of the comments framework is extremely simple
 -- within my template, I use {% render_comment_form for post %}. "next" is
 passed as part of the template context from within the view.

 Attached is a simple patch that resolves the issue for my use of the
 comments framework. I fear that my issue may not be a bug at all and that
 I'm missing something obvious, but I took the precaution of asking about
 it on django-users (http://groups.google.com/group/django-
 users/browse_thread/thread/2f6768b95cb9a10e), and I received no responses
 within 24 hours.

 Thanks,

 Jeff

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---