Re: [Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
-+-
 Reporter:  vbmendes |Owner:  senko
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  formset  | Triage Stage:  Ready for
  non_form_errors validation |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Senko Rasic ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"493aca453aa94f160764d9a89c8043f7c9a67a78"]:
 {{{
 #!CommitTicketReference repository=""
 revision="493aca453aa94f160764d9a89c8043f7c9a67a78"
 Fixed #11160 - Ensure full_clean is called from non_form_errors

 Updated FormSet.non_form_errors() to ensure full_clean() has
 been called before returning the errors.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
-+-
 Reporter:  vbmendes |Owner:  senko
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  formset  | Triage Stage:  Ready for
  non_form_errors validation |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Andrew Godwin ):

 In [changeset:"04e0fc029f6868221dbba850e5a8830c8d11c42c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="04e0fc029f6868221dbba850e5a8830c8d11c42c"
 Merge pull request #1094 from senko/ticket_11160

 Fixed #11160: Formset non_form_errors returns ErrorList() if is_valid is
 not called
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
-+-
 Reporter:  vbmendes |Owner:  senko
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Ready for
  non_form_errors validation |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by tome):

 I have reviewed the solution, looks good as far as I can see.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.62001da3b7a3ea20a4372a89cc7fa187%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
-+-
 Reporter:  vbmendes |Owner:  senko
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Ready for
  non_form_errors validation |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by tome):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
-+-
 Reporter:  vbmendes |Owner:  senko
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  non_form_errors validation |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by senko):

 * needs_tests:  1 => 0


Comment:

 The patch "formset_non_form_errors.diff" doesn't do enough, because if
 non_form_errors() is called multiple times for any reasons, and there
 weren't any non-form errors, it will attempt the validation multiple
 times.

 The fix I got in a pull request at
 https://github.com/django/django/pull/1094 is slightly different:
 full_clean() always sets the _non_form_errors (either to an empty error
 list, or to the actual errors if there are any), and non_field_errors()
 just check whether it needs to run full_clean() beforehand.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
-+-
 Reporter:  vbmendes |Owner:  senko
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  non_form_errors validation |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by senko):

 * owner:  nobody => senko
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
-+-
   Reporter:  vbmendes   |Owner:  nobody
   Type:  Bug|   Status:  new
  Milestone: |Component:  Forms
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:  formset
   Triage Stage:  Accepted   |  non_form_errors validation
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  0  |  Needs tests:  1
-+-
Changes (by julien):

 * type:   => Bug
 * severity:   => Normal
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
---+
  Reporter:  vbmendes  | Owner:  nobody 
   
Status:  new   | Milestone: 
   
 Component:  Forms |   Version:  SVN
   
Resolution:|  Keywords:  formset non_form_errors 
validation
 Stage:  Accepted  | Has_patch:  1  
   
Needs_docs:  0 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
-+--
  Reporter:  vbmendes| Owner:  nobody   
 
Status:  new | Milestone:   
 
 Component:  Forms   |   Version:  SVN  
 
Resolution:  |  Keywords:  formset non_form_errors 
validation
 Stage:  Unreviewed  | Has_patch:  1
 
Needs_docs:  0   |   Needs_tests:  0
 
Needs_better_patch:  0   |  
-+--
Changes (by anonymous):

 * cc: vbmen...@gmail.com (added)
  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #11160: Formset non_form_errors returns ErrorList() if is_valid is not called

[Django]

#11160: Formset non_form_errors returns ErrorList() if is_valid is not called
+---
 Reporter:  vbmendes|   Owner:  nobody
   Status:  new |   Milestone:
Component:  Forms   | Version:  SVN   
 Keywords:  formset non_form_errors validation  |   Stage:  Unreviewed
Has_patch:  1   |  
+---
 If Formset.non_form_errors() is called before Formset.is_valid(), it will
 return an empty ErrorList.
 Let's pretend we have two formsets in one view and we make this test: if
 formset1.is_valid() and formset2.is_valid(). If formset1 is not valid,
 formset2's is_valid() will not be called. It means that the user will have
 to fix all the formset1's validation erros before knowing that formset2
 also has errors. It's annoying for the user.

 I wrote a little patch to fix this issue. Just changing a little the
 Formset.non_form_errors() function.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---