Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
-+-
   Reporter:  phr|  Owner:  nobody
   Type: | Status:  closed
  Cleanup/optimization   |  Component:  Core (Mail)
  Milestone:  1.3|   Severity:  Normal
Version:  SVN|   Keywords:  send_mail
 Resolution:  fixed  |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by jezdez):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16178]:
 {{{
 #!CommitTicketReference repository="" revision="16178"
 Fixed #11212 -- Stopped using quoted-printable encoding for mails with
 non-ASCII characters but rely on 8bit encoding instead. Thanks, phr, gisle
 and Ramiro Morales.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
-+-
   Reporter:  phr|  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Mail)
  Milestone:  1.3|   Severity:  Normal
Version:  SVN|   Keywords:  send_mail
 Resolution: |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by jezdez):

 * easy:   => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
+---
   Reporter:  phr   | Owner:  nobody   
 Status:  new   | Milestone:  1.3  
  Component:  django.core.mail  |   Version:  SVN  
 Resolution:|  Keywords:  send_mail
   Triage Stage:  Accepted  | Has patch:  1
Needs documentation:  0 |   Needs tests:  0
Patch needs improvement:  0 |  
+---
Changes (by ramiro):

  * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
+---
   Reporter:  phr   | Owner:  nobody   
 Status:  new   | Milestone:  1.3  
  Component:  django.core.mail  |   Version:  SVN  
 Resolution:|  Keywords:  send_mail
   Triage Stage:  Accepted  | Has patch:  1
Needs documentation:  0 |   Needs tests:  0
Patch needs improvement:  1 |  
+---
Changes (by ramiro):

  * needs_better_patch:  0 => 1


Comment:

 Tests need to be converted to unit tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:  1.3  
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  0 |  
---+
Changes (by andrewbadr):

  * milestone:  => 1.3

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  0 |  
---+
Changes (by phr):

  * needs_better_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  1 |  
---+
Comment (by phr):

 Replying to [comment:8 gisle]:
 > I've included a patch that makes the tests pass, but as demonstrated by
 the patch this make us start generating email with "`Content-Transfer-
 Encoding: 8bit`" when passing in Unicode strings as subject or content.  I
 think that should be avoided, so I don't recommend this patch as is.

 [[BR]]

 The use of 8bit encoding is exactly the aim of this ticket, so the patch
 does the right thing IMHO.

 Except for a few legacy paths, SMTP is mostly 8bit today - and where not,
 it's the MTA's role to downconvert to 7bit.

 Many email clients are generating 8bit-encoded messages (Thunderbird,
 Mutt, etc) and people routinely use 8bit email every day. Avoiding it
 makes no longer any sense, and the current practice of using quoted-
 printable does not work right for non-latin aplhabets.

 Please note that other software already implemented my proposal - see e.g.
 http://trac.edgewall.org/ticket/8252

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  1 |  
---+
Changes (by ubernostrum):

  * milestone:  1.2 =>

Comment:

 1.2 is feature-frozen, moving this feature request off the milestone.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:  1.2  
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  1 |  
---+
Changes (by gisle):

  * owner:  gisle => nobody
  * needs_better_patch:  0 => 1
  * needs_tests:  1 => 0

Comment:

 I've included a patch that makes the tests pass, but as demonstrated by
 the patch this make us start generating email with "`Content-Transfer-
 Encoding: 8bit`" when passing in Unicode strings as subject or content.  I
 think that should be avoided, so I don't recommend this patch as is.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  gisle
Status:  new   | Milestone:  1.2  
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  1
Needs_better_patch:  0 |  
---+
Changes (by gisle):

  * owner:  nobody => gisle

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:  1.2  
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  1
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Unreviewed| Has_patch:  1
Needs_docs:  0 |   Needs_tests:  1
Needs_better_patch:  0 |  
---+
Comment (by phr):

 Yes, sure those tests fail. They test for:

 Content-Transfer-Encoding: quoted-printable

 at multiple places, which after the proposed change will not pass.
 If the input is pure ascii, that header will become:

 Content-Transfer-Encoding: 7bit

 If the input contains some accentuated character - e.g. 'áéí', there will
 be 8bit instead.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Unreviewed| Has_patch:  1
Needs_docs:  0 |   Needs_tests:  1
Needs_better_patch:  0 |  
---+
Comment (by lukeplant):

 You need to update and add to the tests in
 tests/regressiontests/mail/tests.py, which fail with the above change.
 You should add tests that show what happens with 7bit and 8bit data.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Unreviewed| Has_patch:  1
Needs_docs:  0 |   Needs_tests:  1
Needs_better_patch:  0 |  
---+
Comment (by phr):

 I'm not quite sure what to test here. Only a single parameter needs to be
 changed
 in file django/core/mail.py at line 23:

 {{{
 -Charset.add_charset('utf-8', Charset.SHORTEST, Charset.QP, 'utf-8')
 +Charset.add_charset('utf-8', Charset.SHORTEST, None, 'utf-8')
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Unreviewed| Has_patch:  1
Needs_docs:  0 |   Needs_tests:  1
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * needs_tests:  0 => 1

Comment:

 Tests aren't optional. If you're changing code, you need tests - or a good
 excuse why a test isn't possible.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
---+
  Reporter:  phr   | Owner:  nobody   
Status:  new   | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  send_mail
 Stage:  Unreviewed| Has_patch:  1
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  0 |  
---+
Changes (by phr):

 * cc: phr (removed)
 * cc: petr.hrou...@gmail.com (added)
  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #11212: Don't encode emails with base64/qp

[Django]

#11212: Don't encode emails with base64/qp
--+-
 Reporter:  phr   |   Owner:  nobody
   Status:  new   |   Milestone:
Component:  django.core.mail  | Version:  SVN   
 Keywords:  send_mail |   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 #3472 introduced a patch, which replaces base64 encoding with quoted-
 printable.

 Anyway, there's even better way to do get rid of unnecessary encoding:

 {{{
 from email import Charset
 Charset.add_charset('utf-8',Charset.SHORTEST,None,'utf-8')
 }}}

 The above will set Content-Transfer-Encoding to 7bit or 8bit as needed -
 exactly as Mutt or Thunderbird do
 and completely solve the problem even for non-latin characters.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---