Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
-+-
 Reporter:  margieroginski   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.1-beta
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  model formsets   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"917cc288a38f3c114a5440f0749b7e5e1086eb36" 917cc288]:
 {{{
 #!CommitTicketReference repository=""
 revision="917cc288a38f3c114a5440f0749b7e5e1086eb36"
 Fixed #11313 -- Made ModelAdmin.list_editable more resilient to concurrent
 edits.

 Allowed admin POSTed bulk-edit data to use modeladmin.get_queryset()
 so that the ids in the POST data have a chance to match up even if
 the objects on the current page changed based on the ordering.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.1108884aa05969ecb678369a95df3cf0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
-+-
 Reporter:  margieroginski   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.1-beta
 Severity:  Normal   |   Resolution:
 Keywords:  model formsets   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_docs:  1 => 0
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.067cd9a9b55702b54f43627408d809a6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  model formsets  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by benred42):

 While I still have not been able to reproduce the issue exactly as stated
 on the ticket, I have found a potentially related issue:

 1) User1 opens an admin changelist for a model with list-editable fields
 2)  User2 edits object "Foo" of that same model such that it moves to
 another page in the pagination order and saves
 3) User1 edits object "Foo" and saves
 4)  The edit made by User1 does not get applied to object "Foo" but
 instead are used to create a new object

 I have attempted to address this issue in PR 5686
 https://github.com/django/django/pull/5686

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.5bf253808aab9bb4dd11ad99f59c1ef6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  model formsets  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by timgraham):

 I suspect so, but you could try your test on Django 1.7 to see if it fails
 there as patjlm indicated he could reproduce the issue there.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.228d0a32cc84580612cb4fc271596cbb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  model formsets  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by benred42):

 * cc: benred42@… (added)


Comment:

 Is this issue still present in 1.8?  I was attempting to write a test for
 the issue and could not reproduce the issue as stated in the ticket.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.4998bf0bfe4944e4039da0fedefcd45d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  model formsets  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by sggottlieb):

 * cc: sggottlieb (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.c601e8fdd0ebd2d85e296e12a679ecc1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  model formsets  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by collinanderson):

 * keywords:   => model formsets
 * cc: cmawebsite@… (added)


Comment:

 As others have said, ModelFormsets in general should rely on a pk
 identifier rather than where the object falls in queryset ordering.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.e1654bda1f28860092cf67a4bdb63eb5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by CarstenF):

 * cc: carsten.fuchs@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.910e440c5267cb2a8a6262409073a36f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by zachborboa):

 * cc: zachborboa (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b30acc6f4d797d43783e6fa380a84b68%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by timgraham):

 * severity:  Release blocker => Normal


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.8f1e3f7833062f0931b5df0507d19314%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
-+
 Reporter:  margieroginski   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.1-beta
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by sailorfred):

 * severity:  Normal => Release blocker


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.9edf680adb65c8354a7e10c4b85b0863%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by patjlm):

 Looking very quickly into the code, I think that this can be solved by
 replacing the following in contrib/admin/options.py changelist_view

 replace (line 1526 in 1.7 / line 1382 in 1.6.7)
   formset = cl.formset = FormSet(request.POST, request.FILES,
 queryset=cl.result_list)
 by
   formset = cl.formset = FormSet(request.POST, request.FILES)

 in this test section:
   # Handle POSTed bulk-edit data.
   if (request.method == "POST" and cl.list_editable and '_save' in
 request.POST and not action_failed):

 I am not used to generate patches nor am I knowledgeable enough in Django
 to assess if this change has a more global impact.
 Could anyone have a look?

 Thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.cfdaa87dc0e92d38716512fd15ca803d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by patjlm):

 * cc: patjlm (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.96f552d340d07ea86b9eab1c06edbd7d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by patjlm):

 This issue persists un Django 1.6.7. If an admin opens a page with
 list_editable items while data can be inserted (from admin or other flow),
 field values may end up being updated with values from other instances of
 the model.
 This created a big mess for us recently: around 50 records got updated
 with wrong values.
 Is there any timeline for a fix? Does anyone know what should be patched?
 Thanks,
 Patrick

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.895fd1f00ab8502b92246bac58228599%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by saxix):

 django-concurrency 0.6dev supports list_editable and  admin's actions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.2150b452fe527d0b6c8d48750c84e3f6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by saxix):

 * cc: saxix.rome@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.a9815efbc4de5eb8a2f2da5e426e7410%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by oinopion):

 * cc: tomek@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.da24994321ac508ae2a7420ab4164f3f%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  1.1-beta
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by pombredanne@…):

 The approach would be imho to integrate something like django-concurrency
 https://github.com/saxix/django-concurrency though for now it does not
 support list_editable yet 
 What would be the best approach to build that ins django?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.ad767032aa8d16568528960cbba41568%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+--
 Reporter:  margieroginski  |Owner:  nobody
 Type:  Bug |   Status:  reopened
Component:  contrib.admin   |  Version:  1.1-beta-1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by aaugustin):

 * severity:  Release blocker => Normal


Comment:

 1.5 beta has been released. At this stage, only tickets that must be fixed
 for RC1 can be release blockers.

 Please don't abuse Trac's flags to push your personal agenda at the
 expense of everyone else who's waiting for 1.5 final.

 If you want to drive more attention to this issue, please write to the
 django-developers mailing list.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
-+--
 Reporter:  margieroginski   |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  contrib.admin|  Version:  1.1-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by sailorfred@…):

 * needs_docs:  0 => 1
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
-+--
 Reporter:  margieroginski   |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  contrib.admin|  Version:  1.1-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by anonymous):

 I attached a documentation patch.  Feel free to change the wording, or fix
 syntax problems.  I worked from example in the document.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
-+--
 Reporter:  margieroginski   |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  contrib.admin|  Version:  1.1-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by sailorfred@…):

 * cc: sailorfred@… (added)
 * type:  New feature => Bug
 * severity:  Normal => Release blocker


Comment:

 Point me to the right place in the code, and I'll write you a patch.

 From someone who is a user, but hasn't had the time to dig into your code
 base, it seems that the fields that are changing need to be identified by
 the PK, not the position in a query set, which will change between the GET
 and the POST.

 This is not a feature, it's a long standing bug that has caused data
 destruction for multiple organizations.

 At the very least, update the documentation to point out the quicksand
 awaiting active sites.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+--
 Reporter:  margieroginski  |Owner:  nobody
 Type:  New feature |   Status:  reopened
Component:  contrib.admin   |  Version:  1.1-beta-1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by aaugustin):

 * version:  1.4 => 1.1-beta-1
 * type:  Bug => New feature
 * severity:  Release blocker => Normal


Comment:

 Django 1.1 to 1.4 have been released while this was a know bug. I don't
 see a compelling reason why it should delay 1.5.

 If you want to help, write a patch, don't attempt to block releases!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
-+
 Reporter:  margieroginski   |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  contrib.admin|  Version:  1.4
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by sailorfred@…):

 * version:  1.1-beta-1 => 1.4
 * type:  New feature => Bug
 * severity:  Normal => Release blocker


Comment:

 This is still biting people in 1.4.2.  :(  Also, this is a critical bug,
 not a new feature.

 The case we're seeing is when rows get inserted into the database while an
 admin index page is up.

 At least modify the docs to warn in huge red letters that that this is
 unsafe for all cases where data may enter the system other than from a
 single admin user.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
+--
 Reporter:  margieroginski  |Owner:  nobody
 Type:  New feature |   Status:  reopened
Component:  contrib.admin   |  Version:  1.1-beta-1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by julien):

 * ui_ux:   => 0


Comment:

 #17118 reported one of possibly several issues making `list_editable` non
 thread safe, ie with the `BaseModelFormSet._object_dict` cache.

 By the way, as suggested by the reporter in #17118, a warning should be
 added to the documentation indicating that `list_editable` isn't thread
 safe. That could be committed right away if a patch is provided.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
--+---
   Reporter:  margieroginski  |  Owner:  nobody
   Type:  New feature | Status:  reopened
  Milestone:  1.3 |  Component:  contrib.admin
Version:  1.1-beta-1  |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Accepted|  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
--+---
Changes (by poswald):

 * cc: poswald (added)
 * easy:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
--+-
   Reporter:  margieroginski  |Owner:  nobody
   Type:  New feature |   Status:  reopened
  Milestone:  1.3 |Component:  contrib.admin
Version:  1.1-beta-1  | Severity:  Normal
 Resolution:  | Keywords:
   Triage Stage:  Accepted|Has patch:  0
Needs documentation:  0   |  Needs tests:  0
Patch needs improvement:  0   |
--+-

Comment (by julien):

 See #11652 for a related issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
---+
  Reporter:  margieroginski| Owner:  nobody
Status:  reopened  | Milestone:  1.3   
 Component:  django.contrib.admin  |   Version:  1.1-beta-1
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by andybak):

 Is there not a much bigger problem with list_editable?

 Admin1 has the changelist open
 Admin2 makes a load of changes
 Admin1 makes a single change and wipes all of Admin2's changes

 This will affect least for the number of items specified in
 ModelAdmin.list_per_page which is 100 by default.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
---+
  Reporter:  margieroginski| Owner:  nobody
Status:  reopened  | Milestone:  1.3   
 Component:  django.contrib.admin  |   Version:  1.1-beta-1
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ubernostrum):

  * milestone:  1.2 => 1.3

Comment:

 With no further action -- not even a patch -- there's no way this makes
 1.2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
---+
  Reporter:  margieroginski| Owner:  nobody
Status:  reopened  | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  1.1-beta-1
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.2

Comment:

 Strictly, #10922 is the same problem - i.e., there is a problem ensuring
 that the objects in the queryset used to construct an initial form
 correspond to the objects in the queryset used to save the form. The patch
 on #10922 fixes the problems with the single-user use case; the multi-user
 use case described here is another manifestation of the larger problem.

 Both problems have existed for a long time (at least since newforms-admin
 was introduced); the specific problem described in #10922 is a little more
 prominent now due to the list_editable changes introduced in v1.1. In
 light of the need to get v1.1 out the door, I'll keep this ticket open as
 a placeholder for work required in the v1.2 timeframe to fix the multiuser
 case.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
---+
  Reporter:  margieroginski| Owner:  nobody
Status:  reopened  | Milestone:
 Component:  django.contrib.admin  |   Version:  1.1-beta-1
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by margieroginski):

  * status:  closed => reopened
  * resolution:  duplicate =>

Comment:

 You know, I thought about this some more and I actually am now thinking
 that the patch for 10922 is not sufficient.  In the admin, the creation of
 the ChangeList() object is what identifies the objects that will be
 changed.  It is this changelist that contains the incorrect queryset, and
 the patch does not address this at all.   In the case described in my
 ticket, the queryset that is returned by the ChangeList() for user1's GET
 request is actually different from the queryset returned by the ChangeList
 for user1's POST request.  It is different due to changes that were
 applied by a POST by a different user.

 I think the fixes in the patch are addressing the case where the queryset
 contains the objects specified in the POST data, but in a different order.
 In my ticket, this is not the case.  Basically, in the admin application,
 I don't think that the processing of the POST should be creating a
 ChangeList through the same mechanism that it uses as in the GET.  There
 is no reason to do all of the filtering and ordering that is done when
 creating a ChangeList.  Instead, the POST processing should simply
 identify all of the objects specified in the POST and save the changes
 accordingly.  If there is an error, it should re-render those exact items
 with the appropriate errors (not a newly filtered set of items).  If there
 is no error, it should then create a ChangeList, doing the standard
 filtering/ordering and render that.

 So I'm going to reopen this since I am fairly certain that it is not fixed
 by 10922.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
---+
  Reporter:  margieroginski| Owner:  nobody
Status:  closed| Milestone:
 Component:  django.contrib.admin  |   Version:  1.1-beta-1
Resolution:  duplicate |  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * status:  new => closed
  * resolution:  => duplicate

Comment:

 Marked as dupe because of above.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
---+
  Reporter:  margieroginski| Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.1-beta-1
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by margieroginski):

 Yes, I think you are right that this is a dup of 10922.  I looked at the
 patch and based on a quick review it looks like it will solve this
 problem.  So feel free to close this.

 Margie

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
---+
  Reporter:  margieroginski| Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.1-beta-1
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ramiro):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 This seems to be a duplicate of (#10784 and) #10922.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #11313: list_editable fields don't support 'save' in multiuser environment

[Django]

#11313: list_editable fields don't support 'save' in multiuser environment
--+-
 Reporter:  margieroginski|   Owner:  nobody
   Status:  new   |   Milestone:
Component:  django.contrib.admin  | Version:  1.1-beta-1
 Keywords:|   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 I don't think that the list_editable fields concept in the admin, as
 implmemented in 1.1, works.  Imagine this:

  1. User 1 brings up a changelist for an object and orders it by a
 'deadline' field, most recent first, resulting in object 'foo' being shown
 as the most recent object
  2. User 2 edits object 'foo' and changes its deadline field so that it is
 no longer the most recent object
  3. User 1 still has the changelist form on his screen, and modifies the
 'name' field of object foo.  Then he hits 'save'.

 When the 'save' request from user 1 is processed, a queryset for the
 objects is created that is ordered by deadline.  However, the ordering of
 the queryset in the POST request is different than the ordering of the
 queryset in the GET request made by user 1, due to the edit made by user
 2.  In the example I describe above, object foo is no longer the object
 that has the most recent deadline when the code processes user 1's POST
 request.  Instead, object 'bar' is.   In effect, it's as if the code
 thinks the user wants to change the name of object 'bar' instead of object
 'foo'.  However, the id sent with the post data is for object 'foo'.
 Eventually we get into _perform_unique_checks() and this sort of
 identifies that there is a problem.  There is the following code:

 {{{

 # Exclude the current object from the query if we are editing
 an
 # instance (as opposed to creating a new one)
 if self.instance.pk is not None:
 qs = qs.exclude(pk=self.instance.pk)

 }}}

 In a non-multiuser case I think this would exclude the instance being
 edited, but in this case it doesn't.  The result is that we drop into the
 next lines of code which generate an error, but the error looks like this:
 "Task with this None already exists."  It contains the word "None" because
 the id field does not have a laberl attribute (ie self.fields['id'].label
 is None). I see this error when I print the form but it actually doesn't
 even show up in the admin ui.  I just see the message "Please correct the
 errors below", but no errors are shown below.

 In general it seems like a different tact needs to be taken for the POST
 request related to modification of editable fields.  It seems to me that
 the code needs to identify the object being modified based on the id, and
 modify that object, rather than creating a queryset based on the filters
 and ordering and simply indexing in by form number.


 Margie

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---