Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
+---
  Reporter:  dburke | Owner:  kmtracey 
Status:  closed | Milestone:   
 Component:  Contrib apps   |   Version:  1.0  
Resolution:  fixed  |  Keywords:  sprintSep2010
 Stage:  Ready for checkin  | Has_patch:  1
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Comment (by lukeplant):

 I backported it now - [13985]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
+---
  Reporter:  dburke | Owner:  kmtracey 
Status:  closed | Milestone:   
 Component:  Contrib apps   |   Version:  1.0  
Resolution:  fixed  |  Keywords:  sprintSep2010
 Stage:  Ready for checkin  | Has_patch:  1
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Comment (by kmtracey):

 Replying to [comment:11 lukeplant]:
 > Is there a reason this wasn't backported?  I'm trying to backport
 another patch, and I've got a conflict because this hasn't been backported
 to 1.2.X.

 Hectic sprint day oversight, I think. On first read I think I thought this
 was more of a feature than a bugfix...on re-looking at it it seems to be
 more of a bugfix, so should probably be backported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
+---
  Reporter:  dburke | Owner:  kmtracey 
Status:  closed | Milestone:   
 Component:  Contrib apps   |   Version:  1.0  
Resolution:  fixed  |  Keywords:  sprintSep2010
 Stage:  Ready for checkin  | Has_patch:  1
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Comment (by lukeplant):

 Is there a reason this wasn't backported?  I'm trying to backport another
 patch, and I've got a conflict because this hasn't been backported to
 1.2.X.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
+---
  Reporter:  dburke | Owner:  kmtracey 
Status:  new| Milestone:   
 Component:  Contrib apps   |   Version:  1.0  
Resolution: |  Keywords:  sprintSep2010
 Stage:  Ready for checkin  | Has_patch:  1
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Changes (by kmtracey):

  * owner:  nobody => kmtracey

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
+---
  Reporter:  dburke | Owner:  nobody   
Status:  new| Milestone:   
 Component:  Contrib apps   |   Version:  1.0  
Resolution: |  Keywords:  sprintSep2010
 Stage:  Ready for checkin  | Has_patch:  1
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Changes (by mlavin):

  * owner:  mlavin => nobody
  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
---+
  Reporter:  dburke| Owner:  mlavin   
Status:  new   | Milestone:   
 Component:  Contrib apps  |   Version:  1.0  
Resolution:|  Keywords:  sprintSep2010
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  0 |  
---+
Changes (by mlavin):

  * keywords:  => sprintSep2010

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
---+
  Reporter:  dburke| Owner:  mlavin
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by mtredinnick):

 The code change looks fine, however I'd like a small tweak in the
 documentation: rather then explaining the effect in code
 (`registration_required=False`), try to do it in English (e.g. "pages
 which are visible to all users, including those not logged in" or
 something a little more concise). It can disrupt the reading flow to have
 to switch to understanding that flatpages model has an attribute called
 `registration_required` and so on.

 Are there any existing sitemap tests? If so, they might need to be updated
 here. If not, have a think about if there's some way to test them even a
 little bit. It might be hard to do so, but shouldn't be impossible (using
 test.Client to pull back a sample of the sitemap and examine the contents,
 perhaps?)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
---+
  Reporter:  dburke| Owner:  mlavin
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by mlavin):

  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
---+
  Reporter:  dburke| Owner:  mlavin
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by mlavin):

  * owner:  nobody => mlavin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
---+
  Reporter:  dburke| Owner:  nobody
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * stage:  Unreviewed => Accepted

Comment:

 A sitemap exists for the benefit of public spiders and crawlers, so there
 isn't much point having a sitemap that includes private pages.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
---+
  Reporter:  dburke| Owner:  nobody
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by dburke):

 Yeah, this solution is fine.  Should be made a little more explicit in the
 Documentation?  Or should we hope that google helps direct people seeking
 this solution here?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
---+
  Reporter:  dburke| Owner:  nobody
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by kmpm):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 You almost answered it yourself.
 I don't know if its worth doing a modification to sitemaps just for this.
 Save your class but with another name like "FlatPagePublicSitemap" in a
 file called "sitemaps.py" for example.
 Include ( from sitemaps include FlatPagePublicSitemap ) and use that class
 in your urls.py instead of the ordinary FlagPageSitemap.

 Is that a good enough solution for you?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #11358: Flatpage sitemap shows all pages, even private pages

[Django]

#11358: Flatpage sitemap shows all pages, even private pages
--+-
 Reporter:  dburke|   Owner:  nobody
   Status:  new   |   Milestone:
Component:  Contrib apps  | Version:  1.0   
 Keywords:|   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 I tried searching trac for this issue, but wasn't able to turn up anything
 relevant.

 Flatpages allow you to make a page visible only to logged in users, but
 the flatpage sitemap reveals the url.  Would it be possible to add a
 .filter(registration_required=False) to the queryset that populates the
 flatpage sitemap?

 in django.contrib.sitemaps:

 {{{
 class FlatPageSitemap(Sitemap):
 def items(self):
 from django.contrib.sites.models import Site
 current_site = Site.objects.get_current()
 return
 current_site.flatpage_set.filter(registration_required=False)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---