Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  akki
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"49f95cc0a0167e91fd0f6987428905911bff076c" 49f95cc0]:
 {{{
 #!CommitTicketReference repository=""
 revision="49f95cc0a0167e91fd0f6987428905911bff076c"
 Fixed #11560 -- Allowed proxy model multiple-inheritance from the same
 concrete base model.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.21fc7b3a3f4685a22a09c7176c4e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  akki
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * needs_docs:  1 => 0


Comment:

 Left a few comments for improvement.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.03d199e897bfe1354d8369ad42349e3a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  akki
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akki):

 * needs_better_patch:  1 => 0


Comment:

 PR: https://github.com/django/django/pull/6346/

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.e33ff49b3d961e58122589209f6fce07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  akki
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akki):

 * owner:  auvipy => akki


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.39ab8fdf520cc8ea18df3919f2ee7957%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  auvipy
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 I don't know of any work that would have resolved this ticket.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.cfda56a012efed52ffae44e188aa83c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  auvipy
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by auvipy):

 Replying to [comment:10 timgraham]:
 > The patch needs to be updated to apply cleanly. If you can update it and
 send a pull request, that will help. Also a mention in the release notes
 and a `.. versionchanged:: 1.8` annotation would be helpful. See our
 [https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
 /submitting-patches/#patch-review-checklist patch review checklist].


 Hi Tim,

 Is this issue already resolved by other works ? or I should work on the
 patch to implement it cleanly?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.0cfdd6b8262fac7e1d02e8ee00c88268%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  auvipy
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by auvipy):

 * status:  new => assigned
 * owner:  nobody => auvipy
 * version:  1.1-beta => master


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.06d1d751728074c1855b1c7ab37a7bc3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.1-beta
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timgraham):

 The patch needs to be updated to apply cleanly. If you can update it and
 send a pull request, that will help. Also a mention in the release notes
 and a `.. versionchanged:: 1.8` annotation would be helpful. See our
 [https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
 /submitting-patches/#patch-review-checklist patch review checklist].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.fedf1a52de143d0d566194be4c878105%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.1-beta
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Griatch):

 This has been lurking around for a long time, any idea when this might
 merge into master? The patch seems to have unittest information now and
 the feature itself is working. We would much like to use this feature
 without having to patch django itself.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.3beedf1f11bb0020cf2737870e958317%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
 Reporter:  rfk  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.1-beta
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by gzerone@…):

 Hi rfk, thanks for the patch file, it works for me. Hope the feature will
 work on master branch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.5d477f23547d3acad55f728400594046%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
   Reporter:  rfk|Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  Database layer
  Milestone: |  (models, ORM)
Version: | Severity:  Normal
  1.1-beta-1 | Keywords:
 Resolution: |Has patch:  1
   Triage Stage:  Accepted   |  Needs tests:  0
Needs documentation:  1  |
Patch needs improvement:  1  |
-+-

Comment (by rfk):

 I've redone the patch against latest trunk and added a brief note in the
 proxy models documentaion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
-+-
   Reporter:  rfk|Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  Database layer
  Milestone: |  (models, ORM)
Version: | Severity:  Normal
  1.1-beta-1 | Keywords:
 Resolution: |Has patch:  1
   Triage Stage:  Accepted   |  Needs tests:  0
Needs documentation:  1  |
Patch needs improvement:  1  |
-+-
Changes (by julien):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Old description:

> Currently proxy models are required to have a single concrete base model
> class.  Unfortunately this prevents me from combining several proxy
> subclasses of the same model.  In my particular use case, I have two
> different apps that provide two different proxies of the standard User
> model.  To successfully use both apps I need to create another subclass
> that combines the two, e.g:
>
> {{{
> class MyUser(App1User,App2User):
> class Meta:
> proxy = True
> }}}
>
> This gives a TypeError: "Proxy model 'MyUser' has more than one non-
> abstract model base class".  But since App1User and App2User proxy the
> same underlying model, there's no ambiguity introduced by this multiple
> inheritance and I think it should be permitted.
>
> Attached is a simple patch to make this work, by permitting additional
> concrete base classes if they are identical to the one that was already
> found.

New description:

 Currently proxy models are required to have a single concrete base model
 class.  Unfortunately this prevents me from combining several proxy
 subclasses of the same model.  In my particular use case, I have two
 different apps that provide two different proxies of the standard User
 model.  To successfully use both apps I need to create another subclass
 that combines the two, e.g:

 {{{
 class MyUser(App1User,App2User):
 class Meta:
 proxy = True
 }}}

 This gives a TypeError: "Proxy model 'MyUser' has more than one non-
 abstract model base class".  But since App1User and App2User proxy the
 same underlying model, there's no ambiguity introduced by this multiple
 inheritance and I think it should be permitted.

 Attached is a simple patch to make this work, by permitting additional
 concrete base classes if they are identical to the one that was already
 found.

--

Comment:

 The tests would need to be rewritten using unittests since this is now
 Django's preferred way.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
---+
  Reporter:  rfk   | Owner:  nobody
Status:  new   | Milestone:
 Component:  Database layer (models, ORM)  |   Version:  1.1-beta-1
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by rfk):

  * needs_better_patch:  => 0
  * component:  Uncategorized => Database layer (models, ORM)
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #11560: let proxy models multiple-inherit from the same concrete base model

[Django]

#11560: let proxy models multiple-inherit from the same concrete base model
---+
 Reporter:  rfk|   Owner:  nobody
   Status:  new|   Milestone:
Component:  Uncategorized  | Version:  1.1-beta-1
 Keywords: |   Stage:  Unreviewed
Has_patch:  1  |  
---+
 Currently proxy models are required to have a single concrete base model
 class.  Unfortunately this prevents me from combining several proxy
 subclasses of the same model.  In my particular use case, I have two
 different apps that provide two different proxies of the standard User
 model.  To successfully use both apps I need to create another subclass
 that combines the two, e.g:

 {{{
 class MyUser(App1User,App2User):
 class Meta:
 proxy = True
 }}}

 This gives a TypeError: "Proxy model 'MyUser' has more than one non-
 abstract model base class".  But since App1User and App2User proxy the
 same underlying model, there's no ambiguity introduced by this multiple
 inheritance and I think it should be permitted.

 Attached is a simple patch to make this work, by permitting additional
 concrete base classes if they are identical to the one that was already
 found.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---