Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
-+-
 Reporter:   |Owner:  nobody
  leanmeandonothingmachine   |   Status:  closed
 Type:  New feature  |  Version:  1.3-beta
Component:  contrib.admin|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  sprintnov13  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ramiro):

 Replying to [comment:17 hcarvalhoalves@…]:
 > Any reason why this ticket didn't entered 1.3.1?

 It's because bug fixes like this are no longer backported to the stable
 branch - it will not be in the next 1.3.X release. See
 https://docs.djangoproject.com/en/dev/internals/release-process
 /#supported-versions -- We changed our backporting policy for the
 maintenance period post 1.3.

 >It's still set for 1.3-beta

 I was reported as ''present'' in 1.3 beta (''Version'' field of this
 ticket) but it was targetted to be fixed in 1.4 (''Milestone'' field,
 since then removed from our Trac installation)

 > I would like to see this checked in for 1.3.2, let me know if I can help
 with tests or documentation. It's pretty annoying to have the {{{
 get_fieldsets }}} hook available but see it fail because of {{{
 prepopulated_fields }}}, and then rewrite almost half of the ModelAdmin to
 fix it.

 You can always port the changes committed to fix this ticket (or a subset
 of them) to a local copy of the 1.3.X branch and use that.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
-+-
 Reporter:   |Owner:  nobody
  leanmeandonothingmachine   |   Status:  closed
 Type:  New feature  |  Version:  1.3-beta
Component:  contrib.admin|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  sprintnov13  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by hcarvalhoalves@…):

 * ui_ux:   => 0


Comment:

 Any reason why this ticket didn't entered 1.3.1? It's still set for
 1.3-beta. I would like to see this checked in for 1.3.2, let me know if I
 can help with tests or documentation. It's pretty annoying to have the {{{
 get_fieldsets }}} hook available but see it fail because of {{{
 prepopulated_fields }}}, and then rewrite almost half of the ModelAdmin to
 fix it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
-+-
   Reporter: |  Owner:  nobody
  leanmeandonothingmachine   | Status:  new
   Type:  New|  Component:  contrib.admin
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:  sprintnov13
Version:  1.3-beta   |  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Ready for  |  Easy pickings:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by defaultwombat):

 * easy:   => 0


Comment:

 This is definitly a fix for #13618 too.

 Additionally it solves a problem when trying to manually fix the #13618
 issue by changeing the prepopulated_fields e.g. in the change_view.
 As this is a dictionary shared over all instances of the Adminmodel, after
 altering it you lost the prepopulating feature until server refresh.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
+---
   Reporter:  leanmeandonothingmachine  | Owner:  nobody
 
 Status:  new   | Milestone:  1.4   
 
  Component:  django.contrib.admin  |   Version:  1.3-beta  
 
 Resolution:|  Keywords:  
sprintnov13
   Triage Stage:  Ready for checkin | Has patch:  1 
 
Needs documentation:  0 |   Needs tests:  0 
 
Patch needs improvement:  0 |  
+---

Comment (by leanmeandonothingmachine):

 Ok, on the other hand it could be considered a fix for the bug in #13618

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
+---
   Reporter:  leanmeandonothingmachine  | Owner:  nobody
 
 Status:  new   | Milestone:  1.4   
 
  Component:  django.contrib.admin  |   Version:  1.3-beta  
 
 Resolution:|  Keywords:  
sprintnov13
   Triage Stage:  Ready for checkin | Has patch:  1 
 
Needs documentation:  0 |   Needs tests:  0 
 
Patch needs improvement:  0 |  
+---
Changes (by russellm):

  * milestone:  1.3 => 1.4


Comment:

 Agreed that this looks like a good idea, but it's definitely a new
 feature, not a bug fix, so it can't be added to 1.3 at this point.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
+---
   Reporter:  leanmeandonothingmachine  | Owner:  nobody
 
 Status:  new   | Milestone:  1.3   
 
  Component:  django.contrib.admin  |   Version:  1.3-beta  
 
 Resolution:|  Keywords:  
sprintnov13
   Triage Stage:  Ready for checkin | Has patch:  1 
 
Needs documentation:  0 |   Needs tests:  0 
 
Patch needs improvement:  0 |  
+---
Changes (by julien):

  * stage:  Accepted => Ready for checkin


Comment:

 This is a good patch, thanks for your great work. There's no guarantee
 that it can make it in 1.3 as this is essentially a new feature and we're
 now in beta stage. So we'll see ;)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
+---
   Reporter:  leanmeandonothingmachine  | Owner:  nobody
 
 Status:  new   | Milestone:  1.3   
 
  Component:  django.contrib.admin  |   Version:  1.3-beta  
 
 Resolution:|  Keywords:  
sprintnov13
   Triage Stage:  Accepted  | Has patch:  1 
 
Needs documentation:  0 |   Needs tests:  0 
 
Patch needs improvement:  0 |  
+---
Changes (by leanmeandonothingmachine):

  * needs_docs:  1 => 0
  * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
+---
   Reporter:  leanmeandonothingmachine  | Owner:  nobody
 
 Status:  new   | Milestone:  1.3   
 
  Component:  django.contrib.admin  |   Version:  1.3-beta  
 
 Resolution:|  Keywords:  
sprintnov13
   Triage Stage:  Accepted  | Has patch:  1 
 
Needs documentation:  1 |   Needs tests:  1 
 
Patch needs improvement:  0 |  
+---
Changes (by leanmeandonothingmachine):

  * version:  1.2 => 1.3-beta
  * milestone:  1.4 => 1.3


Comment:

 I updated the patch to include tests and documentation. I also added
 inline support based on the way get_readonly_fields works. Can this be
 considered for 1.3? If it really is too late then change it back to 1.4,
 it would be nice though to have this get some attention.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
+---
   Reporter:  leanmeandonothingmachine  | Owner:  nobody
 
 Status:  new   | Milestone:  1.4   
 
  Component:  django.contrib.admin  |   Version:  1.2   
 
 Resolution:|  Keywords:  
sprintnov13
   Triage Stage:  Accepted  | Has patch:  1 
 
Needs documentation:  1 |   Needs tests:  1 
 
Patch needs improvement:  0 |  
+---
Changes (by julien):

  * needs_docs:  0 => 1
  * needs_tests:  0 => 1
  * milestone:  1.3 => 1.4


Comment:

 That's a useful feature, but unfortunately it is too late for 1.3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
---+
  Reporter:  leanmeandonothingmachine  | Owner:  nobody 
Status:  new   | Milestone:  1.3
 Component:  django.contrib.admin  |   Version:  1.2
Resolution:|  Keywords:  sprintnov13
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by benspaulding):

 * cc: benspaulding (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
---+
  Reporter:  leanmeandonothingmachine  | Owner:  nobody 
Status:  new   | Milestone:  1.3
 Component:  django.contrib.admin  |   Version:  1.2
Resolution:|  Keywords:  sprintnov13
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by steph):

  * keywords:  => sprintnov13

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
---+
  Reporter:  leanmeandonothingmachine  | Owner:  nobody
Status:  new   | Milestone:  1.3   
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by leanmeandonothingmachine):

  * version:  1.1 => 1.2
  * milestone:  => 1.3

Comment:

 Updated the patch again. If there is anything wrong with this that is
 holding it up please lmk, i'd be happy to improve it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
---+
  Reporter:  leanmeandonothingmachine  | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by leanmeandonothingmachine):

 I updated the patch so it applies against trunk.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
---+
  Reporter:  leanmeandonothingmachine  | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by leanmeandonothingmachine):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Sorry that should be in ModelAdmin not BaseModelAdmin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #11639: Can't remove prepopulated fields from fieldset in ModelAdmin

[Django]

#11639: Can't remove prepopulated fields from fieldset in ModelAdmin
--+-
 Reporter:  leanmeandonothingmachine  |   Owner:  nobody
   Status:  new   |   Milestone:
Component:  django.contrib.admin  | Version:  1.1   
 Keywords:|   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 I'd like to propose that when the prepopulated fields argument that is
 passed to the AdminForm helper in BaseModelAdmin is generated by a method
 that takes the request object. That would give you ability to use the
 get_fieldsets overide to filter out prepopulated fields and then use this
 new override to alter the prepopulated fields to match what you did in
 get_fieldsets. See attached patch for my implementation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---