Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2014-01-18 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
 Reporter:  plandry@…|Owner:  Anssi
 Type:  Bug  |  Kääriäinen 
Component:  Database layer   |   Status:  closed
  (models, ORM)  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  F() expression   | Triage Stage:  Ready for
  query sql  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Anssi Kääriäinen ):

 * status:  new => closed
 * owner:   => Anssi Kääriäinen 
 * resolution:   => fixed


Comment:

 In [changeset:"20bab2cf9d02a5c6477d8aac066a635986e0d3f3"]:
 {{{
 #!CommitTicketReference repository=""
 revision="20bab2cf9d02a5c6477d8aac066a635986e0d3f3"
 Fixed #16187 -- refactored ORM lookup system

 Allowed users to specify which lookups or transforms ("nested lookus")
 are available for fields. The implementation is now class based.

 Squashed commit of the following:

 commit fa7a7195f1952a9c8dea7f6e89ee13f81757eda7
 Author: Anssi Kääriäinen 
 Date:   Sat Jan 18 10:53:24 2014 +0200

 Added lookup registration API docs

 commit eb1c8ce164325e0d8641f14202e12486c70efdb6
 Author: Anssi Kääriäinen 
 Date:   Tue Jan 14 18:59:36 2014 +0200

 Release notes and other minor docs changes

 commit 11501c29c9352d17f22f3a0f59d3b805913dedcc
 Author: Anssi Kääriäinen 
 Date:   Sun Jan 12 20:53:03 2014 +0200

 Forgot to add custom_lookups tests in prev commit

 commit 83173b960ea7eb2b24d573f326be59948df33536
 Author: Anssi Kääriäinen 
 Date:   Sun Jan 12 19:59:12 2014 +0200

 Renamed Extract -> Transform

 commit 3b18d9f3a1bcdd93280f79654eba0efa209377bd
 Author: Anssi Kääriäinen 
 Date:   Sun Jan 12 19:51:53 2014 +0200

 Removed suggestion of temporary lookup registration from docs

 commit 21d0c7631c161fc0c67911480be5d3f13f1afa68
 Merge: 2509006 f2dc442
 Author: Anssi Kääriäinen 
 Date:   Sun Jan 12 09:38:23 2014 -0800

 Merge pull request #2 from mjtamlyn/lookups_3

 Reworked custom lookups docs.

 commit f2dc4429a1da04c858364972eea57a35a868dab4
 Author: Marc Tamlyn 
 Date:   Sun Jan 12 13:15:05 2014 +

 Reworked custom lookups docs.

 Mostly just formatting and rewording, but also replaced the example
 using ``YearExtract`` to  use an example which is unlikely to ever be
 possible directly in the ORM.

 commit 250900650628d1f11beadb22814abd666029fb81
 Author: Anssi Kääriäinen 
 Date:   Sun Jan 12 13:19:13 2014 +0200

 Removed unused import

 commit 4fba5dfaa022653ffa72497258ffd8f8b7476f92
 Author: Anssi Kääriäinen 
 Date:   Sat Jan 11 22:34:41 2014 +0200

 Added docs to index

 commit 6d53963f375c77a1f287833b19b976d23f36c30b
 Author: Anssi Kääriäinen 
 Date:   Sat Jan 11 22:10:24 2014 +0200

 Dead code removal

 commit f9cc0390078e21f1ea5a7bc1f15b09f8f6b0904d
 Author: Anssi Kääriäinen 
 Date:   Sat Jan 11 19:00:43 2014 +0200

 A new try for docs

 commit 33aa18a6e3c831930bda0028222a26f9c1d96e66
 Author: Anssi Kääriäinen 
 Date:   Sat Jan 11 14:57:12 2014 +0200

 Renamed get_cols to get_group_by_cols

 commit c7d5f8661b7d364962bed2e6f81161c1b4f1bcc3
 Author: Anssi Kääriäinen 
 Date:   Sat Jan 11 14:45:53 2014 +0200

 Altered query string customization for backends vendors

 The new way is trying to call first method 'as_' + connection.vendor.
 If that doesn't exist, then call as_sql().

 Also altered how lookup registration is done. There is now
 RegisterLookupMixin class that is used by Field, Extract and
 sql.Aggregate. This allows one to register lookups for extracts and
 aggregates in the same way lookup registration is done for fields.

 commit 90e7004ec14e15503f828cc9bde2a7dab593814d
 Merge: 66649ff f7c2c0a
 Author: Anssi Kääriäinen 
 Date:   Sat Jan 11 13:21:01 2014 +0200

 Merge branch 'master' into lookups_3

 commit 66649ff891c7c73c7eecf6038c9a6802611b5d8a
 Author: Anssi Kääriäinen 
 Date:   Sat Jan 11 13:16:01 2014 +0200

 Some rewording in docs

 commit 31b8faa62714b4b6b6057a9f5cc106c4dd73caab
 Author: Anssi Kääriäinen 
 Date:   Sun Dec 29 15:52:29 2013 +0200

 Cleanup based on review comments

 commit 

Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2013-12-28 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
 Reporter:  plandry@…|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  F() expression   |  checkin
  query sql  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by akaariai):

 This one will be fixed as a side effect of lookup refactor, see:
 
https://github.com/akaariai/django/commit/193cd097ca8f2cc6a911e57b8e3fb726f96ee6a6

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.fac0a49817b849a492af3dada9098d07%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2013-12-16 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
 Reporter:  plandry@…|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  F() expression   |  checkin
  query sql  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * stage:  Accepted => Ready for checkin


Comment:

 Confirmed the regression test works as expected and passes on all
 backends.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.1a2c962bfa8526c7e0e6063feae0e5d6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2013-11-22 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
 Reporter:  plandry@…|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  F() expression   |  Needs documentation:  0
  query sql  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.4417e8d68c4e751ce0c6951e883786aa%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2013-11-20 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
 Reporter:  plandry@…|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  F() expression   |  Needs documentation:  0
  query sql  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by mumino):

 * cc: mumino (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.c8b8260746e5729f0f5ddd638360031f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2013-11-20 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
 Reporter:  plandry@…|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  F() expression   |  Needs documentation:  0
  query sql  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-

Comment (by mumino):

 invalid sql generation happens for iendswith, istartswith, icontains,
 iexact for postgreql. similar problems arise in SQLite. I think other
 backends have same problem too.

 this pull request has a fix. https://github.com/django/django/pull/1945

 on the other hand, F objects has another issue related with here.
 https://code.djangoproject.com/ticket/16731

 because of it istartswith, icontains, iendswith still don't produce
 correct SQL. but they produce valid SQL now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.00cd835051546ab60271214d731ae237%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2013-08-19 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
 Reporter:  plandry@…|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  F() expression   |  Needs documentation:  0
  query sql  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-

Comment (by akaariai):

 I can confirm that this issue is still present in master.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.6f05ad4f92a956d277c8d9239bb34621%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2013-01-15 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
 Reporter:  plandry@…|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  F() expression   |  Needs documentation:  0
  query sql  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Could you described how you confirmed this problem was fixed? Do you know
 which commit fixed it?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2013-01-15 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
 Reporter:  plandry@…|Owner:
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  F() expression   |  Needs documentation:  0
  query sql  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by anonymous):

 * status:  new => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2011-04-28 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
   Reporter:  plandry@…  |  Owner:
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:  F() expression
Needs documentation:  0  |  query sql
Patch needs improvement:  1  |  Has patch:  1
 |Needs tests:  1
 |  Easy pickings:  0
-+-

Comment (by Ubercore):

 Thanks, I'm attaching the diff with the test from that ticket here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2011-04-28 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
   Reporter:  plandry@…  |  Owner:
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:  F() expression
Needs documentation:  0  |  query sql
Patch needs improvement:  1  |  Has patch:  1
 |Needs tests:  1
 |  Easy pickings:  0
-+-
Changes (by aaugustin):

 * easy:   => 0


Comment:

 #15914 is a duplicate. A patch with a very simple test case exhibiting the
 problem is attached to that ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2011-04-01 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
-+-
   Reporter:  plandry@…  |Owner:
   Type:  Bug|   Status:  new
  Milestone: |Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:  F() expression query
Needs documentation:  0  |  sql
Patch needs improvement:  1  |Has patch:  1
 |  Needs tests:  1
-+-
Changes (by baumer1122):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2010-08-03 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner: 
 
Status:  new   | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  1  
 
Needs_better_patch:  1 |  
---+
Changes (by hongshun...@gmail.com):

 * cc: hongshun...@gmail.com (added)

Comment:

 I have the save problem when I use startswith lookup.
 After appling the patch, the problem isn't gone.
 I'm using V1.2.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2010-06-01 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner: 
 
Status:  new   | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  1  
 
Needs_better_patch:  1 |  
---+
Changes (by Ubercore):

  * owner:  Ubercore =>
  * status:  assigned => new

Comment:

 Removing myself from this ticket due to lack of time/progress. I still
 plan on looking at it when time is available!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2010-01-13 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner:  Ubercore   
 
Status:  assigned  | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  1  
 
Needs_better_patch:  1 |  
---+
Comment (by Ubercore):

 Closed #12545 as a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.




Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2010-01-13 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner:  Ubercore   
 
Status:  assigned  | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  1  
 
Needs_better_patch:  1 |  
---+
Changes (by Ubercore):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.




Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2010-01-13 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner:  Ubercore   
 
Status:  assigned  | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Unreviewed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  1  
 
Needs_better_patch:  1 |  
---+
Changes (by Ubercore):

  * owner:  nobody => Ubercore
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.




Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2010-01-05 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Unreviewed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  1  
 
Needs_better_patch:  1 |  
---+
Comment (by plan...@provplan.org):

 Right you are. Creating the regression test revealed some problems with my
 patch. I'll re-evaluate how I'm approaching this and get a patch + test up
 soon. Thanks for the gentle nudge.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.




Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2010-01-04 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Unreviewed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  1  
 
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * needs_tests:  0 => 1

Comment:

 I fully encourage you to poke around and try and find a solution to this
 problem - but if you're going to provide a patch, you need to provide a
 test case as well. Test cases aren't optional - they're how you prove to
 me (and the rest of the triage and core team) that your patch actually
 fixes the problem you suggest.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.




Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2010-01-04 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Unreviewed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  1 |  
---+
Comment (by plan...@provplan.org):

 I've confirmed that this issue still exists in r12085. I've attached
 another patch that I still assume isn't a proper solution, but it's
 simpler than my original wild guess (and trac parses it correctly now, as
 well). I will continue looking at this bug, but as I think my patch shows,
 I don't fully understand all the internals yet.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.




Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2009-08-21 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Unreviewed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  1 |  
---+
Changes (by anonymous):

  * needs_better_patch:  0 => 1
  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---



Re: [Django] #11722: Query lookups that reference an F() expression produce invalid sql

2009-08-21 Thread Django
#11722: Query lookups that reference an F() expression produce invalid sql
---+
  Reporter:  plan...@provplan.org  | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  SVN
 
Resolution:|  Keywords:  F() 
expression query sql
 Stage:  Unreviewed| Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by plan...@provplan.org):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 I don't have an Oracle installation handy, but this error also happens in
 sqlite3, but not in MySQL. Here is the query produced on sqlite3:

 {{{
 SELECT "app_myobject"."id", "app_myobject"."col1", "app_myobject"."col2"
 FROM "app_myobject" WHERE "app_myobject"."col1" LIKE  ESCAPE \'\\\'
 "app_myobject"."col2"
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---