Re: [Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
+-
   Reporter:  alexr |  Owner:  noah
   Type:  Bug   | Status:  closed
  Milestone:  1.3   |  Component:  ORM aggregation
Version:  1.1   |   Severity:  Normal
 Resolution:  fixed |   Keywords:  aggregates
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  1 |  Easy pickings:  0
+-
Changes (by ramiro):

 * easy:   => 0


Comment:

 Sorry for the error when giving credits in the commit message. Thanks goes
 to noah for providing the patch fixing this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
+---
   Reporter:  alexr |Owner:  noah
   Type:  Bug   |   Status:  closed
  Milestone:  1.3   |Component:  ORM aggregation
Version:  1.1   | Severity:  Normal
 Resolution:  fixed | Keywords:  aggregates
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  1 |
+---
Changes (by ramiro):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [16254]:
 {{{
 #!CommitTicketReference repository="" revision="16254"
 Fixed #11789 -- Fixed aggregates so it interacts with QuerySet none() in a
 way consistent with other empty query sets. Thanks alexr for the report
 and patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
--+-
  Reporter:  alexr| Owner:  noah  
Status:  assigned | Milestone:  1.3   
 Component:  ORM aggregation  |   Version:  1.1   
Resolution:   |  Keywords:  aggregates
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  1|  
--+-
Changes (by mtredinnick):

  * stage:  Design decision needed => Accepted

Comment:

 Russell is questioning the implementation, not the functionality. (I agree
 with no exception -- it's not an error). Moving back to "accepted"

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
-+--
  Reporter:  alexr   | Owner:  noah  
Status:  assigned| Milestone:  1.3   
 Component:  ORM aggregation |   Version:  1.1   
Resolution:  |  Keywords:  aggregates
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  1   |  
-+--
Changes (by russellm):

  * component:  Database layer (models, ORM) => ORM aggregation

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
---+
  Reporter:  alexr | Owner:  noah  
Status:  assigned  | Milestone:  1.3   
 Component:  Database layer (models, ORM)  |   Version:  1.1   
Resolution:|  Keywords:  aggregates
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * stage:  Accepted => Design decision needed
  * milestone:  1.2 => 1.3

Comment:

 I'm not sure I agree that this should raise an exception.
 Author.objects.none() is no different to
 Author.objects.filter(name="something that does not exist"); I don't see
 why the behaviour should be any different.

 Either way, not critical for 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
---+
  Reporter:  alexr | Owner:  noah  
Status:  assigned  | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  1.1   
Resolution:|  Keywords:  aggregates
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by jacob):

  * needs_better_patch:  0 => 1
  * stage:  Ready for checkin => Accepted

Comment:

 I'm not sure that we want aggregates to return `None`; I think aggregates
 on an empty qs should raise an exception: "in the face of ambiguity,
 refuses the temptation to guess." Unless anyone's got a good reason to do
 it like this, let's make `aggregate` raise an exception on the empty set.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
---+
  Reporter:  alexr | Owner:  noah  
Status:  assigned  | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  1.1   
Resolution:|  Keywords:  aggregates
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
---+
  Reporter:  alexr | Owner:  noah  
Status:  assigned  | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  1.1   
Resolution:|  Keywords:  aggregates
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by noah):

  * owner:  nobody => noah
  * status:  new => assigned
  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
---+
  Reporter:  alexr | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  1.1   
Resolution:|  Keywords:  aggregates
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #11789: Aggregates ignore none()

[Django]

#11789: Aggregates ignore none()
--+-
 Reporter:  alexr |   Owner:  nobody
   Status:  new   |   Milestone:
Component:  Database layer (models, ORM)  | Version:  1.1   
 Keywords:  aggregates|   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 {{{
 Model.objects.all().aggregate(Max('field'))
 }}}
 and
 {{{
 Model.objects.none().aggregate(Max('field'))
 }}}
 seem to return the same thing. Aggregates pay attention to filters, but
 they seem to ignore the none() method. This isn't a common use, so it
 might not be worth fixing, except for correctness.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---