Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
-+-
   Reporter: |  Owner:  ruosteinen
  jaklaassen@…   | Status:  closed
   Type:  Bug|  Component:  Database layer
  Milestone:  1.3|  (models, ORM)
Version:  SVN|   Severity:  Normal
 Resolution:  fixed  |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by ramiro):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 I think we can safely close this as fixed in [16522]. Thanks ruosteinen
 and mrmachine.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
-+-
   Reporter: |  Owner:  ruosteinen
  jaklaassen@…   | Status:  assigned
   Type:  Bug|  Component:  Database layer
  Milestone:  1.3|  (models, ORM)
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  0  |
-+-

Comment (by mrmachine):

 I've tried, but can't reproduce a problem with the select/extra tests in
 r16510. Reading the test case, I'm not sure it was valid in the first
 place. It creates 10 `Candy` objects with `qty` of 42, then tests that the
 Sum is 378 - that never would have been correct.

 The issues in the original report have been fixed in [16522]. Although the
 symptoms changed (raising an IndexError instead of returning an empty
 queryset), the fix was the same. I believe the symptoms probably changed
 due to underlying changes in Django since this ticket was reported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
-+-
   Reporter: |  Owner:  ruosteinen
  jaklaassen@…   | Status:  assigned
   Type:  Bug|  Component:  Database layer
  Milestone:  1.3|  (models, ORM)
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by ramiro):

 * ui_ux:   => 0
 * easy:   => 0


Comment:

 See also #16409.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
-+-
   Reporter: |Owner:  ruosteinen
  jaklaassen@…   |   Status:  assigned
   Type:  Bug|Component:  Database layer
  Milestone:  1.3|  (models, ORM)
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  1  |
-+-
Changes (by baumer1122):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
-+-
   Reporter: |Owner:  ruosteinen
  jaklaassen@…   |Milestone:  1.3
 Status:  assigned   |  Version:  SVN
  Component:  Database   | Keywords:
  layer (models, ORM)|Has patch:  1
 Resolution: |  Needs tests:  0
   Triage Stage:  Accepted   |
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-
Changes (by milosu):

 * cc: milos.urbanek@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
+---
   Reporter:  jaklaassen@…  | Owner:  
ruosteinen
 Status:  assigned  | Milestone:  1.3   

  Component:  Database layer (models, ORM)  |   Version:  SVN   

 Resolution:|  Keywords:

   Triage Stage:  Accepted  | Has patch:  1 

Needs documentation:  0 |   Needs tests:  0 

Patch needs improvement:  1 |  
+---

Comment (by ramiro):

 #15523 reported the same problem with slightly different symptoms.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
---+
  Reporter:  jaklaas...@gmail.com  | Owner:  ruosteinen
Status:  assigned  | Milestone:  1.3   
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * milestone:  1.2 => 1.3

Comment:

 Not critical for 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
---+
  Reporter:  jaklaas...@gmail.com  | Owner:  ruosteinen
Status:  assigned  | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ruosteinen):

  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
---+
  Reporter:  jaklaas...@gmail.com  | Owner:  ruosteinen
Status:  new   | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ruosteinen):

  * owner:  nobody => ruosteinen
  * version:  1.1 => SVN

Comment:

 Select fields were getting garbled for only/defer fields as already
 discussed and index offset didn't take into accord the deferred fields.

 Added a regression test as well. (Diffed on revision 12437.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
---+
  Reporter:  jaklaas...@gmail.com  | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #11890: Defer/only + annotate is broken

[Django]

#11890: Defer/only + annotate is broken
--+-
 Reporter:  jaklaas...@gmail.com  |   Owner:  nobody
   Status:  new   |   Milestone:
Component:  Database layer (models, ORM)  | Version:  1.1   
 Keywords:|   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 If you use defer or only + annotate, the ORM returns an empty list.  To
 replicate this:
 {{{
 class Manufacturer(models.Model):
   name = models.CharField(max_length=64)
   country = models.CharField(max_length=32)

 class Car(models.Model):
   manufacturer = models.ForeignKey(Manufacturer, related_name='models')

 >>>Manufacturer.objects.only('name').annotate(Count('models'))
 >>>[]
 }}}


 This is due to a typo in django.db.models.sql.query at line 714.

 The existing code:
 {{{ if table in only_load and col not in only_load[table]: }}}
 should read
 {{{ if table in only_load and column not in only_load[table]:}}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---