Re: [Django] #11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() fails if it's a tuple

2011-04-30 Thread Django
#11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() 
fails
if it's a tuple
-+-
   Reporter: |  Owner:  bendavis78
  bendavis78 | Status:  closed
   Type: |  Component:  Core (Mail)
  Cleanup/optimization   |   Severity:  Normal
  Milestone: |   Keywords:
Version:  SVN|  Has patch:  1
 Resolution:  fixed  |Needs tests:  0
   Triage Stage:  Ready for  |  Easy pickings:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by jezdez):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [16133]:
 {{{
 #!CommitTicketReference repository="" revision="16133"
 Fixed #11928 -- Added test for tuple to list conversion during mail
 message initialization added in r11709. Thanks, Claude Paroz.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() fails if it's a tuple

2011-04-28 Thread Django
#11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() 
fails
if it's a tuple
-+-
   Reporter: |  Owner:  bendavis78
  bendavis78 | Status:  assigned
   Type: |  Component:  Core (Mail)
  Cleanup/optimization   |   Severity:  Normal
  Milestone: |   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Ready for  |  Easy pickings:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by jezdez):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() fails if it's a tuple

2011-04-28 Thread Django
#11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() 
fails
if it's a tuple
-+-
   Reporter: |  Owner:  bendavis78
  bendavis78 | Status:  assigned
   Type: |  Component:  Core (Mail)
  Cleanup/optimization   |   Severity:  Normal
  Milestone: |   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by claudep):

 * keywords:  mail to tuple =>
 * type:  Bug => Cleanup/optimization
 * needs_tests:  1 => 0
 * easy:   => 0


Comment:

 I think that the problem has been fixed by other changesets. However, I
 still attach a test case with recipients as tuples, as I think it was
 still untested.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() fails if it's a tuple

2009-09-23 Thread Django
#11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() 
fails
if it's a tuple
---+
  Reporter:  bendavis78| Owner:  bendavis78   
Status:  assigned  | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  mail to tuple
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  1
Needs_better_patch:  0 |  
---+
Changes (by SmileyChris):

  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---



Re: [Django] #11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() fails if it's a tuple

2009-09-22 Thread Django
#11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() 
fails
if it's a tuple
---+
  Reporter:  bendavis78| Owner:  bendavis78   
Status:  assigned  | Milestone:   
 Component:  django.core.mail  |   Version:  SVN  
Resolution:|  Keywords:  mail to tuple
 Stage:  Unreviewed| Has_patch:  1
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  0 |  
---+
Changes (by bendavis78):

  * owner:  nobody => bendavis78
  * needs_better_patch:  => 0
  * status:  new => assigned
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---



[Django] #11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() fails if it's a tuple

2009-09-22 Thread Django
#11928: EmailMessage.to accepts tuple or list, but EmailMessage.recipients() 
fails
if it's a tuple
--+-
 Reporter:  bendavis78|   Owner:  nobody
   Status:  new   |   Milestone:
Component:  django.core.mail  | Version:  SVN   
 Keywords:  mail to tuple |   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 Basically, if you set "to" to a tuple, the recipients() method fails
 because it's concatenating self.to + self.bcc,  and bcc by default is [].
 So if self.to is a tuple, you get an exception. The simple fix is:
 {{{
 Index: django/core/mail.py
 ===
 --- django/core/mail.py (revision 11587)
 +++ django/core/mail.py (working copy)
 @@ -255,7 +255,7 @@
  Returns a list of all recipients of the email (includes direct
  addressees as well as Bcc entries).
  """
 -return self.to + self.bcc
 +return list(self.to) + list(self.bcc)

  def send(self, fail_silently=False):
  """Sends the email message."""
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---