Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
--+
 Reporter:  ejucovy   |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by ejucovy):

 * ui_ux:   => 0


Comment:

 I updated the patch to make sure it applies cleanly (and tests pass) on
 the current trunk@HEAD
 (https://code.djangoproject.com/attachment/ticket/12103/12103_at_r17205.diff)
 -- any chance this can be merged in before the 1.4 release?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
---+--
   Reporter:  ejucovy  |  Owner:  nobody
   Type:  New feature  | Status:  new
  Milestone:   |  Component:  contrib.auth
Version:  SVN  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
---+--
Changes (by ejucovy):

 * version:  1.1 => SVN
 * type:  Uncategorized => New feature
 * easy:   => 0


Comment:

 I realized the tests in my patch could be improved; here's a new version
 of the patch:

 
http://code.djangoproject.com/attachment/ticket/12103/12103_with_better_working_tests.diff

 The tests now exercise/document custom `ValidationError` logic in an
 `AuthenticationForm` subclass, in addition to logic that disables the
 default `user.is_inactive` check.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-+
   Reporter:  ejucovy|Owner:  nobody
   Type:  Uncategorized  |   Status:  new
  Milestone: |Component:  contrib.auth
Version:  1.1| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+
Changes (by ejucovy):

 * needs_better_patch:  1 => 0
 * type:   => Uncategorized
 * severity:   => Normal


Comment:

 Oops.  Let's try that again.  The `auth` tests pass for me with this
 patch:
 
http://code.djangoproject.com/attachment/ticket/12103/12103_with_working_tests.diff

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
--+-
   Reporter:  ejucovy | Owner:  nobody
 Status:  new | Milestone:
  Component:  Authentication  |   Version:  1.1   
 Resolution:  |  Keywords:
   Triage Stage:  Accepted| Has patch:  1 
Needs documentation:  0   |   Needs tests:  0 
Patch needs improvement:  1   |  
--+-
Changes (by lrekucki):

  * needs_better_patch:  0 => 1


Comment:

 Did you actually run the tests? By the look of the patch they aren't even
 syntacticly correct.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
--+-
   Reporter:  ejucovy | Owner:  nobody
 Status:  new | Milestone:
  Component:  Authentication  |   Version:  1.1   
 Resolution:  |  Keywords:
   Triage Stage:  Accepted| Has patch:  1 
Needs documentation:  0   |   Needs tests:  0 
Patch needs improvement:  0   |  
--+-
Changes (by ejucovy):

  * needs_better_patch:  1 => 0


Comment:

 I've added a new version of the patch
 [http://code.djangoproject.com/attachment/ticket/12103/12103_with_tests.diff
 12103_with_tests.diff] -- which includes lasko's tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-+--
  Reporter:  ejucovy | Owner:  nobody
Status:  new | Milestone:
 Component:  Authentication  |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  1   |  
-+--
Changes (by lasko):

 * cc: bmhei...@gmail.com (added)
  * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-+--
  Reporter:  ejucovy | Owner:  nobody
Status:  new | Milestone:
 Component:  Authentication  |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  1 
Needs_better_patch:  1   |  
-+--
Comment (by lasko):

 No problem ejucovy, I do however have one concern here with regards to
 your patch.

 Line 83:

 {{{
 self.confirm_login_allowed(user_cache)
 }}}

 This is a pretty obvious NameError waiting to happen as user_cache is
 never defined and should be self.user_cache
 Once this is fixed the patch looks decent. I'll start working on the tests

 Replying to [comment:6 ejucovy]:
 > Replying to [comment:5 lasko]:
 > > I don't see anything wrong with this implementation and would be +1 to
 implementing it.
 > > Would allow me to get rid of my current kluge in making this
 functionality work and have a standard django supported interface.
 > >
 > > This however still needs tests added to it. If ejucovy doesn't wish to
 do this part I can probably put something together in that realm.
 >
 > Thanks, I'd appreciate that!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-+--
  Reporter:  ejucovy | Owner:  nobody
Status:  new | Milestone:
 Component:  Authentication  |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  1 
Needs_better_patch:  1   |  
-+--
Comment (by ejucovy):

 Replying to [comment:5 lasko]:
 > I don't see anything wrong with this implementation and would be +1 to
 implementing it.
 > Would allow me to get rid of my current kluge in making this
 functionality work and have a standard django supported interface.
 >
 > This however still needs tests added to it. If ejucovy doesn't wish to
 do this part I can probably put something together in that realm.

 Thanks, I'd appreciate that!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-+--
  Reporter:  ejucovy | Owner:  nobody
Status:  new | Milestone:
 Component:  Authentication  |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  1 
Needs_better_patch:  1   |  
-+--
Changes (by lasko):

  * needs_docs:  1 => 0

Comment:

 I don't see anything wrong with this implementation and would be +1 to
 implementing it.
 Would allow me to get rid of my current kluge in making this functionality
 work and have a standard django supported interface.

 This however still needs tests added to it. If ejucovy doesn't wish to do
 this part I can probably put something together in that realm.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-+--
  Reporter:  ejucovy | Owner:  nobody
Status:  new | Milestone:
 Component:  Authentication  |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  1 
Needs_better_patch:  1   |  
-+--
Changes (by ejucovy):

 * cc: ethan.juc...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-+--
  Reporter:  ejucovy | Owner:  nobody
Status:  new | Milestone:
 Component:  Authentication  |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  1 
Needs_better_patch:  1   |  
-+--
Changes (by russellm):

  * needs_better_patch:  0 => 1
  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

Comment:

 I don't see any problem with the idea of configuring the ability to allow
 or reject logins on the basis of some check other than 'is_active', but it
 should be in the form of a method that can be overridden on a subclass.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-+--
  Reporter:  ejucovy | Owner:  nobody
Status:  new | Milestone:
 Component:  Authentication  |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by ejucovy):

 I added a documentation patch.  It's more verbose than I'd like.

 While doing this I noticed that the `AuthenticationForm`'s behavior re:
 inactive users is undocumented, and the documentation for `User.is_active`
 is misleading.  I filed #12113 about that.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
-+--
  Reporter:  ejucovy | Owner:  nobody
Status:  new | Milestone:
 Component:  Authentication  |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by ejucovy):

  * needs_better_patch:  => 0
  * has_patch:  0 => 1
  * needs_tests:  => 0
  * needs_docs:  => 1

Comment:

 Here's a simple patch to show what I'm imagining.

 I'll also try to figure out how/where best to document this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #12103: Setting in contrib.auth AuthenticationForm to let inactive users log in

[Django]

#12103: Setting in contrib.auth AuthenticationForm to let inactive users log in
+---
 Reporter:  ejucovy |   Owner:  nobody
   Status:  new |   Milestone:
Component:  Authentication  | Version:  1.1   
 Keywords:  |   Stage:  Unreviewed
Has_patch:  0   |  
+---
 I've built a site that uses django-registration to manage user account
 creation. I allow inactive users to log in, with minimal functionality: I
 use middleware to kick them to a page that reminds them to confirm their
 account.

 To do this, I copied the whole `AuthenticationForm.clean()` method from
 `django.contrib.auth.forms` to my custom authentication_form, and removed
 two lines:
 {{{
   elif not self.user_cache.is_active:
 raise forms.ValidationError(_("This account is inactive."))
 }}}

 From my code's perspective, it would be nicer if the base
 `AuthenticationForm` had a class-level setting to toggle whether this
 check happens. Then all I would have to do is subclass the form with an
 override, like
 {{{
 class MyAuthenticationForm(AuthenticationForm):
   allow_inactive_logins = True
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---