Re: [Django] #12140: urlencode empty list encoding bug & fix

2012-06-14 Thread Django 
#12140: urlencode empty list encoding bug & fix
---+
 Reporter:  aneil  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  HTTP handling  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  urlencode  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [fe873e276527534b3c0c22f457ee314cf029ced4]:
 {{{
 #!CommitTicketReference repository=""
 revision="fe873e276527534b3c0c22f457ee314cf029ced4"
 Fixed #12140 -- Fixed http.urlencode result for empty lists

 Thanks aneil for the report and the initial patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12140: urlencode empty list encoding bug & fix

2012-03-26 Thread Django 
#12140: urlencode empty list encoding bug & fix
---+
 Reporter:  aneil  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords:  urlencode  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12140: urlencode empty list encoding bug & fix

2011-04-16 Thread Django 
#12140: urlencode empty list encoding bug & fix
+-
   Reporter:  aneil |Owner:  nobody
   Type:  Bug   |   Status:  new
  Milestone:|Component:  HTTP handling
Version:  SVN   | Severity:  Normal
 Resolution:| Keywords:  urlencode
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  1 |
+-

Old description:

> django.utils.http.urlencode doesn't behave the same as urllib.urlencode
> for empty lists:
>
> urllib.urlencode({'foo':[]},True) => ''
>
> django.utils.http.urlencode({'foo':[]},True) => 'foo=%5B%5D'
>
> The attached diff has a change at line 557 in trunk/django/utils/http.py:
> - isinstance(v, (list,tuple)) and [smart_str(i) for i in v] or
> smart_str(v))
> + [smart_str(i) for i in v] if isinstance(v, (list,tuple)) else
> smart_str(v))
>
> Attached.

New description:

 `django.utils.http.urlencode` doesn't behave the same as urllib.urlencode
 for empty lists:

 `urllib.urlencode({'foo':[]},True) => ''`

 `django.utils.http.urlencode({'foo':[]},True) => 'foo=%5B%5D'`

 The attached diff has a change at line 557 in trunk/django/utils/http.py:
 {{{
 - isinstance(v, (list,tuple)) and [smart_str(i) for i in v] or
 smart_str(v))
 + [smart_str(i) for i in v] if isinstance(v, (list,tuple)) else
 smart_str(v))
 }}}

 Attached.

--

Comment (by julien):

 Reformatted description.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12140: urlencode empty list encoding bug & fix

2011-04-16 Thread Django 
#12140: urlencode empty list encoding bug & fix
+-
   Reporter:  aneil |Owner:  nobody
   Type:  Bug   |   Status:  new
  Milestone:|Component:  HTTP handling
Version:  SVN   | Severity:  Normal
 Resolution:| Keywords:  urlencode
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  1 |
+-
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 The tests would need to be rewritten using unittests since this is now
 Django's preferred way.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12140: urlencode empty list encoding bug & fix

2011-04-01 Thread Django 
#12140: urlencode empty list encoding bug & fix
+-
   Reporter:  aneil |Owner:  nobody
   Type:  Bug   |   Status:  new
  Milestone:|Component:  HTTP handling
Version:  SVN   | Severity:  Normal
 Resolution:| Keywords:  urlencode
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  0 |
+-
Changes (by mattmcc):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12140: urlencode empty list encoding bug & fix

2010-02-05 Thread Django 
#12140: urlencode empty list encoding bug & fix
+---
  Reporter:  aneil  | Owner:  nobody   
Status:  new| Milestone:   
 Component:  HTTP handling  |   Version:  1.1  
Resolution: |  Keywords:  urlencode
 Stage:  Accepted   | Has_patch:  1
Needs_docs:  0  |   Needs_tests:  1
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12140: urlencode empty list encoding bug & fix

2009-11-03 Thread Django 
#12140: urlencode empty list encoding bug & fix
+---
  Reporter:  aneil  | Owner:  nobody   
Status:  new| Milestone:   
 Component:  HTTP handling  |   Version:  1.1  
Resolution: |  Keywords:  urlencode
 Stage:  Unreviewed | Has_patch:  1
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Changes (by aneil):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Change is at line 41, not line 557.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #12140: urlencode empty list encoding bug & fix

2009-11-03 Thread Django 
#12140: urlencode empty list encoding bug & fix
---+
 Reporter:  aneil  |   Owner:  nobody
   Status:  new|   Milestone:
Component:  HTTP handling  | Version:  1.1   
 Keywords:  urlencode  |   Stage:  Unreviewed
Has_patch:  1  |  
---+
 django.utils.http.urlencode doesn't behave the same as urllib.urlencode
 for empty lists:

 urllib.urlencode({'foo':[]},True) => ''

 django.utils.http.urlencode({'foo':[]},True) => 'foo=%5B%5D'

 The attached diff has a change at line 557 in trunk/django/utils/http.py:
 - isinstance(v, (list,tuple)) and [smart_str(i) for i in v] or
 smart_str(v))
 + [smart_str(i) for i in v] if isinstance(v, (list,tuple)) else
 smart_str(v))

 Attached.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---