Re: [Django] #12183: urlize doesn't always add rel=nofollow

[Django]

#12183: urlize doesn't always add rel=nofollow
-+
 Reporter:  eronen   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Template system  |  Version:  1.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17356]:
 {{{
 #!CommitTicketReference repository="" revision="17356"
 Fixed #12183 -- Made the urlize filter insert the nofollow attribute
 properly when an http: URL occurs after a mailto: URL. Thanks eronen for
 the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12183: urlize doesn't always add rel=nofollow

[Django]

#12183: urlize doesn't always add rel=nofollow
+-
   Reporter:  eronen|  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Template system
Version:  1.1   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+-
Changes (by anonymous):

 * has_patch:  1 => 0
 * ui_ux:   => 0
 * easy:   => 0


Comment:

 the patch for #11911 has been properly factored, a patch for this issue
 needs to be specifically attached

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12183: urlize doesn't always add rel=nofollow

[Django]

#12183: urlize doesn't always add rel=nofollow
+---
   Reporter:  eronen|Owner:  nobody
   Type:  Bug   |   Status:  new
  Milestone:|Component:  Template system
Version:  1.1   | Severity:  Normal
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  0 |
+---
Changes (by mattmcc):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12183: urlize doesn't always add rel=nofollow

[Django]

#12183: urlize doesn't always add rel=nofollow
--+-
  Reporter:  eronen   | Owner:  nobody
Status:  new  | Milestone:
 Component:  Template system  |   Version:  1.1   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by morty):

 Sorry that should have been ticket #11911.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12183: urlize doesn't always add rel=nofollow

[Django]

#12183: urlize doesn't always add rel=nofollow
--+-
  Reporter:  eronen   | Owner:  nobody
Status:  new  | Milestone:
 Component:  Template system  |   Version:  1.1   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by morty):

  * needs_tests:  1 => 0

Comment:

 I have attached joint test and fix patches for this bug to ticket #119911.
 I won't upload them again here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12183: urlize doesn't always add rel=nofollow

[Django]

#12183: urlize doesn't always add rel=nofollow
--+-
  Reporter:  eronen   | Owner:  nobody
Status:  new  | Milestone:
 Component:  Template system  |   Version:  1.1   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 1
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #12183: urlize doesn't always add rel=nofollow

[Django]

#12183: urlize doesn't always add rel=nofollow
-+--
 Reporter:  eronen   |   Owner:  nobody
   Status:  new  |   Milestone:
Component:  Template system  | Version:  1.1   
 Keywords:   |   Stage:  Unreviewed
Has_patch:  1|  
-+--
 If the text passed to "urlize" template filter or django.utils.html.urlize
 contains multiple URLs,
 and one of them is a mailto: URL, then the URLs after the mailto URL will
 not have rel=nofollow even
 when you called urlize with nofollow=True.

 Fix: Move the line "nofollow_attr = nofollow and ' rel="nofollow"' or ''"
 inside the
 for loop (one line downwards)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---