Re: [Django] #12325: [PATCH]Allow zero moderate_after time

[Django]

#12325: [PATCH]Allow zero moderate_after time
--+-
  Reporter:  zhigang  | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.comments  |   Version:  1.1   
Resolution:   |  Keywords:  moderation
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Comment (by eternicode):

 Ah, ok, I see them now.  Didn't think to look there for them, thanks for
 the pointer.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12325: [PATCH]Allow zero moderate_after time

[Django]

#12325: [PATCH]Allow zero moderate_after time
--+-
  Reporter:  zhigang  | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.comments  |   Version:  1.1   
Resolution:   |  Keywords:  moderation
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Comment (by russellm):

 The comment app does have tests; for historical reasons, they're not under
 contrib.comments; they're in the regressiontests directory, under
 comments_tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12325: [PATCH]Allow zero moderate_after time

[Django]

#12325: [PATCH]Allow zero moderate_after time
--+-
  Reporter:  zhigang  | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.comments  |   Version:  1.1   
Resolution:   |  Keywords:  moderation
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Changes (by eternicode):

 * cc: and...@eternicode.com (added)

Comment:

 Where should tests for this patch go, and what approach should be used for
 them?

 The comments app currently doesn't have *any* tests, and I think this is
 understandable (not good, just understandable), because the various
 aspects of the app depend on subclassing (for custom moderation) and other
 models (for normal commenting).


 At any rate, an alternative workaround to using a negative number is to
 specify a very small number, such as one second:

 {{{
 class MyModerator(CommentModerator):
 auto_moderate_field = 'moderate_after'
 moderate_after = 1.0/86400 # 1 out of the 86,400 seconds in a day
 }}}

 Not as clean as "0", but it's effectively the same and will work until
 this patch is checked in.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12325: [PATCH]Allow zero moderate_after time

[Django]

#12325: [PATCH]Allow zero moderate_after time
--+-
  Reporter:  zhigang  | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.comments  |   Version:  1.1   
Resolution:   |  Keywords:  moderation
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 1
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #12325: [PATCH]Allow zero moderate_after time

[Django]

#12325: [PATCH]Allow zero moderate_after time
-+--
 Reporter:  zhigang  |   Owner:  nobody
   Status:  new  |   Milestone:
Component:  django.contrib.comments  | Version:  1.1   
 Keywords:  moderation   |   Stage:  Unreviewed
Has_patch:  1|  
-+--
 In the current implement, if we want all comments go to approval queue
 just after a entry is published, you should assign moderate_after a value
 < 0. But moderate_after = 0 makes more sense. This patch allows this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.