Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8
---+
Reporter: simonb |Owner: ramiro
Type: Bug| Status: closed
Component: Core (Mail)| Version: master
Severity: Normal | Resolution: fixed
Keywords: charset utf-8 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 |UI/UX: 0
---+
Comment (by Andrew Godwin <andrew@…>):
In [changeset:"8e571e5f8f21d87ab5a5462730289c755b8022d3"]:
{{{
#!CommitTicketReference repository=""
revision="8e571e5f8f21d87ab5a5462730289c755b8022d3"
Fixed #12422 -- Don't override global email charset behavior for utf-8.
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.c79302a51bea8788dd773935d99f1b77%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8
---+
Reporter: simonb |Owner: ramiro
Type: Bug| Status: closed
Component: Core (Mail)| Version: master
Severity: Normal | Resolution: fixed
Keywords: charset utf-8 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 |UI/UX: 0
---+
Changes (by Ramiro Morales <cramm0@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"ececbe77ff573707d8f25084018e66ee07f820fd"]:
{{{
#!CommitTicketReference repository=""
revision="ececbe77ff573707d8f25084018e66ee07f820fd"
Fixed #12422 -- Don't override global email charset behavior for utf-8.
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.0e8983975b474aaf527c729ff76c7190%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8 ---+ Reporter: simonb |Owner: ramiro Type: Bug| Status: assigned Component: Core (Mail)| Version: master Severity: Normal | Resolution: Keywords: charset utf-8 | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 1 Easy pickings: 0 |UI/UX: 0 ---+ Comment (by ramiro): This is the PR: https://github.com/django/django/pull/1489 -- Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:13> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.3b010e685fad01353d58a52a36d63f0f%40djangoproject.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8
---+
Reporter: simonb |Owner: ramiro
Type: Bug| Status: assigned
Component: Core (Mail)| Version: master
Severity: Normal | Resolution:
Keywords: charset utf-8 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 |UI/UX: 0
---+
Changes (by ramiro):
* owner: susan => ramiro
Comment:
Actually, the proposed patch tests fail with Python 3.3. Tests pases for
3.2.x.
The pre-3.3.0 Python commit where things break is:
{{{
changeset: 75893:9ceac471bd8c
user:R David Murray <rdmur...@bitdance.com>
date:Thu Mar 22 22:40:44 2012 -0400
summary: #14380: Make actual default match docs, fix __init__ order.
}}}
See:
- http://bugs.python.org/issue14380
- http://hg.python.org/cpython/rev/9ceac471bd8c
Thank you very much to all individuals that have worked on this so far. I
have a fix ready for review, will open a PR soon and post a link here so
you can review it.
--
Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.4ef6354637c6482280fda282ad861c10%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8 ---+ Reporter: simonb |Owner: susan Type: Bug| Status: assigned Component: Core (Mail)| Version: master Severity: Normal | Resolution: Keywords: charset utf-8 | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 1 Easy pickings: 0 |UI/UX: 0 ---+ Changes (by ptone): * needs_better_patch: 0 => 1 * version: 1.1 => master Comment: Unfortunately the email tests have multiple failures under Python3 with this patch applied - I did not investigate the causes. -- Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:11> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.378fe7054f241329b6b52a2ac03955bb%40djangoproject.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8 ---+ Reporter: simonb |Owner: susan Type: Bug| Status: assigned Component: Core (Mail)| Version: 1.1 Severity: Normal | Resolution: Keywords: charset utf-8 | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 |UI/UX: 0 ---+ Changes (by susan): * owner: nobody => susan * status: new => assigned -- Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:10> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.dfeacdadb6e82cdb1234ca3749723fae%40djangoproject.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8 ---+ Reporter: simonb |Owner: nobody Type: Bug| Status: new Component: Core (Mail)| Version: 1.1 Severity: Normal | Resolution: Keywords: charset utf-8 | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 |UI/UX: 0 ---+ Comment (by anonymous): Tests pass. I made a PR to make it easier to merge into master. https://github.com/django/django/pull/1376/files -- Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:9> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.da15625bd6c22fe156e60dec0617c954%40djangoproject.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8 ---+ Reporter: simonb |Owner: nobody Type: Bug| Status: new Component: Core (Mail)| Version: 1.1 Severity: Normal | Resolution: Keywords: charset utf-8 | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 |UI/UX: 0 ---+ Changes (by claudep): * has_patch: 0 => 1 Comment: Patch attached. Tests changes are only the different order of headers, nothing significant. -- Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:8> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8 ---+ Reporter: simonb |Owner: nobody Type: Bug| Status: new Component: Core (Mail)| Version: 1.1 Severity: Normal | Resolution: Keywords: charset utf-8 | Triage Stage: Accepted Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 |UI/UX: 0 ---+ Comment (by aaugustin): This also caused me a lot of trouble when I was writing a patch for #18916. -- Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:7> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8
---+
Reporter: simonb |Owner: nobody
Type: Bug| Status: new
Component: Core (Mail)| Version: 1.1
Severity: Normal | Resolution:
Keywords: charset utf-8 | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 |UI/UX: 0
---+
Description changed by aaugustin:
Old description:
> # Don't BASE64-encode UTF-8 messages so that we avoid unwanted attention
> from
> # some spam filters.
> Charset.add_charset('utf-8', Charset.SHORTEST, Charset.QP, 'utf-8')
>
> The above bit of code in django.core.mail overrides the standard Python
> behaviour for utf-8 in the Python email module. It would be better to set
> the charset by calling set_charset() on the Message before sending if
> needed rather than a global override. This behaviour and assumption is
> not documented anywhere in Django as far as I can tell. I think this is a
> case of the framework being a bit too clever. Not everyone using Django
> is using the django email sending methods nor wants Django to (silently)
> change the system defaults.
>
> For example, I use the standard Python email sending methods and was
> expecting the Python lib to behave as advertised but the encoding of my
> utf-8 messages kept coming out quoted-printable because of the override
> above.
New description:
{{{
# Don't BASE64-encode UTF-8 messages so that we avoid unwanted attention
from
# some spam filters.
Charset.add_charset('utf-8', Charset.SHORTEST, Charset.QP, 'utf-8')
}}}
The above bit of code in django.core.mail overrides the standard Python
behaviour for utf-8 in the Python email module. It would be better to set
the charset by calling set_charset() on the Message before sending if
needed rather than a global override. This behaviour and assumption is not
documented anywhere in Django as far as I can tell. I think this is a case
of the framework being a bit too clever. Not everyone using Django is
using the django email sending methods nor wants Django to (silently)
change the system defaults.
For example, I use the standard Python email sending methods and was
expecting the Python lib to behave as advertised but the encoding of my
utf-8 messages kept coming out quoted-printable because of the override
above.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/12422#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8 +- Reporter: simonb|Owner: nobody Type: Bug | Status: new Milestone:|Component: Core (Mail) Version: 1.1 | Severity: Normal Resolution:| Keywords: charset utf-8 Triage Stage: Accepted |Has patch: 0 Needs documentation: 0 | Needs tests: 0 Patch needs improvement: 0 | +- Changes (by mattmcc): * type: => Bug * severity: => Normal -- Ticket URL: <http://code.djangoproject.com/ticket/12422#comment:3> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8 ---+ Reporter: simonb| Owner: nobody Status: new | Milestone: Component: django.core.mail | Version: 1.1 Resolution:| Keywords: charset utf-8 Stage: Accepted | Has_patch: 0 Needs_docs: 0 | Needs_tests: 0 Needs_better_patch: 0 | ---+ Changes (by simonb): * cc: bno...@gmail.com (added) -- Ticket URL: <http://code.djangoproject.com/ticket/12422#comment:2> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-upda...@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.
Re: [Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8 ---+ Reporter: simonb| Owner: nobody Status: new | Milestone: Component: django.core.mail | Version: 1.1 Resolution:| Keywords: charset utf-8 Stage: Accepted | Has_patch: 0 Needs_docs: 0 | Needs_tests: 0 Needs_better_patch: 0 | ---+ Changes (by russellm): * needs_better_patch: => 0 * stage: Unreviewed => Accepted * needs_tests: => 0 * needs_docs: => 0 -- Ticket URL: <http://code.djangoproject.com/ticket/12422#comment:1> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-upda...@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.
[Django] #12422: Django overrides the default email charset behaviour for utf-8
#12422: Django overrides the default email charset behaviour for utf-8
--+-
Reporter: simonb| Owner: nobody
Status: new | Milestone:
Component: django.core.mail | Version: 1.1
Keywords: charset utf-8 | Stage: Unreviewed
Has_patch: 0 |
--+-
# Don't BASE64-encode UTF-8 messages so that we avoid unwanted attention
from
# some spam filters.
Charset.add_charset('utf-8', Charset.SHORTEST, Charset.QP, 'utf-8')
The above bit of code in django.core.mail overrides the standard Python
behaviour for utf-8 in the Python email module. It would be better to set
the charset by calling set_charset() on the Message before sending if
needed rather than a global override. This behaviour and assumption is not
documented anywhere in Django as far as I can tell. I think this is a case
of the framework being a bit too clever. Not everyone using Django is
using the django email sending methods nor wants Django to (silently)
change the system defaults.
For example, I use the standard Python email sending methods and was
expecting the Python lib to behave as advertised but the encoding of my
utf-8 messages kept coming out quoted-printable because of the override
above.
--
Ticket URL: <http://code.djangoproject.com/ticket/12422>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
