Re: [Django] #12493: settings.configure silently allows TEMPLATE_DIRS configuration error

[Django]

#12493: settings.configure silently allows TEMPLATE_DIRS configuration error
--+
 Reporter:  mckoss|Owner:  gwilson
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Core (Other)  |  Version:  1.1
 Severity:  Normal|   Resolution:  fixed
 Keywords:  settings, templates   | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Ramiro Morales ):

 In [changeset:"64cdea68e71829905da6374a066d1700375255ec"]:
 {{{
 #!CommitTicketReference repository=""
 revision="64cdea68e71829905da6374a066d1700375255ec"
 Report wrongly-typed settings and abort, as originally planned.

 Thanks Claude for the heads up. Refs #12493 and commit 5e08b792.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bc338bf905d0ba67073a837ba8efa57d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12493: settings.configure silently allows TEMPLATE_DIRS configuration error

[Django]

#12493: settings.configure silently allows TEMPLATE_DIRS configuration error
--+
 Reporter:  mckoss|Owner:  gwilson
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Core (Other)  |  Version:  1.1
 Severity:  Normal|   Resolution:  fixed
 Keywords:  settings, templates   | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Claude Paroz ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [db87016b1a92b790c4250a2b5c16ceadd737a00e]:
 {{{
 #!CommitTicketReference repository=""
 revision="db87016b1a92b790c4250a2b5c16ceadd737a00e"
 Fixed #12493 -- Deprecated auto-correction of TEMPLATE_DIRS
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12493: settings.configure silently allows TEMPLATE_DIRS configuration error

[Django]

#12493: settings.configure silently allows TEMPLATE_DIRS configuration error
--+
 Reporter:  mckoss|Owner:  gwilson
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (Other)  |  Version:  1.1
 Severity:  Normal|   Resolution:
 Keywords:  settings, templates   | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by aaugustin):

 * stage:  Design decision needed => Accepted


Comment:

 Accepting as explained by gwilson. We'll need a deprecation path for the
 switch from auto-correcting to raising an exception.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12493: settings.configure silently allows TEMPLATE_DIRS configuration error

[Django]

#12493: settings.configure silently allows TEMPLATE_DIRS configuration error
-+-
   Reporter:  mckoss |  Owner:  gwilson
   Type: | Status:  assigned
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.1|   Keywords:  settings, templates
 Resolution: |  Has patch:  0
   Triage Stage:  Design |Needs tests:  0
  decision needed|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by gwilson):

 * status:  new => assigned
 * owner:  nobody => gwilson
 * ui_ux:   => 0
 * easy:   => 0


Comment:

 Also agree that this should be raising an error instead of auto-
 correcting, and should perhaps be considered for removal.  However, the
 fact remains that this is a bug since the behavior using
 `settings.configure()` is not the same as the standard behavior.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12493: settings.configure silently allows TEMPLATE_DIRS configuration error

[Django]

#12493: settings.configure silently allows TEMPLATE_DIRS configuration error
-+--
  Reporter:  mckoss  | Owner:  nobody   
  
Status:  new | Milestone:   
  
 Component:  Core framework  |   Version:  1.1  
  
Resolution:  |  Keywords:  settings, 
templates
 Stage:  Design decision needed  | Has_patch:  0
  
Needs_docs:  0   |   Needs_tests:  0
  
Needs_better_patch:  0   |  
-+--
Comment (by lukeplant):

 I agree with Alex - fixing them automatically is pretty nasty, because it
 means that developer is not alerted about their error.  If they set
 `TEMPLATE_DIRS` incorrectly in their settings.py, and use the value
 somewhere else (e.g. as part of another setting, or in some other code),
 the possible consequences violate the principle of least astonishment.
 Throwing a validation error would have been much better IMO.

 I'm also not convinced the error is that inscrutable.  In the normal case,
 you get a debug page with the error `TemplateDoesNotExist`.  The
 `TEMPLATE_DIRS` setting, which is the obvious thing to check, is displayed
 at the bottom of the page, and will show a single string — and I think it
 ought to be fairly obvious from the plural name `TEMPLATE_DIRS` that the
 setting should be an iterable of some kind.

 In the context of a settings file, you are dealing with people who might
 not know Python, and the need for the trailing comma in a one-tuple is
 quite an obscure syntax point to expect non-Python developers to know.
 That argument isn't so strong for normal Python code.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12493: settings.configure silently allows TEMPLATE_DIRS configuration error

[Django]

#12493: settings.configure silently allows TEMPLATE_DIRS configuration error
-+--
  Reporter:  mckoss  | Owner:  nobody   
  
Status:  new | Milestone:   
  
 Component:  Core framework  |   Version:  1.1  
  
Resolution:  |  Keywords:  settings, 
templates
 Stage:  Design decision needed  | Has_patch:  0
  
Needs_docs:  0   |   Needs_tests:  0
  
Needs_better_patch:  0   |  
-+--
Comment (by Alex):

 Ugh, I'm opposed to magically fixing those settings as it is now,
 obviously we can't undo those (yay backwards compatibility), but I don't
 like extending them further.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12493: settings.configure silently allows TEMPLATE_DIRS configuration error

[Django]

#12493: settings.configure silently allows TEMPLATE_DIRS configuration error
-+--
  Reporter:  mckoss  | Owner:  nobody   
  
Status:  new | Milestone:   
  
 Component:  Core framework  |   Version:  1.1  
  
Resolution:  |  Keywords:  settings, 
templates
 Stage:  Design decision needed  | Has_patch:  0
  
Needs_docs:  0   |   Needs_tests:  0
  
Needs_better_patch:  0   |  
-+--
Changes (by ramiro):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Design decision needed
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 A workaround for this kind of user errors is already present since r213
 for the case of settings read from a settings module. Should something
 similar also be done for the `settings.configure()` caseor can we close
 this assuming the user using such advanced scheme should make sure to read
 the relevant setting [http://docs.djangoproject.com/en/dev/ref/settings
 /#template-dirs documentation]?. Setting triage status to 'Design decision
 needed'.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #12493: settings.configure silently allows TEMPLATE_DIRS configuration error

[Django]

#12493: settings.configure silently allows TEMPLATE_DIRS configuration error
-+--
 Reporter:  mckoss   |   Owner:  nobody
   Status:  new  |   Milestone:
Component:  Core framework   | Version:  1.1   
 Keywords:  settings, templates  |   Stage:  Unreviewed
Has_patch:  0|  
-+--
 settings.configure(TEMPLATE_DIRS="/path/to/a/single/dir")

 Result:
 Silently accepted, even though the code is expecting an array of path
 strings.

 Expect:
Either a) generate an error message when invalid settings are set, or
 b) allow this setting to be either a single directory OR a sequence
of directories.

 Note that configuration errors like this can be very painful to track down
 - as the site of the error is quite far from the results (in this case,
 the template system is unable to find the file ... but there is no
 indication as to why that is the case w/o debugging the Django sources -
 which is what I did finally to figure out my mistake).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.