Re: [Django] #12571: Test client doesn't set WSGIRequest instance on response

[Django]

#12571: Test client doesn't set WSGIRequest instance on response
-+-
 Reporter:  rvdrijst |Owner:
 Type:  Bug  |  unaizalakain
Component:  Testing framework|   Status:  closed
 Severity:  Normal   |  Version:  master
 Keywords:  test client request  |   Resolution:  fixed
  response WSGIRequest   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9eb16031ca837624433c49646289b50f9566a25d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9eb16031ca837624433c49646289b50f9566a25d"
 Fixed #12571 -- Attached originating WSGIRequest to test client responses.

 Originating WSGIRequests are now attached to the ``wsgi_request``
 attribute of
 the ``HttpResponse`` returned by the testing client.

 Thanks rvdrijst for the suggestion.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.6e335400ed2b3d903aef0f53552640d8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12571: Test client doesn't set WSGIRequest instance on response

[Django]

#12571: Test client doesn't set WSGIRequest instance on response
-+-
 Reporter:  rvdrijst |Owner:
 Type:  Bug  |  unaizalakain
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  test client request  |   Resolution:
  response WSGIRequest   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by timo):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2d28169e8161ff9a864715901b86335e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12571: Test client doesn't set WSGIRequest instance on response

[Django]

#12571: Test client doesn't set WSGIRequest instance on response
-+-
 Reporter:  rvdrijst |Owner:
 Type:  Bug  |  unaizalakain
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  test client request  |   Resolution:
  response WSGIRequest   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by unaizalakain):

 * needs_docs:  1 => 0
 * version:   => master
 * needs_tests:  1 => 0


Comment:

 PR sent: https://github.com/django/django/pull/1942

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b4e102cdd361fa3965dba0ab7393a604%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12571: Test client doesn't set WSGIRequest instance on response

[Django]

#12571: Test client doesn't set WSGIRequest instance on response
-+-
 Reporter:  rvdrijst |Owner:
 Type:  Bug  |  unaizalakain
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:
 Keywords:  test client request  |   Resolution:
  response WSGIRequest   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by unaizalakain):

 * owner:  nobody => unaizalakain
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5f69b81b529345612b00407d62ac8ed1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12571: Test client doesn't set WSGIRequest instance on response

[Django]

#12571: Test client doesn't set WSGIRequest instance on response
-+-
 Reporter:  rvdrijst |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  test client request  | Triage Stage:  Accepted
  response WSGIRequest   |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by unaizalakain):

 This would solve the problems mentioned in
 https://code.djangoproject.com/ticket/15179#comment:24

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4c03466bef8c99f1fa51ef9140867341%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12571: Test client doesn't set WSGIRequest instance on response

[Django]

#12571: Test client doesn't set WSGIRequest instance on response
-+-
   Reporter:  rvdrijst   |Owner:  nobody
   Type:  Bug|   Status:  new
  Milestone: |Component:  Testing framework
Version: | Severity:  Normal
 Resolution: | Keywords:  test client request
   Triage Stage:  Accepted   |  response WSGIRequest
Needs documentation:  1  |Has patch:  1
Patch needs improvement:  0  |  Needs tests:  1
-+-
Changes (by mattmcc):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12571: Test client doesn't set WSGIRequest instance on response

[Django]

#12571: Test client doesn't set WSGIRequest instance on response
+---
  Reporter:  rvdrijst   | Owner:  nobody
  
Status:  new| Milestone:
  
 Component:  Testing framework  |   Version:
  
Resolution: |  Keywords:  test client request 
response WSGIRequest
 Stage:  Accepted   | Has_patch:  1 
  
Needs_docs:  1  |   Needs_tests:  1 
  
Needs_better_patch:  0  |  
+---
Changes (by SmileyChris):

  * needs_docs:  0 => 1
  * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12571: Test client doesn't set WSGIRequest instance on response

[Django]

#12571: Test client doesn't set WSGIRequest instance on response
+---
  Reporter:  rvdrijst   | Owner:  nobody
  
Status:  new| Milestone:
  
 Component:  Testing framework  |   Version:
  
Resolution: |  Keywords:  test client request 
response WSGIRequest
 Stage:  Accepted   | Has_patch:  1 
  
Needs_docs:  0  |   Needs_tests:  0 
  
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * version:  SVN =>
  * milestone:  1.2 =>
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #12571: Test client doesn't set WSGIRequest instance on response

[Django]

#12571: Test client doesn't set WSGIRequest instance on response
--+-
 Reporter:  rvdrijst  |   Owner:  nobody
   Status:  new   |   Milestone:  1.2   
Component:  Testing framework | Version:  SVN   
 Keywords:  test client request response WSGIRequest  |   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 When you call {{{get()}}} or {{{post()}}} on the {{{Client}}} instance in
 a testcase, the returned response contains a {{{request}}} attribute that
 is a simple {{{dict}}} created by the client to simulate a request. This
 can be useful, but it is not the request instance that is used in views
 and middleware.

 It would be very useful to have the request instance as seen (and possibly
 modified) by the view and middleware. This is the {{{WSGIRequest}}}
 instance created in the {{{ClientHandler}}}, used by the {{{Client}}}.
 This instance is based on the simple {{{dict}}} that is currently set on
 the response as the request.

 I came across this problem before and worked around it, but now with the
 new messages framework, a clear usecase presents itself. You cannot get to
 the messages set by a tested view, simply because the
 {{{response.request}}} is not the {{{WSGIRequest}}} instance that was used
 for setting the messages.

 A (backwards compatible) solution is to let the {{{ClientHandler}}} add
 this {{{WSGIRequest}}} instance as an attribute called {{{wsgi_request}}}
 to the {{{response}}} before it returns it.

 Using this solution, you can get to the message storage by doing
 {{{messages.get_messages(response.wsgi_request)}}}. It can also be useful
 for testing middleware, decorators and other functionalities that modify
 the request in any way.

 Attached is the extremely simple patch that makes this one-line addition.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.