Re: [Django] #12646: Flawed error display in admin when using fieldsets.

[Django]

#12646: Flawed error display in admin when using fieldsets.
+---
   Reporter:  schinckel | Owner:  nobody   
 Status:  closed| Milestone:   
  Component:  django.contrib.admin  |   Version:  1.1  
 Resolution:  fixed |  Keywords:  design_ux
   Triage Stage:  Accepted  | Has patch:  0
Needs documentation:  0 |   Needs tests:  0
Patch needs improvement:  0 |  
+---
Changes (by julien):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 I'm pretty sure this was fixed in [14999].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12646: Flawed error display in admin when using fieldsets.

[Django]

#12646: Flawed error display in admin when using fieldsets.
---+
  Reporter:  schinckel | Owner:  nobody   
Status:  new   | Milestone:   
 Component:  django.contrib.admin  |   Version:  1.1  
Resolution:|  Keywords:  design_ux
 Stage:  Accepted  | Has_patch:  0
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * keywords:  => design_ux
  * component:  Uncategorized => django.contrib.admin
  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12646: Flawed error display in admin when using fieldsets.

[Django]

#12646: Flawed error display in admin when using fieldsets.
+---
  Reporter:  schinckel  | Owner:  nobody
Status:  new| Milestone:
 Component:  Uncategorized  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Comment (by schinckel):

 Note: I haven't submitted a patch against django, as i am overriding the
 template in my project(s).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12646: Flawed error display in admin when using fieldsets.

[Django]

#12646: Flawed error display in admin when using fieldsets.
+---
  Reporter:  schinckel  | Owner:  nobody
Status:  new| Milestone:
 Component:  Uncategorized  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by schinckel):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 My replacement for the admin/includes/fieldset.html template, if it is
 useful:

 {{{
 
 {% if fieldset.name %}{{ fieldset.name }}{% endif %}
 {% if fieldset.description %}
 {{ fieldset.description|safe }}
 {% endif %}
 {% for line in fieldset %}
 
 {% for field in line %}
 
 {% if field.is_checkbox %}
 {{ field.field }}{{ field.label_tag }}
 {% else %}
 {{ field.label_tag }}
 {% if field.is_readonly %}
 {{ field.contents }}
 {% else %}
 {{ field.field }}
 {% endif %}
 {% endif %}
 {% if field.field.errors %}
 {{ field.field.errors }}
 {% endif %}
 {% if field.field.field.help_text %}
 {{
 field.field.field.help_text|safe }}
 {% endif %}
 
 {% endfor %}
 
 {% endfor %}
 

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #12646: Flawed error display in admin when using fieldsets.

[Django]

#12646: Flawed error display in admin when using fieldsets.
---+
 Reporter:  schinckel  |   Owner:  nobody
   Status:  new|   Milestone:
Component:  Uncategorized  | Version:  1.1   
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 When using fieldsets within the admin, and an error occurs within one
 field of a line, then all fields within that line are marked as error by
 the css. That is, every field gets a red border, when really only the
 fields with actual errors should have a red border.

 Related, but less annoying: the error messages are piled up at the top of
 the fieldset line, rather than being close to the field with the error.

 I overcame both issues using a custom template for fieldset, and some
 extra css:
  - put an extra class on field.box when there are no errors for this
 field, and an entry in the admin-extra.css setting the border-color back.
  - remove the line.errors tag, and replace by appropriate
 field.field.errors tags within the for loop for fields within the line.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.