Re: [Django] #12658: Import Errors in test files cause tests to be skipped if both the tests file and the models file have been split into folders

[Django]

#12658: Import Errors in test files cause tests to be skipped if both the tests
file and the models file have been split into folders
-+---
   Reporter:  schinckel  |  Owner:  nobody
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Testing framework
Version:  1.1|   Severity:  Normal
 Resolution:  fixed  |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  0  |
-+---
Changes (by ramiro):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [16382]:
 {{{
 #!CommitTicketReference repository="" revision="16382"
 Fixed #12658 -- Fixed test discovery so ImportErrors aren't ignored when
 both `tests` and `models` are packages. Thanks schinckel for the report
 and boxm for a patch for the issue.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped if both the tests file and the models file have been split into folders

[Django]

#12658: Import Errors in test files cause tests to be skipped if both the tests
file and the models file have been split into folders
-+---
   Reporter:  schinckel  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone: |  Component:  Testing framework
Version:  1.1|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  0  |
-+---

Comment (by ramiro):

 #16217 was a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped if both the tests file and the models file have been split into folders (was: Import Errors in test files cause tests to be s

[Django]

#12658: Import Errors in test files cause tests to be skipped if both the tests
file and the models file have been split into folders
-+---
   Reporter:  schinckel  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone: |  Component:  Testing framework
Version:  1.1|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  0  |
-+---
Changes (by ramiro):

 * ui_ux:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
-+---
   Reporter:  schinckel  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone: |  Component:  Testing framework
Version:  1.1|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+---
Changes (by patchhammer):

 * needs_better_patch:  0 => 1
 * easy:   => 0


Comment:

 patch%2Btests.diff fails to apply cleanly on to trunk

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
-+-
   Reporter:  schinckel  |Owner:  nobody
   Type:  Bug|   Status:  reopened
  Milestone: |Component:  Testing framework
Version:  1.1| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by mattmcc):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
-+--
   Reporter:  schinckel  |Owner:  nobody
 Status:  reopened   |Milestone:
  Component:  Testing framework  |  Version:  1.1
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+--
Changes (by boxm):

 * cc: boxm (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
-+--
   Reporter:  schinckel  |Owner:  nobody
 Status:  reopened   |Milestone:
  Component:  Testing framework  |  Version:  1.1
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+--
Changes (by boxm):

 * needs_tests:  1 => 0


Comment:

 I have created a testcase and updated the patch as requested to use
 module_has_submodule(). This patch was tested on 1.3 but should apply back
 to 1.2.

 The error is also present in 1.1, but the module_has_submodule utility
 function isn't.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
+---
  Reporter:  schinckel  | Owner:  nobody
Status:  reopened   | Milestone:
 Component:  Testing framework  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  1 
Needs_better_patch:  0  |  
+---
Comment (by russellm):

 I agree with Eric that this needs a test case. The test case doesn't need
 to be of the full test suite; just that the get_tests() method works. The
 model_package modeltest provides a set of test models that could be used.

 I would also say that the "check that the module exists" logic should be
 replace with django.utils.module_loading.module_has_submodule(); this
 utility method was introduced in 1.2 to perform exactly the check that is
 being performed here, but in a more rigorous fashion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
+---
  Reporter:  schinckel  | Owner:  nobody
Status:  reopened   | Milestone:
 Component:  Testing framework  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  1 
Needs_better_patch:  0  |  
+---
Changes (by ericholscher):

  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

Comment:

 Seems like this should have a test case to prove that it is indeed
 working.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
+---
  Reporter:  schinckel  | Owner:  nobody
Status:  reopened   | Milestone:
 Component:  Testing framework  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by schinckel):

  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
+---
  Reporter:  schinckel  | Owner:  nobody
Status:  reopened   | Milestone:
 Component:  Testing framework  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by schinckel):

  * status:  closed => reopened
  * resolution:  duplicate =>

Comment:

 Yeah, since the patch in #12574 does not affect anything inside the
 django/ directory, only tests/, then it cannot fix my issue.

 Which, as kmtracey stated, is running tests on my own apps, not on the
 django framework.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
+---
  Reporter:  schinckel  | Owner:  nobody
Status:  closed | Milestone:
 Component:  Testing framework  |   Version:  1.1   
Resolution:  duplicate  |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Comment (by kmtracey):

 They sound similar but I don't think they are the same problem. #12574
 reports a problem running Django's own tests, this one is reporting a
 problem running an application's tests.  Unless the patch for #12574 is
 wrong (it changes only `tests/runtests.py` and does not touch the code in
 `test/simple.py` mentioned above) I don't see how this one can be a dupe
 of that one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
+---
  Reporter:  schinckel  | Owner:  nobody
Status:  closed | Milestone:
 Component:  Testing framework  |   Version:  1.1   
Resolution:  duplicate  |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * status:  new => closed
  * resolution:  => duplicate

Comment:

 I think this is a duplicate of #12574. Please reopen if I've misunderstood
 the problem you are describing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12658: Import Errors in test files cause tests to be skipped.

[Django]

#12658: Import Errors in test files cause tests to be skipped.
+---
  Reporter:  schinckel  | Owner:  nobody
Status:  new| Milestone:
 Component:  Testing framework  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by schinckel):

  * summary:  Import Errors in test files cause tests to be split. =>
  Import Errors in test files cause tests to be
  skipped.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.