Re: [Django] #12705: Admin date widget not working on inlines until after validation failure

[Django]

#12705: Admin date widget not working on inlines until after validation failure
---+
  Reporter:  russellm  | Owner:  jezdez
Status:  assigned  | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jbronn):

  * needs_better_patch:  1 => 0
  * stage:  Accepted => Ready for checkin

Comment:

 Replying to [comment:6 jbronn]:
 > still having problems with IE7.

 User error, again.  Works in IE7; after running test suite will check in.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12705: Admin date widget not working on inlines until after validation failure

[Django]

#12705: Admin date widget not working on inlines until after validation failure
---+
  Reporter:  russellm  | Owner:  jezdez
Status:  assigned  | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by jbronn):

  * needs_better_patch:  0 => 1
  * has_patch:  0 => 1

Comment:

 Appears to work fine in Firefox/Safari/Chrome; however still having
 problems with IE7.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12705: Admin date widget not working on inlines until after validation failure

[Django]

#12705: Admin date widget not working on inlines until after validation failure
---+
  Reporter:  russellm  | Owner:  jezdez
Status:  assigned  | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by jbronn):

 Replying to [comment:4 jbronn]:
 > Patch doesn't fix my manifestation of the problem
 User error on my part, the patch does indeed work.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12705: Admin date widget not working on inlines until after validation failure

[Django]

#12705: Admin date widget not working on inlines until after validation failure
---+
  Reporter:  russellm  | Owner:  jezdez
Status:  assigned  | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by jbronn):

 Patch doesn't fix my manifestation of the problem, as they don't work on
 newly added inlines either (as I described in dupe #12835).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12705: Admin date widget not working on inlines until after validation failure

[Django]

#12705: Admin date widget not working on inlines until after validation failure
---+
  Reporter:  russellm  | Owner:  jezdez
Status:  assigned  | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by jezdez):

 From what I understand this happens because the event handlers of the
 admin date widget aren't correctly handled when adding inlines
 dynamically.

 I think we could work around that by re-initializing the calendar widgets
 when adding a new inline as long as we don't have a better way to tell the
 widget not lose the event handler.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12705: Admin date widget not working on inlines until after validation failure

[Django]

#12705: Admin date widget not working on inlines until after validation failure
---+
  Reporter:  russellm  | Owner:  jezdez
Status:  assigned  | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jezdez):

  * owner:  nobody => jezdez
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12705: Admin date widget not working on inlines until after validation failure

[Django]

#12705: Admin date widget not working on inlines until after validation failure
---+
  Reporter:  russellm  | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * version:  1.1 => SVN
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted

Old description:

> Sample models.py:
> {{{
> class Publisher(models.Model):
>name = models.CharField(max_length=300)
>
> class Book(models.Model):
>name = models.CharField(max_length=300)
>publisher = models.ForeignKey(Publisher)
>pubdate = models.DateField()
>
> }}}
>
> admin.py:
> {{{
> class BookInline(admin.TabularInline):
> model = Book
> # extra = 1
>
> class PublisherAdmin(admin.ModelAdmin):
> inlines = [BookInline]
>
> admin.site.register(Publisher, PublisherAdmin)
> }}}
>
> Test procedure:
>  1. Create a new publisher
>  2. Click the "Add a new book" button
>  3. Set the name of the book.
>  3. Press the today button. Nothing happens - the date doesn't populate
> the date field.
>  4. Press the calendar widget. Select a date. The date doesn't populate
> the date field.
>  5. Save the object. This should cause a validation error, as pubdate is
> a required field
>  6. Press the today button. It works!
>  7. Press the calendar widget. It works!
>
> I've observed this using Safari 4.0.4, Firefox 3.5.7, and Chrome
> 4.0.249.49 (35163) beta on OSX 10.5.8.

New description:

 Sample models.py:
 {{{
 class Publisher(models.Model):
name = models.CharField(max_length=300)

 class Book(models.Model):
name = models.CharField(max_length=300)
publisher = models.ForeignKey(Publisher)
pubdate = models.DateField()

 }}}

 admin.py:
 {{{
 class BookInline(admin.TabularInline):
 model = Book

 class PublisherAdmin(admin.ModelAdmin):
 inlines = [BookInline]

 admin.site.register(Publisher, PublisherAdmin)
 }}}

 Test procedure:
  1. Create a new publisher
  2. Click the "Add a new book" button
  3. Set the name of the book.
  3. Press the today button. Nothing happens - the date doesn't populate
 the date field.
  4. Press the calendar widget. Select a date. The date doesn't populate
 the date field.
  5. Save the object. This should cause a validation error, as pubdate is a
 required field
  6. Press the today button. It works!
  7. Press the calendar widget. It works!

 I've observed this using Safari 4.0.4, Firefox 3.5.7, and Chrome
 4.0.249.49 (35163) beta on OSX 10.5.8.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #12705: Admin date widget not working on inlines until after validation failure

[Django]

#12705: Admin date widget not working on inlines until after validation failure
--+-
 Reporter:  russellm  |   Owner:  nobody
   Status:  new   |   Milestone:  1.2   
Component:  django.contrib.admin  | Version:  1.1   
 Keywords:|   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 Sample models.py:
 {{{
 class Publisher(models.Model):
name = models.CharField(max_length=300)

 class Book(models.Model):
name = models.CharField(max_length=300)
publisher = models.ForeignKey(Publisher)
pubdate = models.DateField()

 }}}

 admin.py:
 {{{
 class BookInline(admin.TabularInline):
 model = Book
 # extra = 1

 class PublisherAdmin(admin.ModelAdmin):
 inlines = [BookInline]

 admin.site.register(Publisher, PublisherAdmin)
 }}}

 Test procedure:
  1. Create a new publisher
  2. Click the "Add a new book" button
  3. Set the name of the book.
  3. Press the today button. Nothing happens - the date doesn't populate
 the date field.
  4. Press the calendar widget. Select a date. The date doesn't populate
 the date field.
  5. Save the object. This should cause a validation error, as pubdate is a
 required field
  6. Press the today button. It works!
  7. Press the calendar widget. It works!

 I've observed this using Safari 4.0.4, Firefox 3.5.7, and Chrome
 4.0.249.49 (35163) beta on OSX 10.5.8.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.