Re: [Django] #12836: Model.get_absolute_url lose method attributes

[Django]

#12836: Model.get_absolute_url lose method attributes
-+-
 Reporter:  minmax   |Owner:  minmax
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by melinath):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 So apparently this was fixed as a side effect of fixing #15604. (See
 https://github.com/django/django/commit/72c57338). And the commit
 referenced by Caleb above adds tests for the specific use case mentioned
 here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12836: Model.get_absolute_url lose method attributes

[Django]

#12836: Model.get_absolute_url lose method attributes
-+-
 Reporter:  minmax   |Owner:  minmax
 Type:  Bug  |   Status:  reopened
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Caleb Smith ):

 In [changeset:"210fd7c658a44e51f4696555b3ce71498db55d96"]:
 {{{
 #!CommitTicketReference repository=""
 revision="210fd7c658a44e51f4696555b3ce71498db55d96"
 refs #12836 - Added a test to assure permalink wraps method attributes
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12836: Model.get_absolute_url lose method attributes

[Django]

#12836: Model.get_absolute_url lose method attributes
-+-
 Reporter:  minmax   |Owner:  minmax
 Type:  Bug  |   Status:  reopened
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by caleb.smithnc@…):

 * needs_tests:  1 => 0


Comment:

 I added a pull request that adds the test here:
 https://github.com/django/django/pull/360
 The fix.diff at the top was already applied, but the doc test in test.diff
 isn't. I simply rewrote it as a unit test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12836: Model.get_absolute_url lose method attributes

[Django]

#12836: Model.get_absolute_url lose method attributes
---+
  Reporter:  minmax| Owner:  minmax
Status:  reopened  | Milestone:
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by carljm):

  * status:  closed => reopened
  * resolution:  duplicate =>

Comment:

 This is not actually a duplicate of #11891. That ticket is about
 replacement of get_absolute_url in ModelBase, this one is about
 @models.permalink.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12836: Model.get_absolute_url lose method attributes

[Django]

#12836: Model.get_absolute_url lose method attributes
---+
  Reporter:  minmax| Owner:  minmax
Status:  closed| Milestone:
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:  duplicate |  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by minmax):

  * status:  new => closed
  * resolution:  => duplicate

Comment:

 duplicate to #11891

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12836: Model.get_absolute_url lose method attributes

[Django]

#12836: Model.get_absolute_url lose method attributes
---+
  Reporter:  minmax| Owner:  minmax
Status:  new   | Milestone:
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Comment (by minmax):

 Replying to [comment:1 russellm]:
 > I am prompted to ask "why?", but using wraps on is good practice in
 general, so I'll accept.

 i am use my own cache decorator on get_absolute_url, and it store some
 object in function

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12836: Model.get_absolute_url lose method attributes

[Django]

#12836: Model.get_absolute_url lose method attributes
---+
  Reporter:  minmax| Owner:  minmax
Status:  new   | Milestone:
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * needs_better_patch:  => 0
  * has_patch:  0 => 1
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 1
  * needs_docs:  => 0

Comment:

 I am prompted to ask "why?", but using wraps on is good practice in
 general, so I'll accept.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #12836: Model.get_absolute_url lose method attributes

[Django]

#12836: Model.get_absolute_url lose method attributes
--+-
 Reporter:  minmax|   Owner:  minmax
   Status:  new   |   Milestone:
Component:  Database layer (models, ORM)  | Version:  SVN   
 Keywords:|   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 {{{
 class MyModel(models.Mode):
 @models.permalink
 @set_attr('x', 10) # set some attribute to MyModel.get_absolute_url
 method
 def get_absolute_url(self):
 return ('some', (self.attr, ))

 >>>print MyModel().get_absolute_url.x
 AttributeError: 'function' object has no attribute 'x'
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.