Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  closed
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Fixed in [6bdc47f75ca].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.84eb2cb51ef14458f8b76d69ac6dc639%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by timo):

 https://github.com/django/django/pull/505

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7a1a968344f22b24a097192c951b2dae%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by aaugustin):

 Similar cleanup already happened in this file:
 
https://github.com/django/django/commit/04d9730b127c689b8eda01cbc913efa6e2eb230b#L0L55

 The patch fixes the two last instances of `if foo:`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * stage:  Design decision needed => Accepted


Comment:

 I'm in favor of strict checking against `None` when determining is
 something is "missing" (which is the case here).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:  contenttype  |  decision needed
  genericforeignkey  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by ramiro):

 The one that changed triage state to DDN was me. Sorry

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:  contenttype  |  decision needed
  genericforeignkey  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by anonymous):

 * stage:  Accepted => Design decision needed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by ramiro):

 I'd say close this ticket as ''wontfix'' because ContentType is an
 'internal' model over which the user has no control so its IntegerField id
 PK follows the usual semantics of a Django model regarding it having a
 value of 0 meaning the model has no corresponding DB record.
 So the only scenario in which CT could have a 0 PK is an edge-case one and
 IMHO it's not worth to special-case PK semantics of CT for it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by ramiro):

 See also #13085.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by woodlee):

 All contenttypes.ContentTypesTests pass under sqlite.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by woodlee):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by woodlee):

 Fixing in
 
https://github.com/mapmyfitness/django/commit/9d17d485bd661e77de587e70b231b846dc40d721

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
 Reporter:  devesine |Owner:  woodlee
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  contenttype  |  Needs documentation:  0
  genericforeignkey  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by woodlee):

 * owner:  nobody => woodlee
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+-
   Reporter:  devesine   |Owner:  nobody
   Type:  Bug|   Status:  new
  Milestone: |Component:  contrib.contenttypes
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:  contenttype
   Triage Stage:  Accepted   |  genericforeignkey
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  1  |  Needs tests:  0
-+-
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 Could you rewrite the tests using unittests since this is now Django's
 preferred way?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
---+
  Reporter:  devesine  | Owner:  nobody 
  
Status:  new   | Milestone: 
  
 Component:  Contrib apps  |   Version:  SVN
  
Resolution:|  Keywords:  contenttype 
genericforeignkey
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by devesine):

  * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
---+
  Reporter:  devesine  | Owner:  nobody 
  
Status:  new   | Milestone: 
  
 Component:  Contrib apps  |   Version:  SVN
  
Resolution:|  Keywords:  contenttype 
genericforeignkey
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  1  
  
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13137: GenericForeignKey does not allow content type PK 0

[Django]

#13137: GenericForeignKey does not allow content type PK 0
-+--
   Reporter:  devesine   |Owner:  nobody
 Status:  new|Milestone:
  Component:  Contrib apps   |  Version:  SVN   
   Keywords:  contenttype genericforeignkey  |Stage:  Unreviewed
  Has_patch:  1  |   Needs_docs:  0 
Needs_tests:  0  |   Needs_better_patch:  0 
-+--
 The GenericForeignKey system does not properly recognize when a
 ContentType ID 0 is linked to.  In django/contrib/contenttypes/generic.py,
 two specific instances are checking for "if primarykey:" rather than "if
 primarykey is not None:".

 This specifically came up in our environment because we are matching the
 ContentType ids to our legacy database content type ids, which start at 0
 rather than 1.

 To reproduce, rename attached foobar_models.py to models.py and place in
 an app named 'foobar', then follow the directions in comments at the
 bottom of the models file.

 The attached proposed patch changes these two if statements to "is not
 None", which I believe is more correctly in the spirit of the code as well
 as allowing this functional case.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.