Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Aymeric Augustin ):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"82b3e6ffcb9d810cc0e3ec27d25f89ce1fd525e0"]:
 {{{
 #!CommitTicketReference repository=""
 revision="82b3e6ffcb9d810cc0e3ec27d25f89ce1fd525e0"
 Fixed #13222 -- Made HttpResponse iterable once

 response.content can be accessed many times as desired, and always
 returns the same result.

 iter(response) works only once and consumes the iterator.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  reopened
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Aymeric Augustin ):

 In [changeset:"ea57112d531dfc6d2be50f47ee89f3a06f8ff1a8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ea57112d531dfc6d2be50f47ee89f3a06f8ff1a8"
 Reverted 6a64822bf4632707212314a25a843c862bdb3874.

 This commit caused every test that does two or more assertContains to
 fail, because of #6527. It also made HttpResponse non-pickleable.

 Refs #13222.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  reopened
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 This commit broke pickling of `HttpResponse` objects :(

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by aaugustin):

 Well, if there's a valid use case for that, let's open a new ticket.

 Usually one builds the entire content first, then iterates over it to
 render the response.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by teepark):

 {{{
 >>> import collections
 >>> d = collections.deque([1,2,3])
 >>> i = iter(d)
 >>> d.append(4)
 >>> list(i)
 Traceback (most recent call last):
   File "", line 1, in 
 RuntimeError: deque mutated during iteration
 }}}

 it's not about ordered vs unordered, it's about whether pre-existing
 iterators tolerate mutation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by aaugustin):

 I committed before seeing your last comment.

 It doesn't make much sense to instantiate a response with a dictionary or
 a set: these aren't ordered types.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Aymeric Augustin ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6a64822bf4632707212314a25a843c862bdb3874"]:
 {{{
 #!CommitTicketReference repository=""
 revision="6a64822bf4632707212314a25a843c862bdb3874"
 Fixed #13222 -- Repeated iteration of HttpResponse

 Thanks teepark for the report and grahamd for his insights.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  new
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by teepark):

 `@content.setter` actually supports any iterable type, and dictionaries
 and set iterators (and perhaps others) will raise if their original object
 is modified since the iterator's creation.

 {{{
 >>> s = set([1,2,3])
 >>> i = iter(s)
 >>> s.add(4)
 >>> list(i)
 Traceback (most recent call last):
   File "", line 1, in 
 RuntimeError: Set changed size during iteration
 }}}

 There's not really a good reason to use either of those types as
 `HttpResponse.content`, but `_content` becomes the provided object so long
 as it `hasattr("__iter__")`, so this implementation does also create new
 limitations on what is an acceptable `content`.

 It's my general feeling that separate iterators for separate `__iter__`
 invocations is a more robust approach because of this kind of issue, but
 this patch is far and away better than the current behavior.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  new
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by aaugustin):

 It does in Python 2.6, 2.7, 3.2 and 3.3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  new
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by teepark):

 LGTM, with the assumption that this works for every python version we care
 about:

 {{{
 >>> l = [1,2,3]
 >>> i = iter(l)
 >>> l.append(4)
 >>> list(i)
 [1, 2, 3, 4]
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
 Reporter:  teepark  |Owner:  aaugustin
 Type:  Bug  |   Status:  new
Component:  HTTP handling|  Version:  1.3-rc1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
---+-
 Reporter:  teepark|Owner:  aaugustin
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  1.3-rc1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by aaugustin):

 I think the attached patch is the simplest way to fix the problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
---+-
 Reporter:  teepark|Owner:  aaugustin
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  1.3-rc1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by aaugustin):

 I'm going to follow Graham's advice: remove the rewinding behavior, ie.
 behave like files and generators. WSGI doesn't expect to iterate the
 response more than once.

 Another advantage is that this behavior can be implemented consistently in
 `HttpResponse` and `StreamingHttpResponse`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
---+-
 Reporter:  teepark|Owner:  aaugustin
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  1.3-rc1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by aaugustin):

 * owner:  nobody => aaugustin
 * status:  reopened => new
 * stage:  Design decision needed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
   Reporter:  teepark|Owner:  nobody
   Type:  Bug|   Status:  reopened
  Milestone: |Component:  HTTP handling
Version:  1.3-rc1| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Design |Has patch:  1
  decision needed|  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-

Comment (by grahamd):

 In some respect this is an issue which could perhaps be brought up on
 Python WEB-SIG because what you are talking about is how the iterable
 returned by a WSGI application should behave. I know for anything I have
 seen and implemented, use of an iterator causes data to be consumed and
 it wouldn't be rewound to the original beginning of the data if a new
 iterator were created as Django seems to be doing by what is described
 here. So, perhaps another odd corner case for WSGI specification which
 should be clarified.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
   Reporter:  teepark|Owner:  nobody
   Type:  Bug|   Status:  reopened
  Milestone: |Component:  HTTP handling
Version:  1.3-rc1| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Design |Has patch:  1
  decision needed|  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-

Comment (by teepark):

 Replying to [comment:12 Alex]:
 > I'm not sure we *want* to fix this.  Almost all file-like objects have
 this behavior.  Needs more thought IMO.

 I'd be happy if HttpResponse emulated file objects' behavior, but that's
 not quite the case either (the code snippet from the OP works fine with a
 file).

 File objects have a single cursor location that all iterators wind up
 sharing, but they don't set it back to the beginning of the file every
 time you call iter() on it, which in effect is what HttpResponse does
 currently.

 IMO the design decision should be whether we fix it to be like list (the
 current patch) or we fix it to be like files.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
-+-
   Reporter:  teepark|Owner:  nobody
   Type:  Bug|   Status:  reopened
  Milestone: |Component:  HTTP handling
Version:  1.3-rc1| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Design |Has patch:  1
  decision needed|  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by Alex):

 * version:   => 1.3-rc1
 * stage:  Accepted => Design decision needed


Comment:

 I'm not sure we *want* to fix this.  Almost all file-like objects have
 this behavior.  Needs more thought IMO.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
+-
   Reporter:  teepark   |Owner:  nobody
   Type:  Bug   |   Status:  reopened
  Milestone:|Component:  HTTP handling
Version:| Severity:  Normal
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  0 |
+-
Changes (by teepark):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
+-
   Reporter:  teepark   |Owner:  nobody
   Type:  Bug   |   Status:  reopened
  Milestone:|Component:  HTTP handling
Version:| Severity:  Normal
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  1 |
+-
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 Could you rewrite the tests using unittests since this is now Django's
 preferred way?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
+---
  Reporter:  teepark| Owner:  nobody
Status:  reopened   | Milestone:
 Component:  HTTP handling  |   Version:
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
+---
  Reporter:  teepark| Owner:  nobody
Status:  reopened   | Milestone:
 Component:  HTTP handling  |   Version:
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by teepark):

  * status:  closed => reopened
  * resolution:  duplicate =>

Comment:

 Replying to [comment:5 ubernostrum]:
 > Duplicate of #7581, which is already open for dealing with issues
 related to iterators/generators in response content.
 >
 > In the future please search existing tickets before opening new ones.

 I did search through and I saw that ticket. #7581 deals with
 HttpResponse.content, which accesses `_container` directly, so is
 orthogonal to iteration behavior. My patch won't fix #7581, and fixing
 #7581 won't help this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
+---
  Reporter:  teepark| Owner:  nobody
Status:  closed | Milestone:
 Component:  HTTP handling  |   Version:
Resolution:  duplicate  |  Keywords:
 Stage:  Unreviewed | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by ubernostrum):

  * status:  new => closed
  * resolution:  => duplicate

Comment:

 Duplicate of #7581, which is already open for dealing with issues related
 to iterators/generators in response content.

 In the future please search existing tickets before opening new ones.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
+---
  Reporter:  teepark| Owner:  nobody
Status:  new| Milestone:
 Component:  HTTP handling  |   Version:
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by teepark):

 * cc: travis.par...@gmail.com (removed)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
+---
  Reporter:  teepark| Owner:  nobody
Status:  new| Milestone:
 Component:  HTTP handling  |   Version:
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by teepark):

 * cc: travis.par...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
+---
  Reporter:  teepark| Owner:  nobody
Status:  new| Milestone:
 Component:  HTTP handling  |   Version:
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by teepark):

  * version:  1.1 =>

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
+---
  Reporter:  teepark| Owner:  nobody
Status:  new| Milestone:
 Component:  HTTP handling  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by teepark):

  * needs_better_patch:  => 0
  * has_patch:  0 => 1
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13222: unexpected HttpResponse iteration behavior

[Django]

#13222: unexpected HttpResponse iteration behavior
---+
 Reporter:  teepark|   Owner:  nobody
   Status:  new|   Milestone:
Component:  HTTP handling  | Version:  1.1   
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 For all the builtin iterables, and most from libraries, the `__iter__`
 method returns something representing one and only one iteration.
 `django.http.HttpResponse.__iter__` sets an iterator attribute on itself,
 then returns self (it also defines a `next` method so it is its own
 iterator). This is bad behavior for an iterable and causes problems when
 trying to do anything but basic iteration.

 A use case (and where I encountered this issue) is in a WSGI server that
 pulls off the first item in the iterable app return value, prefixes
 anything that was sent via `write` calls, and then rebuilds the iterable
 with `itertools.chain`:

 {{{
 if prefix:
 body_iterator = iter(body)
 try:
 first_chunk = body_iterator.next()
 except StopIteration:
 first_chunk = ''
 body = itertools.chain((prefix + first_chunk,), body_iterator)
 }}}

 Using `django.core.handlers.wsgi.WSGIHandler` (which just returns the
 HttpResponse, since it's iterable) with this server, the first chunk of
 the HttpResponse gets doubled because `itertools.chain` calls `iter` on
 its arguments, and that resets the HttpResponse's iterator.

 To compare with some builtins and other libraries:

 {{{
 >>> it = iter(["foobar"])
 >>> list(it), list(it)
 (['foobar'], [])
 >>> it = iter("foobar" for i in [1])
 >>> list(it), list(it)
 (['foobar'], [])
 >>> import werkzeug
 >>> it = iter(werkzeug.Response("foobar").response)
 >>> list(it), list(it)
 (['foobar'], [])
 >>> import webob
 >>> it = iter(webob.Response("foobar").app_iter)
 >>> list(it), list(it)
 (['foobar'], [])
 >>> import django.http
 >>> it = iter(django.http.HttpResponse("foobar"))
 >>> list(it), list(it)
 (['foobar'], ['foobar'])
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.