Re: [Django] #13494: Bad default for EMAIL_SUBJECT_PREFIX

[Django]

#13494: Bad default for EMAIL_SUBJECT_PREFIX
---+
  Reporter:  hcarvalhoalves| Owner:  andialbrecht
Status:  assigned  | Milestone:  1.3 
 Component:  django.core.mail  |   Version:  1.1 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by jezdez):

  * milestone:  => 1.3

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13494: Bad default for EMAIL_SUBJECT_PREFIX

[Django]

#13494: Bad default for EMAIL_SUBJECT_PREFIX
---+
  Reporter:  hcarvalhoalves| Owner:  andialbrecht
Status:  assigned  | Milestone:  
 Component:  django.core.mail  |   Version:  1.1 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by andialbrecht):

  * owner:  nobody => andialbrecht
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13494: Bad default for EMAIL_SUBJECT_PREFIX

[Django]

#13494: Bad default for EMAIL_SUBJECT_PREFIX
---+
  Reporter:  hcarvalhoalves| Owner:  nobody
Status:  new   | Milestone:
 Component:  django.core.mail  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by andialbrecht):

  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13494: Bad default for EMAIL_SUBJECT_PREFIX

[Django]

#13494: Bad default for EMAIL_SUBJECT_PREFIX
---+
  Reporter:  hcarvalhoalves| Owner:  nobody
Status:  new   | Milestone:
 Component:  django.core.mail  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13494: Bad default for EMAIL_SUBJECT_PREFIX

[Django]

#13494: Bad default for EMAIL_SUBJECT_PREFIX
---+
  Reporter:  hcarvalhoalves| Owner:  nobody
Status:  new   | Milestone:
 Component:  django.core.mail  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ramiro):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * needs_tests:  => 0
  * milestone:  2.0 =>

Comment:

 A couple of workarounds could be wrapping your translatable subject with a
 [http://docs.djangoproject.com/en/1.1/ref/unicode/#translated-strings call
 to call unicode()] before passing it to `mail_managers()` or using
 [http://docs.djangoproject.com/en/1.1/topics/i18n/internationalization
 /#working-with-lazy-translation-objects string_concat()].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13494: Bad default for EMAIL_SUBJECT_PREFIX

[Django]

#13494: Bad default for EMAIL_SUBJECT_PREFIX
--+-
 Reporter:  hcarvalhoalves|   Owner:  nobody
   Status:  new   |   Milestone:  2.0   
Component:  django.core.mail  | Version:  1.1   
 Keywords:|   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 The 'EMAIL_SUBJECT_PREFIX' setting is, by default, a string. This makes it
 break loud and needlessly if you pass a translation as the subject to
 'mail_managers()':


 {{{
 TypeError
 cannot concatenate 'str' and '__proxy__' objects
 }}}


 The culprit line of django/core/mail.py:

 {{{
  424. EmailMessage(settings.EMAIL_SUBJECT_PREFIX + subject, message, ...
 }}}

 Seems like an easy fix (just change the default setting to unicode?).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.