Re: [Django] #13631: IntegerField has no attributes max_value and min_value (1.2 regression)

[Django]

#13631: IntegerField has no attributes max_value and min_value (1.2 regression)
---+
  Reporter:  mila  | Owner:  nobody
Status:  new   | Milestone:
 Component:  Forms |   Version:  1.2   
Resolution:|  Keywords:  regression
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  1 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * stage:  Design decision needed => Accepted

Comment:

 The documentation says "Takes two optional arguments for validation". It
 makes no guarantees about the field having an attribute. However, it's
 trivial to fix, and other attributes (e.g., max_digits on DecimalField,
 max_length on CharField), so it's worth doing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13631: IntegerField has no attributes max_value and min_value (1.2 regression)

[Django]

#13631: IntegerField has no attributes max_value and min_value (1.2 regression)
-+--
  Reporter:  mila| Owner:  nobody
Status:  new | Milestone:
 Component:  Forms   |   Version:  1.2   
Resolution:  |  Keywords:  regression
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  1   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by wogan):

 * cc: wogan (added)
  * keywords:  => regression

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13631: IntegerField has no attributes max_value and min_value (1.2 regression)

[Django]

#13631: IntegerField has no attributes max_value and min_value (1.2 regression)
-+--
  Reporter:  mila| Owner:  nobody
Status:  new | Milestone:
 Component:  Forms   |   Version:  1.2   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  1   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by mila):

 This can be easily fixed by setting a field attribute in addition to
 adding a validator - similar to current CharField implementation.

 The problem with this approach is that attribute value and validator can
 become easily inconsistent. Therefore from my point of view the design
 decision needed here is whether form field attributes are mutable or not.
 For example: Can be CharField min_length set in form __init__ method?

 I am attaching more tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13631: IntegerField has no attributes max_value and min_value (1.2 regression)

[Django]

#13631: IntegerField has no attributes max_value and min_value (1.2 regression)
-+--
  Reporter:  mila| Owner:  nobody
Status:  new | Milestone:
 Component:  Forms   |   Version:  1.2   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  1   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by erikr):

  * stage:  Accepted => Design decision needed

Comment:

 This would probably actually fit better in DDN.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13631: IntegerField has no attributes max_value and min_value (1.2 regression)

[Django]

#13631: IntegerField has no attributes max_value and min_value (1.2 regression)
---+
  Reporter:  mila  | Owner:  nobody
Status:  new   | Milestone:
 Component:  Forms |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  1 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by erikr):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 1

Comment:

 I haven't seen the old code, but it seems IntegerField now does min/max
 using django.core.validators. The fields are indeed not set in the code.
 I think the documentation is not very clear on whether or not these fields
 should exist.

 So, either the fields should be added, or the documentation should be
 clarified so that it doesn't suggests these fields being there.
 I don't see an easy alternative to get them from the field instance.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13631: IntegerField has no attributes max_value and min_value (1.2 regression)

[Django]

#13631: IntegerField has no attributes max_value and min_value (1.2 regression)
---+
 Reporter:  mila   |   Owner:  nobody
   Status:  new|   Milestone:
Component:  Forms  | Version:  1.2   
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 Attributes min_value and max_value are no longer set on IntegerField,
 FloatField and DecimalField in Django 1.2.

 Note these attributes are documented:
 
http://docs.djangoproject.com/en/dev/ref/forms/fields/#django.forms.IntegerField.max_value.
 [[BR]]I'm using them to generate some javascript validation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.