Re: [Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
-+-
   Reporter:  bfirsh |  Owner:  bfirsh
   Type:  New| Status:  closed
  feature|  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  urlconf
 Resolution:  fixed  |  Has patch:  1
   Triage Stage:  Design |Needs tests:  0
  decision needed|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by russellm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Agreed - this was resolved with the introduction of generic views.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
-+-
   Reporter:  bfirsh |  Owner:  bfirsh
   Type:  New| Status:  new
  feature|  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  urlconf
 Resolution: |  Has patch:  1
   Triage Stage:  Design |Needs tests:  0
  decision needed|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by graham_king):

 * easy:   => 0


Comment:

 Is this still necessary, given that we can do it this way:
 http://docs.djangoproject.com/en/dev/ref/class-based-views/#generic-views

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
-+--
  Reporter:  bfirsh  | Owner:  bfirsh 
Status:  new | Milestone: 
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords:  urlconf
 Stage:  Design decision needed  | Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by bfirsh):

  * stage:  Accepted => Design decision needed

Comment:

 This may not be necessary. More discussion:

 http://groups.google.com/group/django-
 developers/browse_thread/thread/e23d9a5a58fe5891/23b9b3aa96bbb7f2?lnk=gst

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
-+--
  Reporter:  bfirsh  | Owner:  bfirsh 
Status:  new | Milestone: 
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords:  urlconf
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by bfirsh):

 Replying to [comment:1 lukeplant]:
 > Personally, I think that we should instead encourage people to create
 view functions out of view classes:
 > {{{
 > #!python
 > my_view = make_view(MyViewClass)
 > }}}
 >
 > (where `make_view` is a very easy to write utility that would be
 included in core).  This makes it much easier to handle decorators, and
 insulates the URLconf from implementation details (like the fact that the
 view is implemented using a class).
 >
 > We had some discussion about this: http://groups.google.com/group
 /django-
 developers/browse_thread/thread/e23d9a5a58fe5891/23b9b3aa96bbb7f2?lnk=gst
 >
 > But not many people responded to my point of view.

 I like this method because it is transparent for people who don't
 understand the threading issues. It would be quite confusing for users to
 explain why they need to use make_view().

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
-+--
  Reporter:  bfirsh  | Owner:  bfirsh 
Status:  new | Milestone: 
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords:  urlconf
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by bfirsh):

 New patch with clearer tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
-+--
  Reporter:  bfirsh  | Owner:  bfirsh 
Status:  new | Milestone: 
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords:  urlconf
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by bfirsh):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
-+--
  Reporter:  bfirsh  | Owner:  bfirsh 
Status:  new | Milestone: 
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords:  urlconf
 Stage:  Unreviewed  | Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by apollo13):

  * stage:  Ready for checkin => Unreviewed

Comment:

 Plz don't change triage stages; this is not ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
+---
  Reporter:  bfirsh | Owner:  bfirsh 
Status:  new| Milestone: 
 Component:  Core framework |   Version:  SVN
Resolution: |  Keywords:  urlconf
 Stage:  Ready for checkin  | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Changes (by bfirsh):

  * has_patch:  0 => 1
  * stage:  Unreviewed => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
-+--
  Reporter:  bfirsh  | Owner:  bfirsh 
Status:  new | Milestone: 
 Component:  Core framework  |   Version:  SVN
Resolution:  |  Keywords:  urlconf
 Stage:  Unreviewed  | Has_patch:  0  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by lukeplant):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Personally, I think that we should instead encourage people to create view
 functions out of view classes:
 {{{
 #!python
 my_view = make_view(MyViewClass)
 }}}

 (where `make_view` is a very easy to write utility that would be included
 in core).  This makes it much easier to handle decorators, and insulates
 the URLconf from implementation details (like the fact that the view is
 implemented using a class).

 We had some discussion about this: http://groups.google.com/group/django-
 developers/browse_thread/thread/e23d9a5a58fe5891/23b9b3aa96bbb7f2?lnk=gst

 But not many people responded to my point of view.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13635: URLconfs should accept classes as views

[Django]

#13635: URLconfs should accept classes as views
+---
 Reporter:  bfirsh  |   Owner:  bfirsh
   Status:  new |   Milestone:
Component:  Core framework  | Version:  SVN   
 Keywords:  urlconf |   Stage:  Unreviewed
Has_patch:  0   |  
+---
 If a URLconf is passed a class, and isinstance(cls, type) is true, it
 should instantiate the class on each request and call it. This makes class
 based views (#6735) trivially thread safe.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.