Re: [Django] #13901: File.chunks fails to read the entire file for some file-like objects

[Django]

#13901: File.chunks fails to read the entire file for some file-like objects
--+
 Reporter:  ikelly|Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  File uploads/storage  |  Version:  SVN
 Severity:  Normal|   Resolution:  wontfix
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 The implementation of the `chunks()` method has changed in r17871, to not
 depend on size anymore. Hence rendering this ticket obsolete.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13901: File.chunks fails to read the entire file for some file-like objects

[Django]

#13901: File.chunks fails to read the entire file for some file-like objects
+
   Reporter:  ikelly|Owner:  nobody
   Type:  Bug   |   Status:  new
  Milestone:|Component:  File uploads/storage
Version:  SVN   | Severity:  Normal
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  1
Patch needs improvement:  0 |
+
Changes (by graham_king):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13901: File.chunks fails to read the entire file for some file-like objects

[Django]

#13901: File.chunks fails to read the entire file for some file-like objects
---+
  Reporter:  ikelly| Owner:  nobody
Status:  new   | Milestone:
 Component:  File uploads/storage  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by dmoisset):

  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

Comment:

 Patch is ok, but needs a regression test.

 (The issue on non-blocking read happens in the existing codebase, and
 should be treated as another ticket if considered a problem... although
 using a File with a non blocking read source looks like a bad idea anyway)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13901: File.chunks fails to read the entire file for some file-like objects

[Django]

#13901: File.chunks fails to read the entire file for some file-like objects
---+
  Reporter:  ikelly| Owner:  nobody
Status:  new   | Milestone:
 Component:  File uploads/storage  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by Alex):

 That is indeed what I was thinking of.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13901: File.chunks fails to read the entire file for some file-like objects

[Django]

#13901: File.chunks fails to read the entire file for some file-like objects
---+
  Reporter:  ikelly| Owner:  nobody
Status:  new   | Milestone:
 Component:  File uploads/storage  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by kmtracey):

 #13756 is very similar (may be the dupe Alex was thinking of)...same issue
 but different bit of code.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13901: File.chunks fails to read the entire file for some file-like objects

[Django]

#13901: File.chunks fails to read the entire file for some file-like objects
---+
  Reporter:  ikelly| Owner:  nobody
Status:  new   | Milestone:
 Component:  File uploads/storage  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by ikelly):

 You're at least right about the first part.  That's what I get for once
 again writing a small patch without testing it.  I've uploaded a corrected
 patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13901: File.chunks fails to read the entire file for some file-like objects

[Django]

#13901: File.chunks fails to read the entire file for some file-like objects
---+
  Reporter:  ikelly| Owner:  nobody
Status:  new   | Milestone:
 Component:  File uploads/storage  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 This patch doesn't look right, it should be {{{ len(chunk }}}, not
 chunk_size.  Also I'm pretty sure this is a dupe.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13901: File.chunks fails to read the entire file for some file-like objects

[Django]

#13901: File.chunks fails to read the entire file for some file-like objects
--+-
 Reporter:  ikelly|   Owner:  nobody
   Status:  new   |   Milestone:
Component:  File uploads/storage  | Version:  SVN   
 Keywords:|   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 The File.chunks method gets the size of the file and then decrements a
 counter by the chunk size for each read until it reaches 0.  The problem
 is that the read method is not guaranteed to return the full amount
 requested, and so the amount read may be less than the chunk size,
 resulting in the counter being decremented erroneously.  I ran into this
 bug while using a file-like object that wraps a java.io.InputStream
 object, whose read method returns as soon as data is available.

 This patch is one possible solution, although it still has the problem
 that it will result in a busy-loop if the read method is entirely non-
 blocking.  It also potentially yields non-terminal chunks smaller than the
 chunk size, which may not be desirable.

 See also #9632, which may affect the implementation here if it is
 accepted.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.