Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
+---
   Reporter:  gk@…  | Owner:  nobody
 Status:  closed| Milestone:
  Component:  django.contrib.admin  |   Version:  1.2   
 Resolution:  fixed |  Keywords:
   Triage Stage:  Ready for checkin | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---
Changes (by russellm):

  * status:  reopened => closed
  * resolution:  => fixed


Comment:

 This ticket was fixed; the regression is a separate issue to the original
 problem. I've just opened #15420 to track the regression.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
+---
   Reporter:  gk@…  | Owner:  nobody
 Status:  reopened  | Milestone:
  Component:  django.contrib.admin  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Ready for checkin | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---

Comment (by ramiro):

 This regression was introduced in r14628.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
+---
   Reporter:  gk@…  | Owner:  nobody
 Status:  reopened  | Milestone:
  Component:  django.contrib.admin  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Ready for checkin | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---
Changes (by dburke@…):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 This does not appear fixed to me. Running from svn and 1.2.5 I was unable
 to add a user via the popup window for either a manytomany or foreignkey.
 I get exactly the same behavior as described in the right side video.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
---+
  Reporter:  g...@lka.hu | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by ramiro):

 Karen is right. Ignore my comment about not adding translatable literals
 on a maintenance branch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
---+
  Reporter:  g...@lka.hu | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by ramiro):

 Se also #14014, a change of behavior also introduced with r12218.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
---+
  Reporter:  g...@lka.hu | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by kmtracey):

 "a username" reads correctly to me, "an username" reads wrong. I don't
 think new/changed translatable strings generally prevent fixes from being
 applied to a maint. branch -- better to fix the bug and have an
 untranslated string than not fix the bug at all. And new translations can
 be provided for the branch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
---+
  Reporter:  g...@lka.hu | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by ramiro):

 Note that both patches uploaded so far introduce and/or change new
 translatable literal and as such might be acceptable for trunk but not for
 the 1.2.x branch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
---+
  Reporter:  g...@lka.hu | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ramiro):

  * stage:  Accepted => Ready for checkin

Comment:

 Marking RFC as per Jacob instructions on IRC.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
---+
  Reporter:  g...@lka.hu | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ramiro):

  * has_patch:  0 => 1
  * component:  Uncategorized => django.contrib.admin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
+---
  Reporter:  g...@lka.hu  | Owner:  nobody
Status:  new| Milestone:
 Component:  Uncategorized  |   Version:  1.2   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by kmtracey):

  * stage:  Unreviewed => Accepted

Comment:

 Bisection shows change in behavior was introduced by r12218.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
+---
  Reporter:  g...@lka.hu  | Owner:  nobody
Status:  new| Milestone:
 Component:  Uncategorized  |   Version:  1.2   
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by g...@lka.hu):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Sorry, the video link is wrong:
 http://gk.lka.hu/x/keep/django-add-user-bug.mov

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14012: Adding an User object in a popup fails

[Django]

#14012: Adding an User object in a popup fails
---+
 Reporter:  g...@lka.hu  |   Owner:  nobody
   Status:  new|   Milestone:
Component:  Uncategorized  | Version:  1.2   
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 Let's say we have a model with a ForeignKey to the
 django.contrib.auth.User! If you edit objects of this model on the admin
 interface, you can click the little green plus sign to add a new User in a
 popup window. You enter the user name and the password (twice). In django
 1.1, it closed the window, created the user then set in the select. Django
 1.2 behaves wrong, it displays the edit user form, instead of closing the
 window. You can't even close the window with the full form's save button.
 To illustrate this, I've uploaded a video:

 http://www.youtube.com/watch?v=BIMRoBbH8ws
 (The left one is django 1.1.1, the right is django 1.2.1)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.