Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
 Reporter:  Daniel Roseman   |Owner:  Jacob
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 Please open a new issue with steps to reproduce.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.23294499681a1576f65976a1d90ebe3f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
 Reporter:  Daniel Roseman   |Owner:  Jacob
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by johncant):

 Hi,

 I am having this problem on PostgreSQL. I think my use case is sane:

 Use the Django ORM to generate some SQL -> Use Pandas to evaluate the SQL
 and return a data frame.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c34df21f99ff3704f72f365607446564%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
 Reporter:  danielr  |Owner:  jacob
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Aymeric Augustin ):

 In [changeset:"4f6a7663bcddffb114f2647f9928cbf1fdd8e4b5" 4f6a766]:
 {{{
 #!CommitTicketReference repository=""
 revision="4f6a7663bcddffb114f2647f9928cbf1fdd8e4b5"
 Refs #14091 -- Fixed connection.queries on SQLite.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.80da6f59e0dde665d582c434e006ef4f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
 Reporter:  danielr  |Owner:  jacob
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * ui_ux:   => 0


Comment:

 Four and a half years later, I still believe this should be fixed on
 SQLite as well.

 I submitted a pull request: https://github.com/django/django/pull/5282

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.57c9dd7605cc6d94924fdcc7f8ab28e3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|  Owner:
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by aaugustin):

 * stage:  Accepted => Ready for checkin


Comment:

 This new patch implements Alex and Jacob's recommendation.

 Regarding SQLite, parameters are substituted at line 642 in
 `_sqlite/cursor.c`:
 {{{
 pysqlite_statement_bind_parameters(self->statement, parameters,
 allow_8bit_chars);
 }}}
 Unfortunately there is no way to reach `self->statement` from Python code.
 That's why I ended up quoting parameters with `SELECT QUOTE(?)`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|  Owner:
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  0
-+-

Comment (by Alex):

 FWIW jacob, I spoke with aaugustin on IRC and I agree with your position,
 if we can do it in a non-hacky way (as psycopg2 is now), +1.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|  Owner:
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  0
-+-

Comment (by jacob):

 aaugustin: also, add your name to AUTHORS if you'd like credit when we
 check this in!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|  Owner:
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  0
-+-

Comment (by jacob):

 I disagree with Alex about the lack of value, but like Alex, I'm not sold
 on the approach under SQLite - it seems rather hackish and prone to
 failure. I aprove (highly) of the fixes for MySQL and Oracle, and I'd like
 to see those go in.

 I say we fix this where we can (MySQL and Oracle) and leave it as-is for
 SQLite. If there's a non-gross way of retrieving the last query from the
 `sqlite3` library then let's by all means use that, but if not we'll need
 to leave SQLite alone. We already have a good document explaining the
 differences between databases, so this can be another caveat there (and
 another reason to use a real database).

 aaugustin, if you make those changes feel free to mark this ticket RFC.
 Everything else looks good to me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|  Owner:
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  0
-+-

Comment (by aaugustin):

 Alex, the reasons for fixing this are:

 - make it possible to test queries by copy-pasting from the debug bar or a
 debug log. That is useful to troubleshoot performance issues: `./manage
 dbshell` then `EXPLAIN  <>`. Re-quoting manually complex queries
 is just a pain. The framework should do that for us.
 - remove a common source of questions and frustration for users, as seen
 on #django and in duplicate tickets.

 Also, Django is supposed be a framework for perfectionnists; IMHO the
 status quo ''yeah, it's buggy, but we say it in the small print...''
 doesn't live up to this goal. Should we ask django-developers for other
 opinions?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|  Owner:
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  0
-+-
Changes (by Alex):

 * easy:   => 0


Comment:

 `connections.queries` is explicitly documented as not quoting things
 correctly, here http://docs.djangoproject.com/en/dev/faq/models/#how-can-i
 -see-the-raw-sql-queries-django-is-running, I'm not sure why we'd bother
 to fix this, the patch is non-trivial (it involves running queries on
 SQLite) and adds little value IMO.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|Owner:
   Type:  Bug|   Status:  new
  Milestone: |Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  0  |  Needs tests:  0
-+-
Changes (by aaugustin):

 * owner:  aaugustin =>


Comment:

 I de-assign myself since I've proposed a patch and I have nothing more to
 do until someone reviews it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|Owner:  aaugustin
   Type:  Bug|   Status:  new
  Milestone: |Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  0  |  Needs tests:  0
-+-

Comment (by ikelly):

 I've run the test under Oracle, and it passes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14091: Fix incorrect quoting in connection.queries

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|Owner:  aaugustin
   Type:  Bug|   Status:  new
  Milestone: |Component:  Database layer
Version:  1.2|  (models, ORM)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  0  |  Needs tests:  0
-+-
Changes (by aaugustin):

 * type:  Uncategorized => Bug


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14091: Fix incorrect quoting in connection.queries (was: PATCH: fix incorrect quoting in connection.queries for MySQL)

[Django]

#14091: Fix incorrect quoting in connection.queries
-+-
   Reporter:  danielr|Owner:  aaugustin
   Type: |   Status:  new
  Uncategorized  |Component:  Database layer
  Milestone: |  (models, ORM)
Version:  1.2| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by aaugustin):

 * type:   => Uncategorized
 * severity:   => Normal


Comment:

 I updated the patch after the postgresql backend was removed and the
 postgresql_psycopg2 backend was refactored.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.