Re: [Django] #14130: Catching ImportError in manage.py considered dangerous

[Django]

#14130: Catching ImportError in manage.py considered dangerous
-+--
   Reporter:  Setok  | Owner:  nobody   
 
 Status:  new| Milestone:  1.3  
 
  Component:  Core framework |   Version:  1.1  
 
 Resolution: |  Keywords:  manage settings 
import sprintnov13
   Triage Stage:  Ready for checkin  | Has patch:  1
 
Needs documentation:  0  |   Needs tests:  0
 
Patch needs improvement:  0  |  
-+--
Changes (by ramiro):

  * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14130: Catching ImportError in manage.py considered dangerous

[Django]

#14130: Catching ImportError in manage.py considered dangerous
-+--
  Reporter:  Setok   | Owner:  nobody   
 
Status:  new | Milestone:  1.3  
 
 Component:  Core framework  |   Version:  1.1  
 
Resolution:  |  Keywords:  manage settings import 
sprintnov13
 Stage:  Accepted| Has_patch:  1
 
Needs_docs:  0   |   Needs_tests:  0
 
Needs_better_patch:  0   |  
-+--
Changes (by steph):

  * keywords:  manage settings import => manage settings import sprintnov13

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14130: Catching ImportError in manage.py considered dangerous

[Django]

#14130: Catching ImportError in manage.py considered dangerous
-+--
  Reporter:  Setok   | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Core framework  |   Version:  1.1   
Resolution:  |  Keywords:  manage settings import
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by steph):

 .. just updated the patch (removed an unused import).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14130: Catching ImportError in manage.py considered dangerous

[Django]

#14130: Catching ImportError in manage.py considered dangerous
-+--
  Reporter:  Setok   | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Core framework  |   Version:  1.1   
Resolution:  |  Keywords:  manage settings import
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by mk):

  * has_patch:  0 => 1

Comment:

 Patch attached.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14130: Catching ImportError in manage.py considered dangerous

[Django]

#14130: Catching ImportError in manage.py considered dangerous
-+--
  Reporter:  Setok   | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Core framework  |   Version:  1.1   
Resolution:  |  Keywords:  manage settings import
 Stage:  Accepted| Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by bberes):

 * cc: bberes (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14130: Catching ImportError in manage.py considered dangerous

[Django]

#14130: Catching ImportError in manage.py considered dangerous
-+--
  Reporter:  Setok   | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Core framework  |   Version:  1.1   
Resolution:  |  Keywords:  manage settings import
 Stage:  Accepted| Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by lrekucki):

 * cc: lrekucki (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14130: Catching ImportError in manage.py considered dangerous

[Django]

#14130: Catching ImportError in manage.py considered dangerous
-+--
  Reporter:  Setok   | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Core framework  |   Version:  1.1   
Resolution:  |  Keywords:  manage settings import
 Stage:  Accepted| Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by russellm):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * milestone:  => 1.3

Comment:

 This is an example where Django is using ImportError to establish
 existence of a module; in Django 1.2, we added tools to check for
 existence of a module without importing the module; we should be doing the
 same here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14130: Catching ImportError in manage.py considered dangerous

[Django]

#14130: Catching ImportError in manage.py considered dangerous
+---
 Reporter:  Setok   |   Owner:  nobody
   Status:  new |   Milestone:
Component:  Core framework  | Version:  1.1   
 Keywords:  manage settings import  |   Stage:  Unreviewed
Has_patch:  0   |  
+---
 The basic implementation of manage.py does little else than check for an
 ImportError on settings. Unfortunately using try-except to check for
 module existence in Python is not a very good practise. The problem is
 that it hides any possible import errors that may occur within
 settings.py. Sure, the error displayed by manage.py does mention that
 possibility, but only in parenthesis, after bold text about settings.py
 missing.

 Having just spend several hours trying to figure out what was going on I
 believe that, in balance, it would be better just to let the Python error
 fall through and for a proper stacktrace to occur. Alternatively try to
 figure out a way to detect if it was, in fact, the settings module which
 was missing, or something else. Annoyingly Python's ImportError does not
 seem to easily have that information available :(

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.