Re: [Django] #14184: Validators not called on MultiValueField

[Django]

#14184: Validators not called on MultiValueField
-+-
 Reporter:  anonymous|Owner:
 Type:  Bug  |  paulcollins
Component:  Forms|   Status:  closed
 Severity:  Normal   |  Version:  1.2
 Keywords:  MultiValueField  |   Resolution:  fixed
  Validators | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by jezdez):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17430]:
 {{{
 #!CommitTicketReference repository="" revision="17430"
 Fixed #14184 -- Enabled running the validators in MultiValueFields.
 Thanks, paulcollins.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14184: Validators not called on MultiValueField

[Django]

#14184: Validators not called on MultiValueField
-+-
 Reporter:  anonymous|Owner:
 Type:  Bug  |  paulcollins
Component:  Forms|   Status:  new
 Severity:  Normal   |  Version:  1.2
 Keywords:  MultiValueField  |   Resolution:
  Validators | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by claudep):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14184: Validators not called on MultiValueField

[Django]

#14184: Validators not called on MultiValueField
-+-
 Reporter:  anonymous|Owner:
 Type:  Bug  |  paulcollins
Component:  Forms|   Status:  new
 Severity:  Normal   |  Version:  1.2
 Keywords:  MultiValueField  |   Resolution:
  Validators | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by paulcollins):

 Replying to [comment:3 paulcollins]:
 > On a related note MultiValueField.validate is overridden to be a noop,
 but the parent class Field checks if the field is required. I've left it
 alone but, should MultiValueField.validate be removed so that the
 Field.validate gets called instead?


 Never mind, eventually rereading the clean function for the
 MultiValueField answered my question. Seems the clean method already does
 the work of the Field.validate method.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14184: Validators not called on MultiValueField

[Django]

#14184: Validators not called on MultiValueField
-+-
 Reporter:  anonymous|Owner:
 Type:  Bug  |  paulcollins
Component:  Forms|   Status:  new
 Severity:  Normal   |  Version:  1.2
 Keywords:  MultiValueField  |   Resolution:
  Validators | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by paulcollins):

 * cc: paulcollins (added)
 * owner:  nobody => paulcollins
 * has_patch:  0 => 1
 * ui_ux:   => 0
 * easy:   => 0


Comment:

 Was a bit surprised by this one myself. I'm working on the idea that the
 MultiValueField is wrong rather than the docs since the validators arg is
 a core Field arg. Patch includes a regression test for this and a fix
 which appears to resolve the issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14184: Validators not called on MultiValueField

[Django]

#14184: Validators not called on MultiValueField
+---
  Reporter:  anonymous  | Owner:  nobody
Status:  new| Milestone:
 Component:  Forms  |   Version:  1.2   
Resolution: |  Keywords:  MultiValueField Validators
 Stage:  Accepted   | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by dmoisset):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Either the documentation or !MultiValueField are wrong. (I'd say that
 !MultiValueField is). Accepting

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14184: Validators not called on MultiValueField

[Django]

#14184: Validators not called on MultiValueField
+---
 Reporter:  anonymous   |   Owner:  nobody
   Status:  new |   Milestone:
Component:  Forms   | Version:  1.2   
 Keywords:  MultiValueField Validators  |   Stage:  Unreviewed
Has_patch:  0   |  
+---
 Validators are not called for the compressed value of a !MultiValueField.

 If, say, I have a {{{ MultiValueField }}} subclass which takes a first
 name and a last name and compresses the two into a "Lastname, Firstname"
 and this {{{ MultiValueField }}} subclass was instantiated using {{{
 validators = [disallow_john_doe] }}}, one would expect that {{{
 disallow_john_doe(compressed value) }}} would be executed. However, this
 is not the case.

 Looking at the source, it appears that while the {{{ clean() }}} method of
 {{{ django.forms.fields.Field }}} calls {{{ run_validators() }}}, the {{{
 clean() }}} method of {{{ django.forms.fields.MultiValueField }}} does
 not. This is different from expected behaviour and is not documented to my
 knowledge.

 The workaround is to implement {{{ validate() }}} in the subclass.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.