Re: [Django] #14586: Make interpolate JS function not require the named parameter.

[Django]

#14586: Make interpolate JS function not require the named parameter.
--+
 Reporter:  Amin Mirzaee  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Internationalization  |  Version:  1.2
 Severity:  Normal|   Resolution:  invalid
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Baptiste Mispelon):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 My js knowledge is not super strong but I think what this ticket is asking
 already works.
 In javascript, function parameters are always optional (and default to
 `undefined`).

 The documentation already shows example where `named` is not required:
 https://docs.djangoproject.com/en/4.0/topics/i18n/translation/#interpolate

 There are also tests using `interpolate` without `named`:
 
https://github.com/django/django/blob/806efe912b846c1fde250c9321d8334b7517cd56/tests/view_tests/templates/jsi18n.html#L23

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ed5795207eef08dc00922ad3bb1ef6e0%40djangoproject.com.

Re: [Django] #14586: Make interpolate JS function not require the named parameter.

[Django]

#14586: Make interpolate JS function not require the named parameter.
--+
 Reporter:  aminland  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  1.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by aaugustin):

 * needs_docs:  0 => 1
 * stage:  Design decision needed => Accepted


Comment:

 My JavaScript-fu is weak, but I'll try to move this forward...

 Apparently, JavaScript silently drop superfluous arguments, making this
 backwards-compatible. Julien, which backwards-incompatibilities did you
 have in mind?

 It still requires documenting the change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14586: Make interpolate JS function not require the named parameter.

[Django]

#14586: Make interpolate JS function not require the named parameter.
-+-
 Reporter:  aminland |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.2
Component:   |   Resolution:
  Internationalization   | Triage Stage:  Design
 Severity:  Normal   |  decision needed
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * stage:  Ready for checkin => Design decision needed


Comment:

 Please don't move a ticket out of DDN — that's a privilege of the core
 devs — and don't mark your own patches as RFC — we like to have two sets
 of eyes on a patch before it's marked as RFC.

 You can learn more about our workflow in the
 [https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
 tickets/ triage guide]. Thanks for your understanding!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14586: Make interpolate JS function not require the named parameter.

[Django]

#14586: Make interpolate JS function not require the named parameter.
-+-
 Reporter:  aminland |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.2
Component:   |   Resolution:
  Internationalization   | Triage Stage:  Ready for
 Severity:  Normal   |  checkin
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by aminland):

 * stage:  Design decision needed => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14586: Make interpolate JS function not require the named parameter.

[Django]

#14586: Make interpolate JS function not require the named parameter.
-+-
 Reporter:  aminland |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.2
Component:   |   Resolution:
  Internationalization   | Triage Stage:  Design
 Severity:  Normal   |  decision needed
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by anonymous):

 * ui_ux:   => 0
 * easy:   => 0


Comment:

 Looking at the two lines changed makes it pretty clear that backwards
 compatibility remains intact. The only thing it does is allow for the
 option to be omitted.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14586: Make interpolate JS function not require the named parameter.

[Django]

#14586: Make interpolate JS function not require the named parameter.
-+--
  Reporter:  aminland| Owner:  nobody
Status:  new | Milestone:
 Component:  Internationalization|   Version:  1.2   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by julien):

  * stage:  Unreviewed => Design decision needed
  * milestone:  1.3 =>

Comment:

 Making this change would likely break backwards compatibility. Needs more
 design discussion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14586: Make interpolate JS function not require the named parameter.

[Django]

#14586: Make interpolate JS function not require the named parameter.
---+
  Reporter:  aminland  | Owner:  nobody
Status:  new   | Milestone:  1.3   
 Component:  Internationalization  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by claudep):

  * needs_better_patch:  => 0
  * component:  Translations => Internationalization
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14586: Make interpolate JS function not require the named parameter.

[Django]

#14586: Make interpolate JS function not require the named parameter.
--+-
 Reporter:  aminland  |   Owner:  nobody
   Status:  new   |   Milestone:  1.3   
Component:  Translations  | Version:  1.2   
 Keywords:|   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 It is completely unnecessary and annoying to have to specify an additional
 parameter in Javascript
 when using a dictionary to fill in the strings. Switching back and forth
 between python and js, this
 can be often times forgotton, with bad results.

 With this fix, compatibility is maintained with all current utilizations.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.