Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+-
 Reporter:  ttencate@…   |Owner:  Deacalion
 Type:  Bug  |   Status:  closed
Component:  contrib.syndication  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a269ea4fe0a9a7195f1bd8bf5d462f48c226d525"]:
 {{{
 #!CommitTicketReference repository=""
 revision="a269ea4fe0a9a7195f1bd8bf5d462f48c226d525"
 Fixed #14656 -- Added Atom1Feed `published` element

 Some feed aggregators make use of the `published` element as well as
 the `updated` element (within the Atom standard -- http://bit.ly/2YySb).

 The standard allows for these two elements to be present in the same
 entry. `Atom1Feed` had implemented the `updated` element which was
 incorrectly taking the date from `pubdate`.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.6bb930b4def31a47ed3e4b578b3e769d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+-
 Reporter:  ttencate@…   |Owner:  Deacalion
 Type:  Bug  |   Status:  assigned
Component:  contrib.syndication  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Deacalion):

 * owner:  nobody => Deacalion
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.884ecf4ab05c9d256d1ebfbd885fecb5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+
 Reporter:  ttencate@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.syndication  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Deacalion):

 * version:  1.2 => master
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.a39967b74509616c1363cfaa75a396a0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+
 Reporter:  ttencate@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.syndication  |  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Deacalion):

 Code, tests and a shred of documentation can be found here:
 https://github.com/django/django/pull/1366

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.e6e7bd8a21dcbdee68f465ba4107454e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+
 Reporter:  ttencate@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.syndication  |  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * needs_tests:  0 => 1


Comment:

 This needs tests in order to get it committed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.a6e3643f18c6021db4638d5f24e29909%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+
 Reporter:  ttencate@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.syndication  |  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Deacalion):

 Completely forgot about this one, I'll add tests this evening.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.18abb760be1d2763fd3272bf01eb1e8c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+
 Reporter:  ttencate@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.syndication  |  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Deacalion):

 * cc: Deacalion (added)
 * has_patch:  0 => 1
 * ui_ux:   => 0


Comment:

 I came across this last night. I've attached a Git patch, for version
 1.3.1.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+-
   Reporter: |  Owner:  nobody
  ttencate@… | Status:  new
   Type:  Bug|  Component:  contrib.syndication
  Milestone: |   Severity:  Normal
Version:  1.2|   Keywords:
 Resolution: |  Has patch:  0
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-

Comment (by floledermann):

 It turns out that Google Reader is in fact ignoring publication dates in
 any format and always displays the date when an entry was first read:

 http://groups.google.com/group/google-reader-
 troubleshoot/browse_thread/thread/beba58f69bb364a0

 So in fact this bug seems to be rather academic.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+-
   Reporter: |  Owner:  nobody
  ttencate@… | Status:  new
   Type:  Bug|  Component:  contrib.syndication
  Milestone: |   Severity:  Normal
Version:  1.2|   Keywords:
 Resolution: |  Has patch:  0
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by floledermann):

 * easy:   => 0


Comment:

 Btw. a hacky workaround is monkeypatching the method:


 {{{
 from django.utils.feedgenerator import Atom1Feed, rfc3339_date


 # monkey patch buggy Atom implementation in Django
 Atom1Feed._add_item_elements = Atom1Feed.add_item_elements

 def atom1feed_add_item_elements_patched(self, handler, item, *args,
 **kwargs):
 if item['pubdate'] is not None:
 handler.addQuickElement(u"published",
 rfc3339_date(item['pubdate']).decode('utf-8'))
 # include args, kwargs for future compatibility
 self._add_item_elements(handler, item, *args, **kwargs)

 Atom1Feed.add_item_elements = atom1feed_add_item_elements_patched
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
--+---
   Reporter:  ttencate@…  |Owner:  nobody
   Type:  Bug |   Status:  new
  Milestone:  |Component:  contrib.syndication
Version:  1.2 | Severity:  Normal
 Resolution:  | Keywords:
   Triage Stage:  Accepted|Has patch:  0
Needs documentation:  0   |  Needs tests:  0
Patch needs improvement:  0   |
--+---
Changes (by jaddison):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
-+--
  Reporter:  ttenc...@gmail.com  | Owner:  nobody
Status:  new | Milestone:
 Component:  RSS framework   |   Version:  1.2   
Resolution:  |  Keywords:
 Stage:  Accepted| Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14656: Atom1Feed should write atom:published element

[Django]

#14656: Atom1Feed should write atom:published element
+---
 Reporter:  ttenc...@gmail.com  |   Owner:  nobody
   Status:  new |   Milestone:
Component:  RSS framework   | Version:  1.2   
 Keywords:  |   Stage:  Unreviewed
Has_patch:  0   |  
+---
 `Atom1Feed` currently produces XML like this:

 {{{
 #!xml
 
   ..
   
   2010-10-18T00:00:00+02:00
   ...
   ...
   ...
 
 }}}

 The thing to note here is that the date goes in the `atom:updated`
 element, not the `atom:published` element.

 The [http://tools.ietf.org/html/rfc4287#page-23 RFC] clearly suggests to
 me that this is not the intended usage:

 {{{
The "atom:updated" element is a Date construct indicating the most
recent instant in time when an entry or feed was modified in a way
the publisher considers significant.  Therefore, not all
modifications necessarily result in a changed atom:updated value.
 }}}

 Whereas:

 {{{
The "atom:published" element is a Date construct indicating an
instant in time associated with an event early in the life cycle of
the entry.
 }}}

 This is more than just a theoretical problem. Google Reader, for example,
 does not seem to use the updated element, and uses the date that it first
 saw the item appear. As a result, it does not order the items properly
 upon first import of the feed.

 The code in Django responsible for this:

 `django/utils/feedgenerator.py:331`

 {{{
 #!python
 if item['pubdate'] is not None:
 handler.addQuickElement(u"updated",
 rfc3339_date(item['pubdate']).decode('utf-8'))
 }}}

 There appears to be no mention of the `published` element.

 I suggest also writing the `published` element, because this is the
 intended usage of that element. The `updated` element is mandatory, so it
 should still be written as well.

 However, maybe this needs review by someone who knows more about Atom and
 the peculiarities of various feed readers.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.