Re: [Django] #14671: Allow overriding of ModelChoiceField.choices

[Django]

#14671: Allow overriding of ModelChoiceField.choices
---+
 Reporter:  simon29|Owner:  tbeadle
 Type:  Bug|   Status:  closed
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:  wontfix
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by tbeadle):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 I can't think of a use case where it makes sense to add abitrary choices
 to the ones available for a ModelChoiceField via its queryset.  See
 http://stackoverflow.com/questions/5281195/forms-modelchoicefield-
 queryset-extra-choice-fields-django-forms for a way to use a normal
 ChoiceField to accomplish this.

 If the desire is to change the appearance of the choices when they are
 rendered, there is the `ModelChoiceField.label_from_instance` method that
 can be overridden.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.518a030db36c424d7eec3af9f7037eba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14671: Allow overriding of ModelChoiceField.choices

[Django]

#14671: Allow overriding of ModelChoiceField.choices
---+
 Reporter:  simon29|Owner:  tbeadle
 Type:  Bug|   Status:  assigned
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by tbeadle):

 * owner:  nobody => tbeadle
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6252768af0f58e655a8b033823df4ff8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14671: Allow overriding of ModelChoiceField.choices

[Django]

#14671: Allow overriding of ModelChoiceField.choices
+-
   Reporter:  simon29   |Owner:  nobody
   Type:  Bug   |   Status:  new
  Milestone:|Component:  Forms
Version:  SVN   | Severity:  Normal
 Resolution:| Keywords:  sprintdec2010
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  1 |  Needs tests:  1
Patch needs improvement:  1 |
+-
Changes (by jaddison):

 * type:   => Bug
 * severity:   => Normal
 * milestone:  1.3 =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14671: Allow overriding of ModelChoiceField.choices

[Django]

#14671: Allow overriding of ModelChoiceField.choices
+-
   Reporter:  simon29   |Owner:  nobody
 Status:  new   |Milestone:  1.3
  Component:  Forms |  Version:  SVN
 Resolution:| Keywords:  sprintdec2010
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  1 |  Needs tests:  1
Patch needs improvement:  1 |
+-
Changes (by mk):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Comment:

 The patch needs documentation, tests and reasons why BaseModelFormSet and
 BaseInlineFormset should be added to __all__.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14671: Allow overriding of ModelChoiceField.choices

[Django]

#14671: Allow overriding of ModelChoiceField.choices
---+
  Reporter:  simon29   | Owner:  nobody   
Status:  new   | Milestone:  1.3  
 Component:  Forms |   Version:  SVN  
Resolution:|  Keywords:  sprintdec2010
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  1
Needs_better_patch:  0 |  
---+
Changes (by cogat):

  * keywords:  => sprintdec2010

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14671: Allow overriding of ModelChoiceField.choices

[Django]

#14671: Allow overriding of ModelChoiceField.choices
---+
  Reporter:  simon29   | Owner:  nobody
Status:  new   | Milestone:  1.3   
 Component:  Forms |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by cogat):

 * cc: cogat (removed)
  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

Comment:

 -1 on the addition of BaseModelFormSet to `__all__`. Although the classes
 can be useful, they are abstract, and can be imported explicitly with:

 {{{
 from forms.models import BaseModelFormSet
 }}}

 For the problem at hand, a test that illustrates the bug would help
 immensely. Reviewing the patch, it looks reasonable, except the choice of
 variable name for `pk`, given that something else could be in
 `self.to_field_name`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14671: Allow overriding of ModelChoiceField.choices

[Django]

#14671: Allow overriding of ModelChoiceField.choices
-+--
  Reporter:  simon29 | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Forms   |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by cogat):

 * cc: cogat (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14671: Allow overriding of ModelChoiceField.choices

[Django]

#14671: Allow overriding of ModelChoiceField.choices
-+--
  Reporter:  simon29 | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Forms   |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by simon29):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Note the patch has also swept up the addition of 'BaseModelFormSet',
 'BaseInlineFormSet' to __all__ (they can be useful!)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14671: Allow overriding of ModelChoiceField.choices

[Django]

#14671: Allow overriding of ModelChoiceField.choices
-+--
 Reporter:  simon29  |   Owner:  nobody
   Status:  new  |   Milestone:  1.3   
Component:  Forms| Version:  SVN   
 Keywords:   |   Stage:  Unreviewed
Has_patch:  1|  
-+--
 This patch fixes a validation bug when attempting to override choices
 manually on a ModelChoiceField. Comments in code suggest this should be
 able to be done.

 Note, this used to work until the recent model/form validation changes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.