Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+-
   Reporter: |Owner:  nobody
  summerisgone   |   Status:  closed
   Type:  Bug|Component:  contrib.auth
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  unusable_password,
 Resolution:  fixed  |  authorization, reset password,
   Triage Stage:  Accepted   |  sprintnov13
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  1  |  Needs tests:  0
-+-
Changes (by jezdez):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16455]:
 {{{
 #!CommitTicketReference repository="" revision="16455"
 Fixed #14674 -- Prevent user accounts with an unusable password from
 resetting passwords. Thanks, summerisgone, thejaswi_puthraya and lrekucki.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+-
   Reporter: |Owner:  nobody
  summerisgone   |   Status:  new
   Type:  Bug|Component:  contrib.auth
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  unusable_password,
 Resolution: |  authorization, reset password,
   Triage Stage:  Accepted   |  sprintnov13
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  1  |  Needs tests:  0
-+-
Changes (by jaddison):

 * type:   => Bug
 * severity:   => Normal
 * milestone:  1.3 =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+--
  Reporter:  summerisgone| Owner:  nobody   

Status:  new | Milestone:  1.3  

 Component:  Authentication  |   Version:  SVN  

Resolution:  |  Keywords:  unusable_password, 
authorization, reset password, sprintnov13
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  0

Needs_better_patch:  1   |  
-+--
Comment (by ramiro):

 Replying to [comment:10 lrekucki]:
 > Lack of "any" isn't a problem, 'cause you can just turn in into 3 line
 loop... or add it to {{{django.utils.itercompat}}} like I did

 FYI, I already added any() in r14563/r14565 with a simple and
 uncontroversial modification, feel free to pursue proposal of the bigger
 changes mods to itercompat you had implemented in your patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+--
  Reporter:  summerisgone| Owner:  nobody   

Status:  new | Milestone:  1.3  

 Component:  Authentication  |   Version:  SVN  

Resolution:  |  Keywords:  unusable_password, 
authorization, reset password, sprintnov13
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  0

Needs_better_patch:  1   |  
-+--
Comment (by lrekucki):

 Here's a patch. Lack of "any" isn't a problem, 'cause you can just turn in
 into 3 line loop... or add it to {{{django.utils.itercompat}}} like I did
 (we have all(), so I don't see a reason why we shouldn't have any()).
 Anyway, after giving this more thought, this can cause trouble if someone
 used the PasswordResetForm as part of his registration process. I know at
 least one application that would be affected, but this may just be a
 misuse of this form.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+--
  Reporter:  summerisgone| Owner:  nobody   

Status:  new | Milestone:  1.3  

 Component:  Authentication  |   Version:  SVN  

Resolution:  |  Keywords:  unusable_password, 
authorization, reset password, sprintnov13
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  0

Needs_better_patch:  1   |  
-+--
Comment (by thejaswi_puthraya):

 lrekucki,
 I like your patch but the 'any' function is part of python 2.5 and later.

 I am not sure if 2 'count' queries or evaluating the queryset is
 recommended.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+--
  Reporter:  summerisgone| Owner:  nobody   

Status:  new | Milestone:  1.3  

 Component:  Authentication  |   Version:  SVN  

Resolution:  |  Keywords:  unusable_password, 
authorization, reset password, sprintnov13
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  0

Needs_better_patch:  1   |  
-+--
Changes (by lrekucki):

 * cc: lrekucki (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+--
  Reporter:  summerisgone| Owner:  nobody   

Status:  new | Milestone:  1.3  

 Component:  Authentication  |   Version:  SVN  

Resolution:  |  Keywords:  unusable_password, 
authorization, reset password, sprintnov13
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  0

Needs_better_patch:  1   |  
-+--
Comment (by lrekucki):

 The current patch changes a single query that populates
 ``self.user_cache`` into to 2 queries that don't. I would suggest
 something in lines of:
 {{{
 if len(self.users_cache) == 0:
 raise forms.ValidationError(_("That e-mail address doesn't have an
 associated user account. Are you sure you've registered?"))
 if any((user.password == UNUSABLE_PASSWORD) for user in self.users_cache):
 raise forms.ValidationError(_("The user account associated with this
 email address cannot reset it's password."))
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+--
  Reporter:  summerisgone| Owner:  nobody   

Status:  new | Milestone:  1.3  

 Component:  Authentication  |   Version:  SVN  

Resolution:  |  Keywords:  unusable_password, 
authorization, reset password, sprintnov13
 Stage:  Accepted| Has_patch:  1

Needs_docs:  0   |   Needs_tests:  0

Needs_better_patch:  1   |  
-+--
Changes (by thejaswi_puthraya):

  * keywords:  unusable_password, authorization, reset password =>
   unusable_password, authorization, reset
   password, sprintnov13

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+--
  Reporter:  summerisgone| Owner:  nobody   
   
Status:  new | Milestone:  1.3  
   
 Component:  Authentication  |   Version:  SVN  
   
Resolution:  |  Keywords:  unusable_password, 
authorization, reset password
 Stage:  Accepted| Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  1   |  
-+--
Changes (by thejaswi_puthraya):

  * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+--
  Reporter:  summerisgone| Owner:  nobody   
   
Status:  new | Milestone:  1.3  
   
 Component:  Authentication  |   Version:  SVN  
   
Resolution:  |  Keywords:  unusable_password, 
authorization, reset password
 Stage:  Accepted| Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  1
   
Needs_better_patch:  1   |  
-+--
Comment (by thejaswi_puthraya):

 Patch is more or less the same as nessita's with the exception that it
 shows an error that the password cannot be changed for this account. Adds
 a test as an addition.

 Doesn't have the docs of nessita's patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
-+--
  Reporter:  summerisgone| Owner:  nobody   
   
Status:  new | Milestone:  1.3  
   
 Component:  Authentication  |   Version:  SVN  
   
Resolution:  |  Keywords:  unusable_password, 
authorization, reset password
 Stage:  Accepted| Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  1
   
Needs_better_patch:  1   |  
-+--
Changes (by nessita):

  * owner:  nessita => nobody
  * needs_better_patch:  0 => 1
  * component:  Uncategorized => Authentication
  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

Comment:

 The patch needs to also provide unit tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
+---
  Reporter:  summerisgone   | Owner:  nessita   
  
Status:  new| Milestone:  1.3   
  
 Component:  Uncategorized  |   Version:  SVN   
  
Resolution: |  Keywords:  unusable_password, 
authorization, reset password
 Stage:  Unreviewed | Has_patch:  1 
  
Needs_docs:  0  |   Needs_tests:  0 
  
Needs_better_patch:  0  |  
+---
Changes (by nessita):

  * owner:  nobody => nessita

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
+---
  Reporter:  summerisgone   | Owner:  nobody
  
Status:  new| Milestone:  1.3   
  
 Component:  Uncategorized  |   Version:  SVN   
  
Resolution: |  Keywords:  unusable_password, 
authorization, reset password
 Stage:  Unreviewed | Has_patch:  1 
  
Needs_docs:  0  |   Needs_tests:  0 
  
Needs_better_patch:  0  |  
+---
Changes (by summerisgone):

  * needs_better_patch:  => 0
  * has_patch:  0 => 1
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14674: ResetPasswordForm doesn't consider unusable_password setting

[Django]

#14674: ResetPasswordForm doesn't consider unusable_password setting
--+-
 Reporter:  summerisgone  |   Owner:  
nobody
   Status:  new   |   Milestone:  
1.3   
Component:  Uncategorized | Version:  
SVN   
 Keywords:  unusable_password, authorization, reset password  |   Stage:  
Unreviewed
Has_patch:  0 |  
--+-
 For example, users, who been logged in by LDAP, can change their password
 with {{{django.contrib.auth.forms.PasswordResetForm}}} and become
 independent from LDAP server.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.