Re: [Django] #14879: Aggregates (Min, Max) for CharField fails with Postgresql

[Django]

#14879: Aggregates (Min, Max) for CharField fails with Postgresql
-+-
 Reporter:  wejaay   |Owner:  wogan
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   |  worksforme
 Keywords:  aggregate,   | Triage Stage:  Accepted
  postgresql, charfield  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by slurms):

 * status:  assigned => closed
 * resolution:   => worksforme


Comment:

 I can't reproduce this on Django 1.5b2 and PostgreSQL 9.1.7. It appears
 convert_values was changed in commit
 12a96bfa263d514884ef11009913b2f8bb163472 and this would have fixed the
 issue.

 In [2]: User.objects.all().aggregate(Max('username'))
 Out[2]: {'username__max': u'test'}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14879: Aggregates (Min, Max) for CharField fails with Postgresql

[Django]

#14879: Aggregates (Min, Max) for CharField fails with Postgresql
-+-
 Reporter:  wejaay   |Owner:  wogan
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  aggregate,   |  Needs documentation:  0
  postgresql, charfield  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by carbonXT):

 * cc: mike@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14879: Aggregates (Min, Max) for CharField fails with Postgresql

[Django]

#14879: Aggregates (Min, Max) for CharField fails with Postgresql
-+-
   Reporter:  wejaay |Owner:  wogan
   Type:  Bug|   Status:  assigned
  Milestone: |Component:  Database layer
Version:  SVN|  (models, ORM)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:  aggregate,
Needs documentation:  0  |  postgresql, charfield
Patch needs improvement:  1  |Has patch:  1
 |  Needs tests:  1
-+-
Changes (by jaddison):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14879: Aggregates (Min, Max) for CharField fails with Postgresql

[Django]

#14879: Aggregates (Min, Max) for CharField fails with Postgresql
+---
   Reporter:  wejaay| Owner:  wogan 
  
 Status:  assigned  | Milestone:
  
  Component:  Database layer (models, ORM)  |   Version:  SVN   
  
 Resolution:|  Keywords:  
aggregate, postgresql, charfield
   Triage Stage:  Accepted  | Has patch:  1 
  
Needs documentation:  0 |   Needs tests:  1 
  
Patch needs improvement:  1 |  
+---
Changes (by wogan):

  * owner:  nobody => wogan
  * status:  new => assigned
  * version:  1.2 => SVN


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14879: Aggregates (Min, Max) for CharField fails with Postgresql

[Django]

#14879: Aggregates (Min, Max) for CharField fails with Postgresql
---+
  Reporter:  wejaay| Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  Database layer (models, ORM)  |   Version:  1.2
 
Resolution:|  Keywords:  aggregate, 
postgresql, charfield
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  1  
 
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * needs_better_patch:  => 1
  * has_patch:  0 => 1
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 1
  * needs_docs:  => 0

Comment:

 Marking has-patch because there is a proposed fix, but it needs tests, and
 needs to be turned into a diff.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14879: Aggregates (Min, Max) for CharField fails with Postgresql

[Django]

#14879: Aggregates (Min, Max) for CharField fails with Postgresql
--+-
 Reporter:  wejaay|   Owner:  nobody
   Status:  new   |   Milestone:
Component:  Database layer (models, ORM)  | Version:  1.2   
 Keywords:  aggregate, postgresql, charfield  |   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 If you try to do aggregate on a {{{CharField}}} using with Min or Max, it
 works fine in sqlite3 but fails in PostgresSQL. I have version 9.0 of
 postgres and latest dev version of django.

 The error occurs because Django is trying to convert the string to float
 in
 
http://code.djangoproject.com/browser/django/trunk/django/db/backends/__init__.py?rev=9742,
 line number 399.
 Thats the version where this code was first introduced and as far as I can
 tell its been broken all the way from then to most recent version
 
http://code.djangoproject.com/browser/django/trunk/django/db/backends/__init__.py,
 line 553.

 One fix that seems to work is to change line 549 from {{{ elif
 internal_type in ('DateField', 'DateTimeField', 'TimeField'):}}} to
 {{{elif internal_type in ('DateField', 'DateTimeField', 'TimeField',
 'CharField'):}}}

 I dont know if that has other side effects. If I am doing something wrong,
 please let me know.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.