Re: [Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
-+--
   Reporter:  jonash |  Owner:  nobody
   Type:  New feature| Status:  new
  Milestone: |  Component:  contrib.auth
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Someday/Maybe  |  Has patch:  1
Needs documentation:  1  |Needs tests:  1
Patch needs improvement:  1  |  Easy pickings:  0
-+--
Changes (by SmileyChris):

 * easy:   => 0
 * stage:  Design decision needed => Someday/Maybe


Comment:

 I'm going to shunt this to 'someday/maybe'.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
-+-
   Reporter:  jonash |Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  contrib.auth
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:
 Resolution: |Has patch:  1
   Triage Stage:  Design |  Needs tests:  1
  decision needed|
Needs documentation:  1  |
Patch needs improvement:  1  |
-+-
Changes (by jaddison):

 * type:   => New feature
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
--+-
   Reporter:  jonash  | Owner:  nobody
 Status:  new | Milestone:
  Component:  Authentication  |   Version:  SVN   
 Resolution:  |  Keywords:
   Triage Stage:  Design decision needed  | Has patch:  1 
Needs documentation:  1   |   Needs tests:  1 
Patch needs improvement:  1   |  
--+-
Changes (by wkornewald):

 * cc: wkornewald@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
-+--
  Reporter:  jonash  | Owner:  nobody
Status:  new | Milestone:
 Component:  Authentication  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  1 
Needs_better_patch:  1   |  
-+--
Changes (by jezdez):

  * needs_better_patch:  0 => 1
  * stage:  Unreviewed => Design decision needed
  * needs_tests:  0 => 1
  * milestone:  1.3 =>

Comment:

 So there are multiple things pretty unclear to me here.

 First, the assumption of merging the 3rd party fork "Django-nonrel" into
 trunk is wrong. There has never been an endorsement nor an announcement of
 this. Please refrain from giving this as a reason for a feature request.

 Second and more important, I don't see a reason to support non-integer IDs
 in 1.3 since none of the core ORM backends support that kind of thing. In
 other words, this has to wait till we have a proper story ourselves.

 Marking accordingly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
-+--
  Reporter:  jonash  | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Authentication  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by lrekucki):

 Replying to [comment:4 wkornewald]:
 > The base36 functions only work with integers. Since we have to deal with
 string here we just switched to base64.
 Right, I kept reading base32. Sorry for the noise.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
-+--
  Reporter:  jonash  | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Authentication  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by wkornewald):

 The base36 functions only work with integers. Since we have to deal with
 string here we just switched to base64.

 The purpose of this ticket is indeed to allow for a string-based
 `AutoField` (note, I don't mean `CharField(primary_key=True)`), but this
 is practically impossible to test on a SQL database because `AutoField` is
 always an integer. At least, I don't know how to change the `id` field to
 a `CharField` at runtime on SQL (not with a reasonable amount of effort).

 BTW, Jonas, you indeed still have to update the documentation. The current
 docs state that the reset views get a "uidb36" parameter which is
 base36-encoded.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
-+--
  Reporter:  jonash  | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Authentication  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by lrekucki):

 I was thinking, about something that tests that this works with a model
 with non-integer pk, but maybe I misunderstood the purpose of the ticket.

 I also fail to see how changing to base64 is related to this issue. I
 don't know what was the original cause to use base36, but I think it must
 had been something more then desire to use '-' in URL.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
-+--
  Reporter:  jonash  | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Authentication  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by wkornewald):

  * needs_tests:  1 => 0

Comment:

 The patch already contains changes to the auth unit tests. Isn't this
 enough? If not, please explain what is missing and please re-enable the
 "needs tests" checkbox.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
-+--
  Reporter:  jonash  | Owner:  nobody
Status:  new | Milestone:  1.3   
 Component:  Authentication  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  1 
Needs_better_patch:  0   |  
-+--
Changes (by lrekucki):

  * needs_better_patch:  => 0
  * needs_tests:  => 1
  * needs_docs:  => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's pasword reset feature

[Django]

#14881: Do not assume ``User.id`` to be an integer in django.contrib.auth's 
pasword
reset feature
+---
 Reporter:  jonash  |   Owner:  nobody
   Status:  new |   Milestone:  1.3   
Component:  Authentication  | Version:  SVN   
 Keywords:  |   Stage:  Unreviewed
Has_patch:  1   |  
+---
 This is a request to cherry-pick a recently submitted patch to Django-
 nonrel that makes it possible to use ``django.contrib.auth`` with
 databases that don't use integer-based auto IDs.

 The URL token has to be changed anyway when Django-nonrel gets merged into
 Django trunk in 1.4 (or whenever), so it might be more convenient to
 change this behaviour earlier.

 The patch does not do any backwards compatibility handling because I think
 it's not worth the effort although it should be rather easy (simply a
 compatibility URL associated with a view that un-base36s the id and then
 calls the wrapped view with the base64d ID).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.